[GitHub] [fluo] jkosh44 commented on a change in pull request #1083: [WIP] POC for Command module with centralized Command Pattern logic

[GitBox <gi...@apache.org>]

jkosh44 commented on a change in pull request #1083: [WIP] POC for Command module with centralized Command Pattern logic
URL: https://github.com/apache/fluo/pull/1083#discussion_r357470783
 
 

 ##########
 File path: modules/command/src/main/java/org/apache/fluo/command/FluoCommand.java
 ##########
 @@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
+ * agreements. See the NOTICE file distributed with this work for additional information regarding
+ * copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License. You may obtain a
+ * copy of the License at
+ * 
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions and limitations under
+ * the License.
+ */
+
+package org.apache.fluo.command;
+
+@FunctionalInterface
 
 Review comment:
   I thought it may be nice to be able to run a command as a lambda sometime in the future, however I don't actually take advantage of this annotation. It may be unnecessary and without it I could remove the default implementation for `isHelp()`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services