You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/07 05:01:55 UTC

[GitHub] [arrow] vvellanki commented on a change in pull request #9852: ARROW-12154: [C++][Gandiva] Fix gandiva crash in certain OS/CPU combinations

vvellanki commented on a change in pull request #9852:
URL: https://github.com/apache/arrow/pull/9852#discussion_r608340981



##########
File path: cpp/src/gandiva/engine.cc
##########
@@ -92,6 +93,15 @@ void Engine::InitOnce() {
   llvm::InitializeNativeTargetDisassembler();
   llvm::sys::DynamicLibrary::LoadLibraryPermanently(nullptr);
 
+  cpu_name = llvm::sys::getHostCPUName();
+  llvm::StringMap<bool> host_features;
+  if (llvm::sys::getHostCPUFeatures(host_features)) {
+    for (auto& f : host_features) {
+      std::string attr = f.second ? std::string("+") + f.first().str()
+                                  : std::string("-") + f.first().str();
+      cpu_attrs.push_back(attr);

Review comment:
       Can you a print statement to print the host_features?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org