You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/19 18:07:40 UTC
[GitHub] [airflow] ulisesojeda opened a new pull request #19713: Checking event.status.container_statuses before filtering
ulisesojeda opened a new pull request #19713:
URL: https://github.com/apache/airflow/pull/19713
Fix for issue https://github.com/apache/airflow/issues/19369
related: #19369
Checking list before calling built-in filter.
The bug happens because *event.status.container_statuses* is None when filter is called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19713: Checking event.status.container_statuses before filtering
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #19713:
URL: https://github.com/apache/airflow/pull/19713#issuecomment-976370503
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19713: Checking event.status.container_statuses before filtering
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #19713:
URL: https://github.com/apache/airflow/pull/19713#issuecomment-974293002
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #19713: Checking event.status.container_statuses before filtering
Posted by GitBox <gi...@apache.org>.
uranusjr merged pull request #19713:
URL: https://github.com/apache/airflow/pull/19713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19713: Checking event.status.container_statuses before filtering
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19713:
URL: https://github.com/apache/airflow/pull/19713#issuecomment-974678510
Static checks are failing. I recomend installing pre-commit to fix the problems automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19713: Checking event.status.container_statuses before filtering
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19713:
URL: https://github.com/apache/airflow/pull/19713#issuecomment-974678510
Static checks are failing. I recomend installing pre-commit to fix the problems automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19713: Checking event.status.container_statuses before filtering
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19713:
URL: https://github.com/apache/airflow/pull/19713#issuecomment-974677112
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ulisesojeda commented on pull request #19713: Checking event.status.container_statuses before filtering
Posted by GitBox <gi...@apache.org>.
ulisesojeda commented on pull request #19713:
URL: https://github.com/apache/airflow/pull/19713#issuecomment-974708469
> Static checks are failing. I recomend installing pre-commit to fix the problems automatically
Done. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ulisesojeda commented on pull request #19713: Checking event.status.container_statuses before filtering
Posted by GitBox <gi...@apache.org>.
ulisesojeda commented on pull request #19713:
URL: https://github.com/apache/airflow/pull/19713#issuecomment-974636898
> Can you add a unit test [here](tests/providers/cncf/kubernetes/utils/test_pod_launcher.py) to catch this if it regresses in the future?
Ready
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ulisesojeda commented on pull request #19713: Checking event.status.container_statuses before filtering
Posted by GitBox <gi...@apache.org>.
ulisesojeda commented on pull request #19713:
URL: https://github.com/apache/airflow/pull/19713#issuecomment-974636898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19713: Checking event.status.container_statuses before filtering
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19713:
URL: https://github.com/apache/airflow/pull/19713#issuecomment-974677112
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org