[GitHub] [solr] gerlowskija commented on pull request #81: SOLR-15351: Convert /v2/c/ APIs to POJO impl

[GitBox <gi...@apache.org>]

gerlowskija commented on pull request #81:
URL: https://github.com/apache/solr/pull/81#issuecomment-830093740


   > Do we really need all command endpoints in this one class, which I believe is your intention to do?
   
   That was my intention, yep - based mostly on how I read the existing convention with these files.  But I'm not strongly attached to that or anything.
   
   If we put the API logic itself in these files, then I definitely agree that each command would benefit from its own file.  But we're pretty far from that right now - right now FooAPi is just v2->v1 conversion logic.  And in the current form I think the "by path" grouping is reasonable.  Or at the very least, it does no harm.
   
   So I'm ambivalent currently.  If you feel strongly that each of these gets its own class, and you think there's benefits to that even before we split up the CollectionsHandler logic, then I'm open to going that route.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org