You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2022/07/19 08:36:03 UTC

[GitHub] [zookeeper] symat commented on pull request #1899: ZOOKEEPER-4565: Refine chroot strip to accommodate /zookeeper/ subtree

symat commented on PR #1899:
URL: https://github.com/apache/zookeeper/pull/1899#issuecomment-1188763956

   Thanks @kezhuw , I like your fix!
   I think we should make sure we don't break e.g. curator. We had some automated tests for that AFAIR... @eolivelli , what do you think?
   
   > One shortcoming of this fix and current design(aka. ClientCnxn.chroot) is that it does not work well with chroot /zookeeper.
   
   it is true... although I wouldn't consider this a very big issue. This is a special case which can be handled if needed. Doing the larger refactor would definitely break backward compatibility.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org