You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "fuweng11 (via GitHub)" <gi...@apache.org> on 2024/10/21 07:35:11 UTC
[PR] [INLONG-11377][Manager] Add verification for oceanusBase URL [inlong]
fuweng11 opened a new pull request, #11378:
URL: https://github.com/apache/inlong/pull/11378
<!-- Prepare a Pull Request
Change the title of pull request refer to the following example:
[INLONG-XYZ][Component] Title of the pull request
-->
<!-- Specify the issue this pull request going to fix.
The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)-->
Fixes #11377
### Motivation
Add verification for oceanusBase URL.
### Modifications
Add verification for oceanusBase URL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-11377][Manager] Add verification for oceanusBase URL [inlong]
Posted by "aloyszhang (via GitHub)" <gi...@apache.org>.
aloyszhang commented on code in PR #11378:
URL: https://github.com/apache/inlong/pull/11378#discussion_r1808407088
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/sink/oceanbase/OceanBaseJdbcUtils.java:
##########
@@ -71,6 +71,9 @@ public static Connection getConnection(String url, String user, String password)
*/
private static Connection establishDatabaseConnection(String url, String user, String password) throws Exception {
Connection conn;
+ if (StringUtils.isBlank(url) || !url.startsWith(OCEANBASE_JDBC_PREFIX)) {
+ throw new Exception("OceanusBase URL was invalid, it should start with jdbc:oceanbase");
Review Comment:
```suggestion
throw new Exception("OceanusBase URL is invalid, it should start with jdbc:oceanbase");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-11377][Manager] Add verification for oceanusBase URL [inlong]
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #11378:
URL: https://github.com/apache/inlong/pull/11378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-11377][Manager] Add verification for oceanusBase URL [inlong]
Posted by "fuweng11 (via GitHub)" <gi...@apache.org>.
fuweng11 commented on code in PR #11378:
URL: https://github.com/apache/inlong/pull/11378#discussion_r1808411476
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/sink/oceanbase/OceanBaseJdbcUtils.java:
##########
@@ -71,6 +71,9 @@ public static Connection getConnection(String url, String user, String password)
*/
private static Connection establishDatabaseConnection(String url, String user, String password) throws Exception {
Connection conn;
+ if (StringUtils.isBlank(url) || !url.startsWith(OCEANBASE_JDBC_PREFIX)) {
+ throw new Exception("OceanusBase URL was invalid, it should start with jdbc:oceanbase");
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org