You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/06/10 01:15:02 UTC
[kudu-CR] [cfile] replace BlockPointer::Equals() with operator==()
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20031
Change subject: [cfile] replace BlockPointer::Equals() with operator==()
......................................................................
[cfile] replace BlockPointer::Equals() with operator==()
The motivation for this change is an realisation that methods like
Equals() look a bit funny in C++ code since the language supports
much more expressive and readable way of comparing objects.
I also did a minor cleanup to bring the code in block_pointer.h
to the style guide and removed unused instances of the BlockPointer
class elsewhere in the code.
This patch doesn't contain any functional changes.
Change-Id: I3b2c05931ce4b678ef184d0c812cf0fb51b650c7
---
M src/kudu/cfile/block_pointer.h
M src/kudu/cfile/bloomfile.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/index_btree.cc
4 files changed, 26 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/20031/1
--
To view, visit http://gerrit.cloudera.org:8080/20031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b2c05931ce4b678ef184d0c812cf0fb51b650c7
Gerrit-Change-Number: 20031
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [cfile] replace BlockPointer::Equals() with operator==()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20031 )
Change subject: [cfile] replace BlockPointer::Equals() with operator==()
......................................................................
Patch Set 2: Verified+1
unrelated test failure in TabletCopyClientBasicTestModes/TabletCopyClientBasicTest.TestDownloadBlockMayFail/0 (ASAN)
--
To view, visit http://gerrit.cloudera.org:8080/20031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b2c05931ce4b678ef184d0c812cf0fb51b650c7
Gerrit-Change-Number: 20031
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Sat, 10 Jun 2023 02:47:38 +0000
Gerrit-HasComments: No
[kudu-CR] [cfile] replace BlockPointer::Equals() with operator==()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20031 )
Change subject: [cfile] replace BlockPointer::Equals() with operator==()
......................................................................
[cfile] replace BlockPointer::Equals() with operator==()
The motivation for this change is a realisation that methods like
Equals() look a bit funny in C++ code since the language supports
much more expressive and readable notation for comparing objects.
I also did a minor cleanup to bring the code in block_pointer.h
to the style guide and removed unused instances of the BlockPointer
class elsewhere in the code.
This patch doesn't contain any functional changes.
Change-Id: I3b2c05931ce4b678ef184d0c812cf0fb51b650c7
Reviewed-on: http://gerrit.cloudera.org:8080/20031
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/cfile/block_pointer.h
M src/kudu/cfile/bloomfile.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/index_btree.cc
4 files changed, 26 insertions(+), 27 deletions(-)
Approvals:
Alexey Serbin: Verified
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/20031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b2c05931ce4b678ef184d0c812cf0fb51b650c7
Gerrit-Change-Number: 20031
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [cfile] replace BlockPointer::Equals() with operator==()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [cfile] replace BlockPointer::Equals() with operator==()
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/20031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I3b2c05931ce4b678ef184d0c812cf0fb51b650c7
Gerrit-Change-Number: 20031
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [cfile] replace BlockPointer::Equals() with operator==()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20031
to look at the new patch set (#2).
Change subject: [cfile] replace BlockPointer::Equals() with operator==()
......................................................................
[cfile] replace BlockPointer::Equals() with operator==()
The motivation for this change is a realisation that methods like
Equals() look a bit funny in C++ code since the language supports
much more expressive and readable notation for comparing objects.
I also did a minor cleanup to bring the code in block_pointer.h
to the style guide and removed unused instances of the BlockPointer
class elsewhere in the code.
This patch doesn't contain any functional changes.
Change-Id: I3b2c05931ce4b678ef184d0c812cf0fb51b650c7
---
M src/kudu/cfile/block_pointer.h
M src/kudu/cfile/bloomfile.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/index_btree.cc
4 files changed, 26 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/20031/2
--
To view, visit http://gerrit.cloudera.org:8080/20031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3b2c05931ce4b678ef184d0c812cf0fb51b650c7
Gerrit-Change-Number: 20031
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [cfile] replace BlockPointer::Equals() with operator==()
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20031 )
Change subject: [cfile] replace BlockPointer::Equals() with operator==()
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b2c05931ce4b678ef184d0c812cf0fb51b650c7
Gerrit-Change-Number: 20031
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Sat, 10 Jun 2023 03:43:53 +0000
Gerrit-HasComments: No