You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@seata.apache.org by "dreamskyvision (via GitHub)" <gi...@apache.org> on 2023/12/25 08:55:06 UTC
[PR] bugfix: fix the problem that The incorrect configuration needs to be fixed. #6203 [incubator-seata]
dreamskyvision opened a new pull request, #6204:
URL: https://github.com/apache/incubator-seata/pull/6204
The incorrect configuration needs to be fixed. fixed. #6203
<!-- Please make sure you have read and understood the contributing guidelines -->
- [ ] I have registered the PR [changes](../changes).
### Ⅰ. Describe what this PR did
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
### Ⅲ. Why don't you add test cases (unit test/integration test)?
it’s just a single configeration file modify
### Ⅳ. Describe how to verify it
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For additional commands, e-mail: dev-help@seata.apache.org
Re: [PR] bugfix: fix the problem that The incorrect configuration needs to be fixed [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes merged PR #6204:
URL: https://github.com/apache/incubator-seata/pull/6204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For additional commands, e-mail: dev-help@seata.apache.org
Re: [PR] bugfix: fix the problem that The incorrect configuration needs to be fixed. #6203 [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #6204:
URL: https://github.com/apache/incubator-seata/pull/6204#discussion_r1436023416
##########
server/src/main/resources/application.example.yml:
##########
@@ -127,7 +127,7 @@ seata:
server:
raft:
group: default
- cluster:
+ server-addr:
Review Comment:
请直接把application.example.yml中的raft配置全部删除,因为在application.raft.example.yml中已经有相关配置了
Please delete all the raft configurations in application.example.yml directly, because there are already relevant configurations in application.raft.example.yml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For additional commands, e-mail: dev-help@seata.apache.org
Re: [PR] bugfix: fix the problem that The incorrect configuration needs to be fixed [incubator-seata]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6204:
URL: https://github.com/apache/incubator-seata/pull/6204#issuecomment-1868871177
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/6204?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`1a57f2d`)](https://app.codecov.io/gh/apache/incubator-seata/commit/1a57f2d71dc2260d30644fe68d6f8f21b39dbb85?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 49.03% compared to head [(`31d1e20`)](https://app.codecov.io/gh/apache/incubator-seata/pull/6204?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 48.98%.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/incubator-seata/pull/6204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## 2.x #6204 +/- ##
============================================
- Coverage 49.03% 48.98% -0.06%
+ Complexity 4786 4779 -7
============================================
Files 915 915
Lines 31896 31896
Branches 3855 3855
============================================
- Hits 15641 15625 -16
- Misses 14699 14709 +10
- Partials 1556 1562 +6
```
[see 6 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/6204/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For additional commands, e-mail: dev-help@seata.apache.org