[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #183: HDDS-2505. Fix logic related to SCM address calculation in HddsUtils

[GitBox <gi...@apache.org>]

adoroszlai opened a new pull request #183: HDDS-2505. Fix logic related to SCM address calculation in HddsUtils
URL: https://github.com/apache/hadoop-ozone/pull/183
 
 
   ## What changes were proposed in this pull request?
   
    * Get rid of unreachable `if` branches in `HddsUtils` methods, as reported by Sonar
    * Reduce duplication:
      * `getHostNameFromConfigKeys` already supports multiple keys for fallback
      * extract the exception about unsupported multi-SCM
    * Use `OptionalInt` instead of `Optional<Integer>` for ports
    * Move usage of config key and its default value closer
    * Remove unused `getScmServiceRpcAddresses()`
    * Flip `assertEquals` args
    * Avoid `String.format` in logging
    * Remove `@param` without description
   
   https://issues.apache.org/jira/browse/HDDS-2505
   
   ## How was this patch tested?
   
   Unit tests (host/port lookup has good coverage).  Also ran `ozone` acceptance test locally.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org