You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/26 16:58:20 UTC
[GitHub] [spark] chia7712 opened a new pull request #35026: SPARK-37746 log4j2-defaults.properties is not working since log4j 2 i…
chia7712 opened a new pull request #35026:
URL: https://github.com/apache/spark/pull/35026
…s always initialized by default
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Change the behavior of checking initialization of log4j 2
the code used to check initialization is shown below.
```scala
val log4j2Initialized = !LogManager.getRootLogger
.asInstanceOf[org.apache.logging.log4j.core.Logger].getAppenders.isEmpty
```
That works for log4j. However, log4j2 provides a default configuration so there is always a appender (`ConsoleAppender`) with `ERROR` level.
### Why are the changes needed?
`log4j2-defaults.properties` does not work, since log4j 2 is always initialized by default configuration.
### Does this PR introduce _any_ user-facing change?
This patch tries to eliminate the user-facing change after migrating to log4j2.
1. the root level is `ERROR` now but previous root level was `INFO`.
2. `log4j2-defaults.properties` is not loaded but `log4j-defaults.properties` was used to initialize log4j.
### How was this patch tested?
I test it manually in k8s. It shows INFO level message as before now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #35026: SPARK-37746 log4j2-defaults.properties is not working since log4j 2 i…
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35026:
URL: https://github.com/apache/spark/pull/35026#issuecomment-1001213446
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #35026: [SPARK-37746][CORE] log4j2-defaults.properties is not working since log4j 2 is always initialized by default
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #35026:
URL: https://github.com/apache/spark/pull/35026#issuecomment-1001699626
GA seems unstable. But I checked the latest two rounds of CI results. CI only failed with download on "Run Docker integration test" for commit b26c86c. On latest commit, CI failed on `KafkaMicroBatchV1SourceWithAdminSuite` and failed to pull branch for "sql - other tests" that were passed in previous commit. The above two commits are syncing up with master only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] chia7712 commented on a change in pull request #35026: [SPARK-37746][CORE] log4j2-defaults.properties is not working since log4j 2 is always initialized by default
Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #35026:
URL: https://github.com/apache/spark/pull/35026#discussion_r775280584
##########
File path: core/src/main/scala/org/apache/spark/internal/Logging.scala
##########
@@ -126,11 +126,14 @@ trait Logging {
private def initializeLogging(isInterpreter: Boolean, silent: Boolean): Unit = {
if (Logging.isLog4j2()) {
- // If Log4j is used but is not initialized, load a default properties file
- val log4j2Initialized = !LogManager.getRootLogger
- .asInstanceOf[org.apache.logging.log4j.core.Logger].getAppenders.isEmpty
+ val rootLogger = LogManager.getRootLogger.asInstanceOf[org.apache.logging.log4j.core.Logger]
+ // If Log4j 2 is used but is initialized by default configuration,
+ // load a default properties file
+ // (see org.apache.logging.log4j.core.config.DefaultConfiguration)
+ val needToInitializeLog4j2 = rootLogger.getAppenders.isEmpty ||
+ (rootLogger.getAppenders.size() == 1 && rootLogger.getLevel == Level.ERROR)
Review comment:
@viirya thanks for your comments. will copy that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] chia7712 commented on a change in pull request #35026: [SPARK-37746][CORE] log4j2-defaults.properties is not working since log4j 2 is always initialized by default
Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #35026:
URL: https://github.com/apache/spark/pull/35026#discussion_r775284484
##########
File path: core/src/main/scala/org/apache/spark/internal/Logging.scala
##########
@@ -126,11 +126,14 @@ trait Logging {
private def initializeLogging(isInterpreter: Boolean, silent: Boolean): Unit = {
if (Logging.isLog4j2()) {
- // If Log4j is used but is not initialized, load a default properties file
- val log4j2Initialized = !LogManager.getRootLogger
- .asInstanceOf[org.apache.logging.log4j.core.Logger].getAppenders.isEmpty
+ val rootLogger = LogManager.getRootLogger.asInstanceOf[org.apache.logging.log4j.core.Logger]
+ // If Log4j 2 is used but is initialized by default configuration,
+ // load a default properties file
+ // (see org.apache.logging.log4j.core.config.DefaultConfiguration)
+ val needToInitializeLog4j2 = rootLogger.getAppenders.isEmpty ||
+ (rootLogger.getAppenders.size() == 1 && rootLogger.getLevel == Level.ERROR)
Review comment:
> https://github.com/apache/logging-log4j2/blob/5edf43758f104affad9842753e66be173fc4d68a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java#L708
the name includes the "hash code", so it is hard to match the name absolutely. I check the class of `Configuration` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #35026: SPARK-37746 log4j2-defaults.properties is not working since log4j 2 i…
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #35026:
URL: https://github.com/apache/spark/pull/35026#discussion_r775279418
##########
File path: core/src/main/scala/org/apache/spark/internal/Logging.scala
##########
@@ -126,11 +126,14 @@ trait Logging {
private def initializeLogging(isInterpreter: Boolean, silent: Boolean): Unit = {
if (Logging.isLog4j2()) {
- // If Log4j is used but is not initialized, load a default properties file
- val log4j2Initialized = !LogManager.getRootLogger
- .asInstanceOf[org.apache.logging.log4j.core.Logger].getAppenders.isEmpty
+ val rootLogger = LogManager.getRootLogger.asInstanceOf[org.apache.logging.log4j.core.Logger]
+ // If Log4j 2 is used but is initialized by default configuration,
+ // load a default properties file
+ // (see org.apache.logging.log4j.core.config.DefaultConfiguration)
+ val needToInitializeLog4j2 = rootLogger.getAppenders.isEmpty ||
+ (rootLogger.getAppenders.size() == 1 && rootLogger.getLevel == Level.ERROR)
Review comment:
This looks not reliable. It seems possible to wrongly treat a user log4j configuration as default configuration. Can we check if the configuration name is `DefaultConfiguration.DEFAULT_NAME`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #35026: [SPARK-37746][CORE] log4j2-defaults.properties is not working since log4j 2 is always initialized by default
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #35026:
URL: https://github.com/apache/spark/pull/35026#issuecomment-1001330776
@chia7712 Can you add an empty commit to re-trigger CI? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #35026: [SPARK-37746][CORE] log4j2-defaults.properties is not working since log4j 2 is always initialized by default
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #35026:
URL: https://github.com/apache/spark/pull/35026#discussion_r775280208
##########
File path: core/src/main/scala/org/apache/spark/internal/Logging.scala
##########
@@ -126,11 +126,14 @@ trait Logging {
private def initializeLogging(isInterpreter: Boolean, silent: Boolean): Unit = {
if (Logging.isLog4j2()) {
- // If Log4j is used but is not initialized, load a default properties file
- val log4j2Initialized = !LogManager.getRootLogger
- .asInstanceOf[org.apache.logging.log4j.core.Logger].getAppenders.isEmpty
+ val rootLogger = LogManager.getRootLogger.asInstanceOf[org.apache.logging.log4j.core.Logger]
+ // If Log4j 2 is used but is initialized by default configuration,
+ // load a default properties file
+ // (see org.apache.logging.log4j.core.config.DefaultConfiguration)
+ val needToInitializeLog4j2 = rootLogger.getAppenders.isEmpty ||
+ (rootLogger.getAppenders.size() == 1 && rootLogger.getLevel == Level.ERROR)
Review comment:
https://github.com/apache/logging-log4j2/blob/5edf43758f104affad9842753e66be173fc4d68a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java#L708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #35026: [SPARK-37746][CORE] log4j2-defaults.properties is not working since log4j 2 is always initialized by default
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #35026:
URL: https://github.com/apache/spark/pull/35026#discussion_r775286698
##########
File path: core/src/main/scala/org/apache/spark/internal/Logging.scala
##########
@@ -126,11 +126,14 @@ trait Logging {
private def initializeLogging(isInterpreter: Boolean, silent: Boolean): Unit = {
if (Logging.isLog4j2()) {
- // If Log4j is used but is not initialized, load a default properties file
- val log4j2Initialized = !LogManager.getRootLogger
- .asInstanceOf[org.apache.logging.log4j.core.Logger].getAppenders.isEmpty
+ val rootLogger = LogManager.getRootLogger.asInstanceOf[org.apache.logging.log4j.core.Logger]
+ // If Log4j 2 is used but is initialized by default configuration,
+ // load a default properties file
+ // (see org.apache.logging.log4j.core.config.DefaultConfiguration)
+ val needToInitializeLog4j2 = rootLogger.getAppenders.isEmpty ||
+ (rootLogger.getAppenders.size() == 1 && rootLogger.getLevel == Level.ERROR)
Review comment:
Hmm, I think we can compare with `DefaultConfiguration.DEFAULT_NAME + "@"`? Checking if it is `DefaultConfiguration` seems fine too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #35026: [SPARK-37746][CORE] log4j2-defaults.properties is not working since log4j 2 is always initialized by default
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #35026:
URL: https://github.com/apache/spark/pull/35026#issuecomment-1001386724
GA has a weird error:
```
Run echo "APACHE_SPARK_REF=$(git rev-parse HEAD)" >> $GITHUB_ENV
error: RPC failed; curl 56 GnuTLS recv error (-54): Error in the pull function.
error: 1829 bytes of body are still expected
fetch-pack: unexpected disconnect while reading sideband packet
fatal: protocol error: bad pack header
Error: Process completed with exit code 128.
```
Please submit an empty to re-trigger it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #35026: [SPARK-37746][CORE] log4j2-defaults.properties is not working since log4j 2 is always initialized by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #35026:
URL: https://github.com/apache/spark/pull/35026#issuecomment-1001213446
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #35026: [SPARK-37746][CORE] log4j2-defaults.properties is not working since log4j 2 is always initialized by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35026:
URL: https://github.com/apache/spark/pull/35026#issuecomment-1001248795
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] chia7712 commented on pull request #35026: [SPARK-37746][CORE] log4j2-defaults.properties is not working since log4j 2 is always initialized by default
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #35026:
URL: https://github.com/apache/spark/pull/35026#issuecomment-1001331364
> Can you add an empty commit to re-trigger CI? Thanks.
done. I rebase the master branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya closed pull request #35026: [SPARK-37746][CORE] log4j2-defaults.properties is not working since log4j 2 is always initialized by default
Posted by GitBox <gi...@apache.org>.
viirya closed pull request #35026:
URL: https://github.com/apache/spark/pull/35026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #35026: [SPARK-37746][CORE] log4j2-defaults.properties is not working since log4j 2 is always initialized by default
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #35026:
URL: https://github.com/apache/spark/pull/35026#discussion_r776936642
##########
File path: core/src/main/resources/org/apache/spark/log4j2-defaults.properties
##########
@@ -16,7 +16,7 @@
#
# Set everything to be logged to the console
-rootLogger.level = warn
Review comment:
Hm, after this Pr, it causes this issue https://issues.apache.org/jira/browse/SPARK-37792. I think the issue is actually from the initial migration PR, and this change accidentally hid the problem ..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] chia7712 commented on a change in pull request #35026: [SPARK-37746][CORE] log4j2-defaults.properties is not working since log4j 2 is always initialized by default
Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #35026:
URL: https://github.com/apache/spark/pull/35026#discussion_r776963312
##########
File path: core/src/main/resources/org/apache/spark/log4j2-defaults.properties
##########
@@ -16,7 +16,7 @@
#
# Set everything to be logged to the console
-rootLogger.level = warn
Review comment:
I will dig in it later.thanks
##########
File path: core/src/main/resources/org/apache/spark/log4j2-defaults.properties
##########
@@ -16,7 +16,7 @@
#
# Set everything to be logged to the console
-rootLogger.level = warn
Review comment:
I will dig in it later. thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #35026: [SPARK-37746][CORE] log4j2-defaults.properties is not working since log4j 2 is always initialized by default
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #35026:
URL: https://github.com/apache/spark/pull/35026#discussion_r775286853
##########
File path: core/src/main/scala/org/apache/spark/internal/Logging.scala
##########
@@ -126,11 +127,17 @@ trait Logging {
private def initializeLogging(isInterpreter: Boolean, silent: Boolean): Unit = {
if (Logging.isLog4j2()) {
- // If Log4j is used but is not initialized, load a default properties file
- val log4j2Initialized = !LogManager.getRootLogger
- .asInstanceOf[org.apache.logging.log4j.core.Logger].getAppenders.isEmpty
+ val rootLogger = LogManager.getRootLogger.asInstanceOf[org.apache.logging.log4j.core.Logger]
+ // If Log4j 2 is used but is initialized by default configuration,
+ // load a default properties file
+ // (see org.apache.logging.log4j.core.config.DefaultConfiguration)
+ val needToInitializeLog4j2 = rootLogger.getAppenders.isEmpty ||
+ (rootLogger.getAppenders.size() == 1 &&
+ rootLogger.getLevel == Level.ERROR &&
Review comment:
The default level could be configured and maybe not `ERROR`. But I guess once user specifies it, it may meaning they want to set it up so we don't need to load Spark default properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #35026: SPARK-37746 log4j2-defaults.properties is not working since log4j 2 i…
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #35026:
URL: https://github.com/apache/spark/pull/35026#discussion_r775279466
##########
File path: core/src/main/resources/org/apache/spark/log4j2-defaults.properties
##########
@@ -16,7 +16,7 @@
#
# Set everything to be logged to the console
-rootLogger.level = warn
+rootLogger.level = info
Review comment:
Oh, I might be copying it wrongly. The original property is info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #35026: [SPARK-37746][CORE] log4j2-defaults.properties is not working since log4j 2 is always initialized by default
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #35026:
URL: https://github.com/apache/spark/pull/35026#issuecomment-1001233559
ok to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #35026: [SPARK-37746][CORE] log4j2-defaults.properties is not working since log4j 2 is always initialized by default
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #35026:
URL: https://github.com/apache/spark/pull/35026#issuecomment-1001707183
Thanks for the fix. Merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org