You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/05/20 06:23:26 UTC
[GitHub] [incubator-hudi] xushiyan opened a new pull request #1644: [HUDI-811] Restructure test packages in hudi-common
xushiyan opened a new pull request #1644:
URL: https://github.com/apache/incubator-hudi/pull/1644
Categorize test classes by moving them to `testutils` and `functional` subpackages.
The following modules were migrated.
* hudi-common
Follows #1607
### Migration status (after merging)
| Package | JUnit 5 lib | API migration | Restructure packages |
| --- | --- | --- | --- |
| `hudi-cli` | ✅ | ✅ | - |
| `hudi-client` | ✅ | ✅ | - |
| `hudi-common` | ✅ | ✅ | ✅ |
| `hudi-hadoop-mr` | ✅ | ✅ | ✅ |
| `hudi-hive-sync` | ✅ | ✅ | ✅ |
| `hudi-integ-test` | ✅ | ✅ | N.A. |
| `hudi-spark` | ✅ | ✅ | ✅ |
| `hudi-timeline-service` | ✅ | ✅ | ✅ |
| `hudi-utilities` | ✅ | ✅ | ✅ |
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] codecov-commenter edited a comment on pull request #1644: [HUDI-811] Restructure test packages in hudi-common
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1644:
URL: https://github.com/apache/incubator-hudi/pull/1644#issuecomment-631673778
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=h1) Report
> Merging [#1644](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/6a0aa9a645d11ed7b50e18aa0563dafcd9d145f7&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1644 +/- ##
============================================
- Coverage 18.33% 18.30% -0.03%
+ Complexity 855 854 -1
============================================
Files 344 344
Lines 15167 15167
Branches 1512 1512
============================================
- Hits 2781 2777 -4
- Misses 12033 12036 +3
- Partials 353 354 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/hudi/common/table/log/HoodieLogFileReader.java](https://codecov.io/gh/apache/incubator-hudi/pull/1644/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGaWxlUmVhZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...che/hudi/common/table/timeline/TimelineLayout.java](https://codecov.io/gh/apache/incubator-hudi/pull/1644/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL1RpbWVsaW5lTGF5b3V0LmphdmE=) | `78.57% <0.00%> (-14.29%)` | `3.00% <0.00%> (ø%)` | |
| [...apache/hudi/common/fs/HoodieWrapperFileSystem.java](https://codecov.io/gh/apache/incubator-hudi/pull/1644/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0hvb2RpZVdyYXBwZXJGaWxlU3lzdGVtLmphdmE=) | `21.98% <0.00%> (-0.71%)` | `28.00% <0.00%> (-1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=footer). Last update [6a0aa9a...ed4ca32](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] xushiyan commented on a change in pull request #1644: [HUDI-811] Restructure test packages in hudi-common
Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #1644:
URL: https://github.com/apache/incubator-hudi/pull/1644#discussion_r428757663
##########
File path: hudi-common/src/test/java/org/apache/hudi/common/util/collection/TestRocksDBDAO.java
##########
@@ -45,7 +45,7 @@
/**
* Tests RocksDB manager {@link RocksDBDAO}.
*/
-public class TestRocksDBManager {
+public class TestRocksDBDAO {
Review comment:
@yanghua I'm trying to align it with the class under test, which is `RocksDBDAO`. So the pattern is to prefix it with `Test`. Given that we only have `RocksDBDAO` class not `RocksDBManager`, figuring we'd better align it with the test name to avoid confusion. Sound good?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] xushiyan edited a comment on pull request #1644: [HUDI-811] Restructure test packages in hudi-common
Posted by GitBox <gi...@apache.org>.
xushiyan edited a comment on pull request #1644:
URL: https://github.com/apache/incubator-hudi/pull/1644#issuecomment-631577878
Test classes under `functional` and `testutils`
- `TestHoodieLogFormat` and `TestHoodieLogFormatAppendFailure` involves minicluster hence go to `functional`
- Tried to move `org.apache.hudi.common.util.TestDFSPropertiesConfiguration` to `functional` but ran into errors from `TestParquetUtils` which implies inter-class side-effects. The investigation is beyond the scope of this PR, hence leaving it there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] codecov-commenter edited a comment on pull request #1644: [HUDI-811] Restructure test packages in hudi-common
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1644:
URL: https://github.com/apache/incubator-hudi/pull/1644#issuecomment-631673778
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=h1) Report
> Merging [#1644](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/6a0aa9a645d11ed7b50e18aa0563dafcd9d145f7&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1644 +/- ##
============================================
- Coverage 18.33% 18.32% -0.02%
+ Complexity 855 854 -1
============================================
Files 344 344
Lines 15167 15167
Branches 1512 1512
============================================
- Hits 2781 2779 -2
- Misses 12033 12035 +2
Partials 353 353
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/hudi/common/table/log/HoodieLogFileReader.java](https://codecov.io/gh/apache/incubator-hudi/pull/1644/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGaWxlUmVhZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/hudi/common/fs/HoodieWrapperFileSystem.java](https://codecov.io/gh/apache/incubator-hudi/pull/1644/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0hvb2RpZVdyYXBwZXJGaWxlU3lzdGVtLmphdmE=) | `21.98% <0.00%> (-0.71%)` | `28.00% <0.00%> (-1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=footer). Last update [6a0aa9a...6f52762](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] codecov-commenter edited a comment on pull request #1644: [HUDI-811] Restructure test packages in hudi-common
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1644:
URL: https://github.com/apache/incubator-hudi/pull/1644#issuecomment-631673778
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=h1) Report
> Merging [#1644](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/6a0aa9a645d11ed7b50e18aa0563dafcd9d145f7&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1644 +/- ##
============================================
- Coverage 18.33% 18.30% -0.03%
+ Complexity 855 854 -1
============================================
Files 344 344
Lines 15167 15167
Branches 1512 1512
============================================
- Hits 2781 2777 -4
- Misses 12033 12036 +3
- Partials 353 354 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/hudi/common/table/timeline/TimelineLayout.java](https://codecov.io/gh/apache/incubator-hudi/pull/1644/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL1RpbWVsaW5lTGF5b3V0LmphdmE=) | `78.57% <0.00%> (-14.29%)` | `3.00% <0.00%> (ø%)` | |
| [...apache/hudi/common/fs/HoodieWrapperFileSystem.java](https://codecov.io/gh/apache/incubator-hudi/pull/1644/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0hvb2RpZVdyYXBwZXJGaWxlU3lzdGVtLmphdmE=) | `21.98% <0.00%> (-0.71%)` | `28.00% <0.00%> (-1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=footer). Last update [6a0aa9a...2915023](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] codecov-commenter edited a comment on pull request #1644: [HUDI-811] Restructure test packages in hudi-common
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1644:
URL: https://github.com/apache/incubator-hudi/pull/1644#issuecomment-631673778
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=h1) Report
> Merging [#1644](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/6a0aa9a645d11ed7b50e18aa0563dafcd9d145f7&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1644 +/- ##
=========================================
Coverage 18.33% 18.33%
Complexity 855 855
=========================================
Files 344 344
Lines 15167 15167
Branches 1512 1512
=========================================
Hits 2781 2781
Misses 12033 12033
Partials 353 353
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=footer). Last update [6a0aa9a...af47cf0](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] xushiyan commented on a change in pull request #1644: [HUDI-811] Restructure test packages in hudi-common
Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #1644:
URL: https://github.com/apache/incubator-hudi/pull/1644#discussion_r428757663
##########
File path: hudi-common/src/test/java/org/apache/hudi/common/util/collection/TestRocksDBDAO.java
##########
@@ -45,7 +45,7 @@
/**
* Tests RocksDB manager {@link RocksDBDAO}.
*/
-public class TestRocksDBManager {
+public class TestRocksDBDAO {
Review comment:
@yanghua I'm trying to align it with the class under test, which is `RocksDBDAO`. So the pattern is to prefix it with `Test`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] yanghua commented on a change in pull request #1644: [HUDI-811] Restructure test packages in hudi-common
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #1644:
URL: https://github.com/apache/incubator-hudi/pull/1644#discussion_r428506563
##########
File path: hudi-common/src/test/java/org/apache/hudi/common/fs/inline/TestInLineFileSystemHFileInLining.java
##########
@@ -40,18 +42,18 @@
import java.util.Set;
import java.util.UUID;
-import static org.apache.hudi.common.fs.inline.FileSystemTestUtils.FILE_SCHEME;
-import static org.apache.hudi.common.fs.inline.FileSystemTestUtils.RANDOM;
-import static org.apache.hudi.common.fs.inline.FileSystemTestUtils.getPhantomFile;
-import static org.apache.hudi.common.fs.inline.FileSystemTestUtils.getRandomOuterInMemPath;
+import static org.apache.hudi.common.testutils.FileSystemTestUtils.FILE_SCHEME;
+import static org.apache.hudi.common.testutils.FileSystemTestUtils.RANDOM;
+import static org.apache.hudi.common.testutils.FileSystemTestUtils.getPhantomFile;
+import static org.apache.hudi.common.testutils.FileSystemTestUtils.getRandomOuterInMemPath;
import static org.junit.jupiter.api.Assertions.assertArrayEquals;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotEquals;
/**
* Tests {@link InLineFileSystem} to inline HFile.
*/
-public class TestHFileInLining {
+public class TestInLineFileSystemHFileInLining {
Review comment:
Can we rename to `TestInLineFileSystem`?
##########
File path: hudi-common/src/test/java/org/apache/hudi/common/fs/inline/TestInLineFileSystemHFileInLining.java
##########
@@ -60,7 +62,7 @@
private int maxRows = 100 + RANDOM.nextInt(1000);
private Path generatedPath;
- public TestHFileInLining() {
+ public TestInLineFileSystemHFileInLining() {
Review comment:
ditto
##########
File path: hudi-common/src/test/java/org/apache/hudi/common/util/collection/TestRocksDBDAO.java
##########
@@ -45,7 +45,7 @@
/**
* Tests RocksDB manager {@link RocksDBDAO}.
*/
-public class TestRocksDBManager {
+public class TestRocksDBDAO {
Review comment:
I would recommend renaming `RocksDBDAO ` to be `RocksDBManager`. WDYT? Generally, `xxxDAO` exists in the web project. cc @vinothchandar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] xushiyan commented on pull request #1644: [HUDI-811] Restructure test packages in hudi-common
Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #1644:
URL: https://github.com/apache/incubator-hudi/pull/1644#issuecomment-631820696
@yanghua The PR is ready for review. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] codecov-commenter commented on pull request #1644: [HUDI-811] Restructure test packages in hudi-common
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1644:
URL: https://github.com/apache/incubator-hudi/pull/1644#issuecomment-631673778
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=h1) Report
> Merging [#1644](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/6a0aa9a645d11ed7b50e18aa0563dafcd9d145f7&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1644 +/- ##
=========================================
Coverage 18.33% 18.33%
Complexity 855 855
=========================================
Files 344 344
Lines 15167 15167
Branches 1512 1512
=========================================
Hits 2781 2781
Misses 12033 12033
Partials 353 353
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=footer). Last update [6a0aa9a...af47cf0](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] xushiyan commented on pull request #1644: [HUDI-811] Restructure test packages in hudi-common
Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #1644:
URL: https://github.com/apache/incubator-hudi/pull/1644#issuecomment-631577878
Test classes under `functional` and `testutils`
- `TestHoodieLogFormat` and `TestHoodieLogFormatAppendFailure` involves minicluster hence go to `functional`
- Same for `org.apache.hudi.hadoop.functional.TestHoodieCombineHiveInputFormat`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] codecov-commenter edited a comment on pull request #1644: [HUDI-811] Restructure test packages in hudi-common
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1644:
URL: https://github.com/apache/incubator-hudi/pull/1644#issuecomment-631673778
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=h1) Report
> Merging [#1644](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/6a0aa9a645d11ed7b50e18aa0563dafcd9d145f7&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1644 +/- ##
============================================
- Coverage 18.33% 18.32% -0.02%
+ Complexity 855 854 -1
============================================
Files 344 344
Lines 15167 15167
Branches 1512 1512
============================================
- Hits 2781 2779 -2
- Misses 12033 12035 +2
Partials 353 353
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/hudi/common/fs/HoodieWrapperFileSystem.java](https://codecov.io/gh/apache/incubator-hudi/pull/1644/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0hvb2RpZVdyYXBwZXJGaWxlU3lzdGVtLmphdmE=) | `21.98% <0.00%> (-0.71%)` | `28.00% <0.00%> (-1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=footer). Last update [6a0aa9a...2915023](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] codecov-commenter edited a comment on pull request #1644: [HUDI-811] Restructure test packages in hudi-common
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1644:
URL: https://github.com/apache/incubator-hudi/pull/1644#issuecomment-631673778
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=h1) Report
> Merging [#1644](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/6a0aa9a645d11ed7b50e18aa0563dafcd9d145f7&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1644 +/- ##
=========================================
Coverage 18.33% 18.33%
Complexity 855 855
=========================================
Files 344 344
Lines 15167 15167
Branches 1512 1512
=========================================
Hits 2781 2781
Misses 12033 12033
Partials 353 353
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/hudi/common/table/log/HoodieLogFileReader.java](https://codecov.io/gh/apache/incubator-hudi/pull/1644/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGaWxlUmVhZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=footer). Last update [6a0aa9a...ed4ca32](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] yanghua commented on pull request #1644: [HUDI-811] Restructure test packages in hudi-common
Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #1644:
URL: https://github.com/apache/incubator-hudi/pull/1644#issuecomment-631836269
OK, will review later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] codecov-commenter edited a comment on pull request #1644: [HUDI-811] Restructure test packages in hudi-common
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1644:
URL: https://github.com/apache/incubator-hudi/pull/1644#issuecomment-631673778
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=h1) Report
> Merging [#1644](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/802d16c8c9793156ef7fef0c59088040800fe025&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1644 +/- ##
=========================================
Coverage 18.33% 18.33%
Complexity 855 855
=========================================
Files 344 344
Lines 15167 15167
Branches 1512 1512
=========================================
Hits 2781 2781
Misses 12033 12033
Partials 353 353
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/hudi/common/table/log/HoodieLogFileReader.java](https://codecov.io/gh/apache/incubator-hudi/pull/1644/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGaWxlUmVhZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=footer). Last update [802d16c...f2d05ee](https://codecov.io/gh/apache/incubator-hudi/pull/1644?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] xushiyan commented on a change in pull request #1644: [HUDI-811] Restructure test packages in hudi-common
Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #1644:
URL: https://github.com/apache/incubator-hudi/pull/1644#discussion_r428760599
##########
File path: hudi-common/src/test/java/org/apache/hudi/common/fs/inline/TestInLineFileSystemHFileInLining.java
##########
@@ -40,18 +42,18 @@
import java.util.Set;
import java.util.UUID;
-import static org.apache.hudi.common.fs.inline.FileSystemTestUtils.FILE_SCHEME;
-import static org.apache.hudi.common.fs.inline.FileSystemTestUtils.RANDOM;
-import static org.apache.hudi.common.fs.inline.FileSystemTestUtils.getPhantomFile;
-import static org.apache.hudi.common.fs.inline.FileSystemTestUtils.getRandomOuterInMemPath;
+import static org.apache.hudi.common.testutils.FileSystemTestUtils.FILE_SCHEME;
+import static org.apache.hudi.common.testutils.FileSystemTestUtils.RANDOM;
+import static org.apache.hudi.common.testutils.FileSystemTestUtils.getPhantomFile;
+import static org.apache.hudi.common.testutils.FileSystemTestUtils.getRandomOuterInMemPath;
import static org.junit.jupiter.api.Assertions.assertArrayEquals;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotEquals;
/**
* Tests {@link InLineFileSystem} to inline HFile.
*/
-public class TestHFileInLining {
+public class TestInLineFileSystemHFileInLining {
Review comment:
@yanghua `TestInLineFileSystem` already exists in the same package. This is testing `TestInLineFileSystem` for a group of cases for HFile inlining.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] xushiyan edited a comment on pull request #1644: [HUDI-811] Restructure test packages in hudi-common
Posted by GitBox <gi...@apache.org>.
xushiyan edited a comment on pull request #1644:
URL: https://github.com/apache/incubator-hudi/pull/1644#issuecomment-631577878
Test classes under `functional` and `testutils`
- `TestHoodieLogFormat` and `TestHoodieLogFormatAppendFailure` involves minicluster hence go to `functional`
- Tried to move `org.apache.hudi.common.util.TestDFSPropertiesConfiguration` to `functional` but ran into errors from `TestParquetUtils` which implies inter-class side-effects. The investigation is beyond the scope of this PR, hence leaving it there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org