You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cassandra.apache.org by "Sylvain Lebresne (JIRA)" <ji...@apache.org> on 2013/05/17 16:29:15 UTC

[jira] [Commented] (CASSANDRA-5577) Avoid unnecessary second pass on name-based queries

    [ https://issues.apache.org/jira/browse/CASSANDRA-5577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13660749#comment-13660749 ] 

Sylvain Lebresne commented on CASSANDRA-5577:
---------------------------------------------

The patch lgtm, though going a bit further I think we can always dispense ourselves of the collateOnDiskAtom call. Because returning gcable tombstones during read should never be a problem since we'll skip any tombstone before returning to the client.

Nit: might be worst adding as a comment than skipping collateOnDiskAtom is only ok because we have a NamesQueryFilter, so we don't inadvertently copy the idea when a slice filter is involved.

                
> Avoid unnecessary second pass on name-based queries
> ---------------------------------------------------
>
>                 Key: CASSANDRA-5577
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5577
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 2.0
>
>         Attachments: 5577.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira