You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/13 12:20:28 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #38239: [SPARK-40789][PYTHON][TESTS] Separate tests under pyspark.sql.tests
HyukjinKwon opened a new pull request, #38239:
URL: https://github.com/apache/spark/pull/38239
### What changes were proposed in this pull request?
This PR proposes to split the tests into the sub-packages:
**Before**
```
tests
├── __init__.py
├── test_arrow.py
├── test_arrow_map.py
├── test_catalog.py
├── test_column.py
├── test_conf.py
├── test_connect_basic.py
├── test_connect_column_expressions.py
├── test_connect_plan_only.py
├── test_connect_select_ops.py
├── test_context.py
├── test_dataframe.py
├── test_datasources.py
├── test_functions.py
├── test_group.py
├── test_pandas_cogrouped_map.py
├── test_pandas_grouped_map.py
├── test_pandas_grouped_map_with_state.py
├── test_pandas_map.py
├── test_pandas_udf.py
├── test_pandas_udf_grouped_agg.py
├── test_pandas_udf_scalar.py
├── test_pandas_udf_typehints.py
├── test_pandas_udf_typehints_with_future_annotations.py
├── test_pandas_udf_window.py
├── test_readwriter.py
├── test_serde.py
├── test_session.py
├── test_streaming.py
├── test_streaming_listener.py
├── test_types.py
├── test_udf.py
├── test_udf_profiler.py
├── test_utils.py
└── typing
├── ...
```
**After**
```
tests
├── __init__.py
├── connect
│ ├── __init__.py
│ ├── test_connect_basic.py
│ ├── test_connect_column_expressions.py
│ ├── test_connect_plan_only.py
│ └── test_connect_select_ops.py
├── pandas
│ ├── __init__.py
│ ├── test_pandas_cogrouped_map.py
│ ├── test_pandas_grouped_map.py
│ ├── test_pandas_grouped_map_with_state.py
│ ├── test_pandas_map.py
│ ├── test_pandas_udf.py
│ ├── test_pandas_udf_grouped_agg.py
│ ├── test_pandas_udf_scalar.py
│ ├── test_pandas_udf_typehints.py
│ ├── test_pandas_udf_typehints_with_future_annotations.py
│ └── test_pandas_udf_window.py
├── streaming
│ ├── __init__.py
│ ├── test_streaming.py
│ └── test_streaming_listener.py
├── test_arrow.py
├── test_arrow_map.py
├── test_catalog.py
├── test_column.py
├── test_conf.py
├── test_context.py
├── test_dataframe.py
├── test_datasources.py
├── test_functions.py
├── test_group.py
├── test_readwriter.py
├── test_serde.py
├── test_session.py
├── test_types.py
├── test_udf.py
├── test_udf_profiler.py
├── test_utils.py
└── typing
├── test_column.yml
├── test_dataframe.yml
├── test_functions.yml
├── test_readwriter.yml
├── test_session.yml
└── test_udf.yml
```
This way is consistent with `pyspark.pandas.tests`.
### Why are the changes needed?
To make it easier to maintain, track and add the tests.
### Does this PR introduce _any_ user-facing change?
No, dev-only.
### How was this patch tested?
CI in this PR should test it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38239: [SPARK-40789][PYTHON][TESTS] Separate tests under pyspark.sql.tests
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38239:
URL: https://github.com/apache/spark/pull/38239#issuecomment-1277523564
cc @zhengruifeng @ueshin @grundprinzip @xinrong-meng @itholic please take a look when you guys find some time to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38239: [SPARK-40789][PYTHON][TESTS] Separate tests under pyspark.sql.tests
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #38239:
URL: https://github.com/apache/spark/pull/38239#discussion_r995229146
##########
dev/sparktestsupport/modules.py:
##########
@@ -461,22 +461,22 @@ def __hash__(self):
"pyspark.sql.tests.test_datasources",
"pyspark.sql.tests.test_functions",
"pyspark.sql.tests.test_group",
- "pyspark.sql.tests.test_pandas_cogrouped_map",
- "pyspark.sql.tests.test_pandas_grouped_map",
- "pyspark.sql.tests.test_pandas_grouped_map_with_state",
- "pyspark.sql.tests.test_pandas_map",
- "pyspark.sql.tests.test_arrow_map",
- "pyspark.sql.tests.test_pandas_udf",
- "pyspark.sql.tests.test_pandas_udf_grouped_agg",
- "pyspark.sql.tests.test_pandas_udf_scalar",
- "pyspark.sql.tests.test_pandas_udf_typehints",
- "pyspark.sql.tests.test_pandas_udf_typehints_with_future_annotations",
- "pyspark.sql.tests.test_pandas_udf_window",
+ "pyspark.sql.tests.pandas.test_pandas_cogrouped_map",
+ "pyspark.sql.tests.pandas.test_pandas_grouped_map",
+ "pyspark.sql.tests.pandas.test_pandas_grouped_map_with_state",
+ "pyspark.sql.tests.pandas.test_pandas_map",
+ "pyspark.sql.tests.pandas.test_arrow_map",
Review Comment:
```suggestion
"pyspark.sql.tests.test_arrow_map",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #38239: [SPARK-40789][PYTHON][TESTS] Separate tests under pyspark.sql.tests
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #38239: [SPARK-40789][PYTHON][TESTS] Separate tests under pyspark.sql.tests
URL: https://github.com/apache/spark/pull/38239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38239: [SPARK-40789][PYTHON][TESTS] Separate tests under pyspark.sql.tests
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38239:
URL: https://github.com/apache/spark/pull/38239#issuecomment-1278379075
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org