You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Ashutosh Shahi (JIRA)" <ji...@apache.org> on 2005/07/27 11:11:19 UTC

[jira] Created: (AXIS2-101) staxSOAPModelBuilder missing comments processing

staxSOAPModelBuilder missing comments processing
------------------------------------------------

         Key: AXIS2-101
         URL: http://issues.apache.org/jira/browse/AXIS2-101
     Project: Apache Axis 2.0 (Axis2)
        Type: Bug
  Components: om  
    Versions: 0.9    
    Reporter: Ashutosh Shahi



As part of XML Infoset, there was some code added to next() method in staxOMBuilder to process comments etc.
But, we have staxSOAPModelBuilder also, where we do not have any such capability yet. Now comments can be part of soapMessage as well.
I have a test soap message : 
"<?xml version='1.0' encoding='UTF-8'?>" + 
                                    "<!-- Comment -->" +
                                    "<env:Envelope xmlns:env='http://schemas.xmlsoap.org/soap/envelope/'>" +
                                    "<env:Body><echo><arg0>Hello</arg0></echo></env:Body>" +
                                    "</env:Envelope>";

And doing something like:
stAXSOAPModelBuilder =
                        new StAXSOAPModelBuilder(
                                XMLInputFactory.newInstance()
                        .createXMLStreamReader(inputStream));
Where input stream has soap message with comments gives an OMException.

Now my question is: 
Both StaxSOAPModelBuilder and StaxOMBuilder extend the abstract class StaxBuilder which has next() as abstract method. Why not put the functionality in next() method of StaxBuilder itself? Or atleast we should process comments in StaxSOAPModelBuilder as well.

-Ashutosh



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (AXIS2-101) staxSOAPModelBuilder missing comments processing

Posted by "Srinath Perera (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/AXIS2-101?page=all ]

Srinath Perera updated AXIS2-101:
---------------------------------

    Description: 
As part of XML Infoset, there was some code added to next() method in staxOMBuilder to process comments etc.
But, we have staxSOAPModelBuilder also, where we do not have any such capability yet. Now comments can be part of soapMessage as well.
I have a test soap message : 
"<?xml version='1.0' encoding='UTF-8'?>" + 
                                    "<!-- Comment -->" +
                                    "<env:Envelope xmlns:env='http://schemas.xmlsoap.org/soap/envelope/'>" +
                                    "<env:Body><echo><arg0>Hello</arg0></echo></env:Body>" +
                                    "</env:Envelope>";

And doing something like:
stAXSOAPModelBuilder =
                        new StAXSOAPModelBuilder(
                                XMLInputFactory.newInstance()
                        .createXMLStreamReader(inputStream));
Where input stream has soap message with comments gives an OMException.

Now my question is: 
Both StaxSOAPModelBuilder and StaxOMBuilder extend the abstract class StaxBuilder which has next() as abstract method. Why not put the functionality in next() method of StaxBuilder itself? Or atleast we should process comments in StaxSOAPModelBuilder as well.

-Ashutosh



  was:

As part of XML Infoset, there was some code added to next() method in staxOMBuilder to process comments etc.
But, we have staxSOAPModelBuilder also, where we do not have any such capability yet. Now comments can be part of soapMessage as well.
I have a test soap message : 
"<?xml version='1.0' encoding='UTF-8'?>" + 
                                    "<!-- Comment -->" +
                                    "<env:Envelope xmlns:env='http://schemas.xmlsoap.org/soap/envelope/'>" +
                                    "<env:Body><echo><arg0>Hello</arg0></echo></env:Body>" +
                                    "</env:Envelope>";

And doing something like:
stAXSOAPModelBuilder =
                        new StAXSOAPModelBuilder(
                                XMLInputFactory.newInstance()
                        .createXMLStreamReader(inputStream));
Where input stream has soap message with comments gives an OMException.

Now my question is: 
Both StaxSOAPModelBuilder and StaxOMBuilder extend the abstract class StaxBuilder which has next() as abstract method. Why not put the functionality in next() method of StaxBuilder itself? Or atleast we should process comments in StaxSOAPModelBuilder as well.

-Ashutosh




post 0.95

> staxSOAPModelBuilder missing comments processing
> ------------------------------------------------
>
>          Key: AXIS2-101
>          URL: http://issues.apache.org/jira/browse/AXIS2-101
>      Project: Apache Axis 2.0 (Axis2)
>         Type: Bug
>   Components: om
>     Versions: 0.9
>     Reporter: Ashutosh Shahi
>     Assignee: Ashutosh Shahi

>
> As part of XML Infoset, there was some code added to next() method in staxOMBuilder to process comments etc.
> But, we have staxSOAPModelBuilder also, where we do not have any such capability yet. Now comments can be part of soapMessage as well.
> I have a test soap message : 
> "<?xml version='1.0' encoding='UTF-8'?>" + 
>                                     "<!-- Comment -->" +
>                                     "<env:Envelope xmlns:env='http://schemas.xmlsoap.org/soap/envelope/'>" +
>                                     "<env:Body><echo><arg0>Hello</arg0></echo></env:Body>" +
>                                     "</env:Envelope>";
> And doing something like:
> stAXSOAPModelBuilder =
>                         new StAXSOAPModelBuilder(
>                                 XMLInputFactory.newInstance()
>                         .createXMLStreamReader(inputStream));
> Where input stream has soap message with comments gives an OMException.
> Now my question is: 
> Both StaxSOAPModelBuilder and StaxOMBuilder extend the abstract class StaxBuilder which has next() as abstract method. Why not put the functionality in next() method of StaxBuilder itself? Or atleast we should process comments in StaxSOAPModelBuilder as well.
> -Ashutosh

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (AXIS2-101) staxSOAPModelBuilder missing comments processing

Posted by "Venkat Reddy (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/AXIS2-101?page=comments#action_12316879 ] 

Venkat Reddy commented on AXIS2-101:
------------------------------------

The test case for StAXSOAPModelBuilder might need updating to test the comment handling etc.

- venkat


> staxSOAPModelBuilder missing comments processing
> ------------------------------------------------
>
>          Key: AXIS2-101
>          URL: http://issues.apache.org/jira/browse/AXIS2-101
>      Project: Apache Axis 2.0 (Axis2)
>         Type: Bug
>   Components: om
>     Versions: 0.9
>     Reporter: Ashutosh Shahi

>
> As part of XML Infoset, there was some code added to next() method in staxOMBuilder to process comments etc.
> But, we have staxSOAPModelBuilder also, where we do not have any such capability yet. Now comments can be part of soapMessage as well.
> I have a test soap message : 
> "<?xml version='1.0' encoding='UTF-8'?>" + 
>                                     "<!-- Comment -->" +
>                                     "<env:Envelope xmlns:env='http://schemas.xmlsoap.org/soap/envelope/'>" +
>                                     "<env:Body><echo><arg0>Hello</arg0></echo></env:Body>" +
>                                     "</env:Envelope>";
> And doing something like:
> stAXSOAPModelBuilder =
>                         new StAXSOAPModelBuilder(
>                                 XMLInputFactory.newInstance()
>                         .createXMLStreamReader(inputStream));
> Where input stream has soap message with comments gives an OMException.
> Now my question is: 
> Both StaxSOAPModelBuilder and StaxOMBuilder extend the abstract class StaxBuilder which has next() as abstract method. Why not put the functionality in next() method of StaxBuilder itself? Or atleast we should process comments in StaxSOAPModelBuilder as well.
> -Ashutosh

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (AXIS2-101) staxSOAPModelBuilder missing comments processing

Posted by "Ashutosh Shahi (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/AXIS2-101?page=all ]
     
Ashutosh Shahi resolved AXIS2-101:
----------------------------------

    Fix Version: 0.9
     Resolution: Fixed

Made StAXSOAPModelBuilder to extend StAXOMBuilder. This enables to process comments as well.
Also a test case in saaj EnvelopeTest added to check comments in soap message.

> staxSOAPModelBuilder missing comments processing
> ------------------------------------------------
>
>          Key: AXIS2-101
>          URL: http://issues.apache.org/jira/browse/AXIS2-101
>      Project: Apache Axis 2.0 (Axis2)
>         Type: Bug
>   Components: om
>     Versions: 0.9
>     Reporter: Ashutosh Shahi
>     Assignee: Ashutosh Shahi
>     Priority: Minor
>      Fix For: 0.9

>
> As part of XML Infoset, there was some code added to next() method in staxOMBuilder to process comments etc.
> But, we have staxSOAPModelBuilder also, where we do not have any such capability yet. Now comments can be part of soapMessage as well.
> I have a test soap message : 
> "<?xml version='1.0' encoding='UTF-8'?>" + 
>                                     "<!-- Comment -->" +
>                                     "<env:Envelope xmlns:env='http://schemas.xmlsoap.org/soap/envelope/'>" +
>                                     "<env:Body><echo><arg0>Hello</arg0></echo></env:Body>" +
>                                     "</env:Envelope>";
> And doing something like:
> stAXSOAPModelBuilder =
>                         new StAXSOAPModelBuilder(
>                                 XMLInputFactory.newInstance()
>                         .createXMLStreamReader(inputStream));
> Where input stream has soap message with comments gives an OMException.
> Now my question is: 
> Both StaxSOAPModelBuilder and StaxOMBuilder extend the abstract class StaxBuilder which has next() as abstract method. Why not put the functionality in next() method of StaxBuilder itself? Or atleast we should process comments in StaxSOAPModelBuilder as well.
> -Ashutosh

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (AXIS2-101) staxSOAPModelBuilder missing comments processing

Posted by "Srinath Perera (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/AXIS2-101?page=all ]

Srinath Perera reassigned AXIS2-101:
------------------------------------

    Assign To: Ashutosh Shahi

> staxSOAPModelBuilder missing comments processing
> ------------------------------------------------
>
>          Key: AXIS2-101
>          URL: http://issues.apache.org/jira/browse/AXIS2-101
>      Project: Apache Axis 2.0 (Axis2)
>         Type: Bug
>   Components: om
>     Versions: 0.9
>     Reporter: Ashutosh Shahi
>     Assignee: Ashutosh Shahi

>
> As part of XML Infoset, there was some code added to next() method in staxOMBuilder to process comments etc.
> But, we have staxSOAPModelBuilder also, where we do not have any such capability yet. Now comments can be part of soapMessage as well.
> I have a test soap message : 
> "<?xml version='1.0' encoding='UTF-8'?>" + 
>                                     "<!-- Comment -->" +
>                                     "<env:Envelope xmlns:env='http://schemas.xmlsoap.org/soap/envelope/'>" +
>                                     "<env:Body><echo><arg0>Hello</arg0></echo></env:Body>" +
>                                     "</env:Envelope>";
> And doing something like:
> stAXSOAPModelBuilder =
>                         new StAXSOAPModelBuilder(
>                                 XMLInputFactory.newInstance()
>                         .createXMLStreamReader(inputStream));
> Where input stream has soap message with comments gives an OMException.
> Now my question is: 
> Both StaxSOAPModelBuilder and StaxOMBuilder extend the abstract class StaxBuilder which has next() as abstract method. Why not put the functionality in next() method of StaxBuilder itself? Or atleast we should process comments in StaxSOAPModelBuilder as well.
> -Ashutosh

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (AXIS2-101) staxSOAPModelBuilder missing comments processing

Posted by "Srinath Perera (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/AXIS2-101?page=all ]

Srinath Perera updated AXIS2-101:
---------------------------------

    Priority: Minor  (was: Major)

> staxSOAPModelBuilder missing comments processing
> ------------------------------------------------
>
>          Key: AXIS2-101
>          URL: http://issues.apache.org/jira/browse/AXIS2-101
>      Project: Apache Axis 2.0 (Axis2)
>         Type: Bug
>   Components: om
>     Versions: 0.9
>     Reporter: Ashutosh Shahi
>     Assignee: Ashutosh Shahi
>     Priority: Minor

>
> As part of XML Infoset, there was some code added to next() method in staxOMBuilder to process comments etc.
> But, we have staxSOAPModelBuilder also, where we do not have any such capability yet. Now comments can be part of soapMessage as well.
> I have a test soap message : 
> "<?xml version='1.0' encoding='UTF-8'?>" + 
>                                     "<!-- Comment -->" +
>                                     "<env:Envelope xmlns:env='http://schemas.xmlsoap.org/soap/envelope/'>" +
>                                     "<env:Body><echo><arg0>Hello</arg0></echo></env:Body>" +
>                                     "</env:Envelope>";
> And doing something like:
> stAXSOAPModelBuilder =
>                         new StAXSOAPModelBuilder(
>                                 XMLInputFactory.newInstance()
>                         .createXMLStreamReader(inputStream));
> Where input stream has soap message with comments gives an OMException.
> Now my question is: 
> Both StaxSOAPModelBuilder and StaxOMBuilder extend the abstract class StaxBuilder which has next() as abstract method. Why not put the functionality in next() method of StaxBuilder itself? Or atleast we should process comments in StaxSOAPModelBuilder as well.
> -Ashutosh

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira