You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/07/08 23:53:37 UTC
[GitHub] [incubator-pinot] siddharthteotia opened a new pull request #5668: Type
siddharthteotia opened a new pull request #5668:
URL: https://github.com/apache/incubator-pinot/pull/5668
Remove ForwardIndexType and InvertedIndexType. These enums are not used anywhere in the persistent structures and are
simply used in ColumnMetadata only in the constructor and don't serve any purpose and instead pollute the ColumnIndexCreationInfo code. Ideally, we should be having them in segment metadata on disk.
If/when we change the inverted index format to support something more than bitmap or a new version of bitmap based, we may want to add an enum that is also persisted in segment metadata.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia merged pull request #5668: Remove ForwardIndexType and InvertedIndexType.
Posted by GitBox <gi...@apache.org>.
siddharthteotia merged pull request #5668:
URL: https://github.com/apache/incubator-pinot/pull/5668
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia commented on pull request #5668: Remove ForwardIndexType and InvertedIndexType.
Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on pull request #5668:
URL: https://github.com/apache/incubator-pinot/pull/5668#issuecomment-656429936
> LGTM. Not sure should we keep the TextIndexType
It is already there part of persistent data so removing it is backward incompatible (although possible). Secondly, would like to keep it to plug multiple implementations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org