You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2015/12/02 23:02:19 UTC
Review Request 40883: Downgrade could not save cluster state to remove
configs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40883/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
Bugs: AMBARI-14164
https://issues.apache.org/jira/browse/AMBARI-14164
Repository: ambari
Description
-------
During EU, an error was encountered preventing the removal of configurations. The equals() method was forcing a lazy-load of data for an entity that didn't exist.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java f28cc02
Diff: https://reviews.apache.org/r/40883/diff/
Testing
-------
Manual. Automated pending.
Thanks,
Nate Cole
Re: Review Request 40883: Downgrade could not save cluster state to
remove configs
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40883/#review108728
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Dec. 2, 2015, 10:04 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40883/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2015, 10:04 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARI-14164
> https://issues.apache.org/jira/browse/AMBARI-14164
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During EU, an error was encountered preventing the removal of configurations. The equals() method was forcing a lazy-load of data for an entity that didn't exist.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java f28cc02
>
> Diff: https://reviews.apache.org/r/40883/diff/
>
>
> Testing
> -------
>
> No new tests required. Manual upgrade worked. Automated to confirm no breakage pending.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 40883: Downgrade could not save cluster state to
remove configs
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40883/#review108734
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java (line 203)
<https://reviews.apache.org/r/40883/#comment168199>
This is actually bad practice I think. Two non-equal objects can return the same hashcode. Safer to do the explicit variable comparisons.
- Jonathan Hurley
On Dec. 2, 2015, 5:04 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40883/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2015, 5:04 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARI-14164
> https://issues.apache.org/jira/browse/AMBARI-14164
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During EU, an error was encountered preventing the removal of configurations. The equals() method was forcing a lazy-load of data for an entity that didn't exist.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java f28cc02
>
> Diff: https://reviews.apache.org/r/40883/diff/
>
>
> Testing
> -------
>
> No new tests required. Manual upgrade worked. Automated to confirm no breakage pending.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 40883: Downgrade could not save cluster state to
remove configs
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40883/#review108757
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Dec. 3, 2015, 12:32 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40883/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2015, 12:32 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARI-14164
> https://issues.apache.org/jira/browse/AMBARI-14164
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During EU, an error was encountered preventing the removal of configurations. The equals() method was forcing a lazy-load of data for an entity that didn't exist.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java f28cc02
>
> Diff: https://reviews.apache.org/r/40883/diff/
>
>
> Testing
> -------
>
> No new tests required. Manual upgrade worked. Automated:
>
>
> Tests run: 3506, Failures: 0, Errors: 0, Skipped: 28
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 35:30.936s
> [INFO] Finished at: Wed Dec 02 18:35:03 EST 2015
> [INFO] Final Memory: 31M/711M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 40883: Downgrade could not save cluster state to
remove configs
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40883/
-----------------------------------------------------------
(Updated Dec. 2, 2015, 7:32 p.m.)
Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
Changes
-------
Updated test info
Bugs: AMBARI-14164
https://issues.apache.org/jira/browse/AMBARI-14164
Repository: ambari
Description
-------
During EU, an error was encountered preventing the removal of configurations. The equals() method was forcing a lazy-load of data for an entity that didn't exist.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java f28cc02
Diff: https://reviews.apache.org/r/40883/diff/
Testing (updated)
-------
No new tests required. Manual upgrade worked. Automated:
Tests run: 3506, Failures: 0, Errors: 0, Skipped: 28
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 35:30.936s
[INFO] Finished at: Wed Dec 02 18:35:03 EST 2015
[INFO] Final Memory: 31M/711M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 40883: Downgrade could not save cluster state to
remove configs
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40883/#review108743
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Dec. 2, 2015, 10:48 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40883/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2015, 10:48 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARI-14164
> https://issues.apache.org/jira/browse/AMBARI-14164
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During EU, an error was encountered preventing the removal of configurations. The equals() method was forcing a lazy-load of data for an entity that didn't exist.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java f28cc02
>
> Diff: https://reviews.apache.org/r/40883/diff/
>
>
> Testing
> -------
>
> No new tests required. Manual upgrade worked. Automated to confirm no breakage pending.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 40883: Downgrade could not save cluster state to
remove configs
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40883/#review108742
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Dec. 2, 2015, 5:48 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40883/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2015, 5:48 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARI-14164
> https://issues.apache.org/jira/browse/AMBARI-14164
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During EU, an error was encountered preventing the removal of configurations. The equals() method was forcing a lazy-load of data for an entity that didn't exist.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java f28cc02
>
> Diff: https://reviews.apache.org/r/40883/diff/
>
>
> Testing
> -------
>
> No new tests required. Manual upgrade worked. Automated to confirm no breakage pending.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 40883: Downgrade could not save cluster state to
remove configs
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40883/
-----------------------------------------------------------
(Updated Dec. 2, 2015, 5:48 p.m.)
Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
Changes
-------
Fix for wrong diff
Bugs: AMBARI-14164
https://issues.apache.org/jira/browse/AMBARI-14164
Repository: ambari
Description
-------
During EU, an error was encountered preventing the removal of configurations. The equals() method was forcing a lazy-load of data for an entity that didn't exist.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java f28cc02
Diff: https://reviews.apache.org/r/40883/diff/
Testing
-------
No new tests required. Manual upgrade worked. Automated to confirm no breakage pending.
Thanks,
Nate Cole
Re: Review Request 40883: Downgrade could not save cluster state to
remove configs
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40883/
-----------------------------------------------------------
(Updated Dec. 2, 2015, 5:44 p.m.)
Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
Changes
-------
Update for comments, even though the new code was effectively the same thing that the old code was doing in a more convenient way.
Bugs: AMBARI-14164
https://issues.apache.org/jira/browse/AMBARI-14164
Repository: ambari
Description
-------
During EU, an error was encountered preventing the removal of configurations. The equals() method was forcing a lazy-load of data for an entity that didn't exist.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java f28cc02
Diff: https://reviews.apache.org/r/40883/diff/
Testing
-------
No new tests required. Manual upgrade worked. Automated to confirm no breakage pending.
Thanks,
Nate Cole
Re: Review Request 40883: Downgrade could not save cluster state to
remove configs
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40883/
-----------------------------------------------------------
(Updated Dec. 2, 2015, 5:04 p.m.)
Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
Bugs: AMBARI-14164
https://issues.apache.org/jira/browse/AMBARI-14164
Repository: ambari
Description
-------
During EU, an error was encountered preventing the removal of configurations. The equals() method was forcing a lazy-load of data for an entity that didn't exist.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java f28cc02
Diff: https://reviews.apache.org/r/40883/diff/
Testing (updated)
-------
No new tests required. Manual upgrade worked. Automated to confirm no breakage pending.
Thanks,
Nate Cole