[GitHub] [iceberg] rdblue commented on a diff in pull request #5264: Cache PositionIndex

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5264:
URL: https://github.com/apache/iceberg/pull/5264#discussion_r920176166


##########
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##########
@@ -226,8 +226,10 @@ private CloseableIterable<T> applyPosDeletes(CloseableIterable<T> records) {
 
     // if there are fewer deletes than a reasonable number to keep in memory, use a set
     if (posDeletes.stream().mapToLong(DeleteFile::recordCount).sum() < setFilterThreshold) {
-      PositionDeleteIndex positionIndex = Deletes.toPositionIndex(filePath, deletes);
-      Predicate<T> isDeleted = record -> positionIndex.isDeleted(pos(record));
+      if (deleteRowPositions == null) {

Review Comment:
   I don't think this should run line 225 to open the deletes if they can be reused.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org