You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Olga Natkovich (JIRA)" <ji...@apache.org> on 2008/08/07 02:14:44 UTC

[jira] Created: (PIG-363) Describe does not produce correct schema for generate with UDF

Describe does not produce correct schema for generate with UDF
--------------------------------------------------------------

                 Key: PIG-363
                 URL: https://issues.apache.org/jira/browse/PIG-363
             Project: Pig
          Issue Type: Bug
    Affects Versions: types_branch
            Reporter: Olga Natkovich
            Priority: Critical
             Fix For: types_branch


B = foreach A generate string.CONCATSEP(' ', $0, 'foo');
describe B;
{chararray}

UDF has the following outputSchema function:

public Schema outputSchema(Schema input) {
                String name = "concatsep_";
                if (input.getAliases().size() > 0)
                        name += input.getAliases().iterator().next() + "_";
                return new Schema(new Schema.FieldSchema(name +  getNextSchemaId(), DataType.CHARARRAY));
        }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (PIG-363) Describe does not produce correct schema for generate with UDF

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich reassigned PIG-363:
----------------------------------

    Assignee: Pradeep Kamath

> Describe does not produce correct schema for generate with UDF
> --------------------------------------------------------------
>
>                 Key: PIG-363
>                 URL: https://issues.apache.org/jira/browse/PIG-363
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Olga Natkovich
>            Assignee: Pradeep Kamath
>            Priority: Critical
>             Fix For: types_branch
>
>
> B = foreach A generate string.CONCATSEP(' ', $0, 'foo');
> describe B;
> {chararray}
> UDF has the following outputSchema function:
> public Schema outputSchema(Schema input) {
>                 String name = "concatsep_";
>                 if (input.getAliases().size() > 0)
>                         name += input.getAliases().iterator().next() + "_";
>                 return new Schema(new Schema.FieldSchema(name +  getNextSchemaId(), DataType.CHARARRAY));
>         }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-363) Describe does not produce correct schema for generate with UDF

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-363:
-------------------------------

    Attachment: desc.patch

Attached patch to fix this

> Describe does not produce correct schema for generate with UDF
> --------------------------------------------------------------
>
>                 Key: PIG-363
>                 URL: https://issues.apache.org/jira/browse/PIG-363
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Olga Natkovich
>            Assignee: Pradeep Kamath
>            Priority: Critical
>             Fix For: types_branch
>
>         Attachments: desc.patch
>
>
> B = foreach A generate string.CONCATSEP(' ', $0, 'foo');
> describe B;
> {chararray}
> UDF has the following outputSchema function:
> public Schema outputSchema(Schema input) {
>                 String name = "concatsep_";
>                 if (input.getAliases().size() > 0)
>                         name += input.getAliases().iterator().next() + "_";
>                 return new Schema(new Schema.FieldSchema(name +  getNextSchemaId(), DataType.CHARARRAY));
>         }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-363) Describe does not produce correct schema for generate with UDF

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620680#action_12620680 ] 

Olga Natkovich commented on PIG-363:
------------------------------------

Alan says this is likely that generate code does not query the schema of UDF. He suggested we look at code in src/org/apache/pig/impl/logicalLayer/validators/TypeCheckingVisitor.java


> Describe does not produce correct schema for generate with UDF
> --------------------------------------------------------------
>
>                 Key: PIG-363
>                 URL: https://issues.apache.org/jira/browse/PIG-363
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Olga Natkovich
>            Priority: Critical
>             Fix For: types_branch
>
>
> B = foreach A generate string.CONCATSEP(' ', $0, 'foo');
> describe B;
> {chararray}
> UDF has the following outputSchema function:
> public Schema outputSchema(Schema input) {
>                 String name = "concatsep_";
>                 if (input.getAliases().size() > 0)
>                         name += input.getAliases().iterator().next() + "_";
>                 return new Schema(new Schema.FieldSchema(name +  getNextSchemaId(), DataType.CHARARRAY));
>         }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-363) Describe does not produce correct schema for generate with UDF

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-363:
-------------------------------

    Patch Info: [Patch Available]

> Describe does not produce correct schema for generate with UDF
> --------------------------------------------------------------
>
>                 Key: PIG-363
>                 URL: https://issues.apache.org/jira/browse/PIG-363
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Olga Natkovich
>            Assignee: Pradeep Kamath
>            Priority: Critical
>             Fix For: types_branch
>
>         Attachments: desc.patch
>
>
> B = foreach A generate string.CONCATSEP(' ', $0, 'foo');
> describe B;
> {chararray}
> UDF has the following outputSchema function:
> public Schema outputSchema(Schema input) {
>                 String name = "concatsep_";
>                 if (input.getAliases().size() > 0)
>                         name += input.getAliases().iterator().next() + "_";
>                 return new Schema(new Schema.FieldSchema(name +  getNextSchemaId(), DataType.CHARARRAY));
>         }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (PIG-363) Describe does not produce correct schema for generate with UDF

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich resolved PIG-363.
--------------------------------

    Resolution: Fixed

patch verified and committed. thanks pradeep

> Describe does not produce correct schema for generate with UDF
> --------------------------------------------------------------
>
>                 Key: PIG-363
>                 URL: https://issues.apache.org/jira/browse/PIG-363
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Olga Natkovich
>            Assignee: Pradeep Kamath
>            Priority: Critical
>             Fix For: types_branch
>
>         Attachments: desc.patch
>
>
> B = foreach A generate string.CONCATSEP(' ', $0, 'foo');
> describe B;
> {chararray}
> UDF has the following outputSchema function:
> public Schema outputSchema(Schema input) {
>                 String name = "concatsep_";
>                 if (input.getAliases().size() > 0)
>                         name += input.getAliases().iterator().next() + "_";
>                 return new Schema(new Schema.FieldSchema(name +  getNextSchemaId(), DataType.CHARARRAY));
>         }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.