You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Nixon Rodrigues <ni...@freestoneinfotech.com> on 2018/09/17 13:29:50 UTC
Review Request 68735: ATLAS-2860- Remove Atlas client dependency with
atlas-application properties
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68735/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
Bugs: ATLAS-2860
https://issues.apache.org/jira/browse/ATLAS-2860
Repository: atlas
Description
-------
This patch includes changes in Atlas client to remove the dependency with atlas application properties, so that it can be reused from non Atlas application env.
Diffs
-----
addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookIT.java c0d0318d8
client/client-v1/src/test/java/org/apache/atlas/AtlasClientTest.java ce4e014f7
client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java d6f767e52
client/common/src/main/java/org/apache/atlas/security/SecureClientUtils.java d5392b2e4
intg/src/main/java/org/apache/atlas/ApplicationProperties.java a35bdfee7
Diff: https://reviews.apache.org/r/68735/diff/1/
Testing
-------
Testing Atlas with QuickStart and Atlas_admin.py script which use Atlas client.
Thanks,
Nixon Rodrigues
Re: Review Request 68735: ATLAS-2860- Remove Atlas client dependency
with atlas-application properties
Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68735/#review208689
-----------------------------------------------------------
client/client-v1/src/test/java/org/apache/atlas/AtlasClientTest.java
Line 464 (original), 464 (patched)
<https://reviews.apache.org/r/68735/#comment292818>
This can be left unchanged.
client/client-v1/src/test/java/org/apache/atlas/AtlasClientTest.java
Line 469 (original), 469 (patched)
<https://reviews.apache.org/r/68735/#comment292819>
This can be left unchanged.
client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java
Line 261 (original), 261 (patched)
<https://reviews.apache.org/r/68735/#comment292816>
This can be left unchanged.
client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java
Line 321 (original), 321 (patched)
<https://reviews.apache.org/r/68735/#comment292817>
This can be left unchanged.
- Ashutosh Mestry
On Sept. 17, 2018, 6:37 p.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68735/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2018, 6:37 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2860
> https://issues.apache.org/jira/browse/ATLAS-2860
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch includes changes in Atlas client to remove the dependency with atlas application properties, so that it can be reused from non Atlas application env.
>
>
> Diffs
> -----
>
> addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookIT.java c0d0318d8
> client/client-v1/src/test/java/org/apache/atlas/AtlasClientTest.java ce4e014f7
> client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java d6f767e52
> client/common/src/main/java/org/apache/atlas/security/SecureClientUtils.java d5392b2e4
> intg/src/main/java/org/apache/atlas/ApplicationProperties.java a35bdfee7
>
>
> Diff: https://reviews.apache.org/r/68735/diff/2/
>
>
> Testing
> -------
>
> Testing Atlas with QuickStart and Atlas_admin.py script which use Atlas client.
>
>
> Thanks,
>
> Nixon Rodrigues
>
>
Re: Review Request 68735: ATLAS-2860- Remove Atlas client dependency
with atlas-application properties
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68735/#review208690
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Sept. 17, 2018, 6:37 p.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68735/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2018, 6:37 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2860
> https://issues.apache.org/jira/browse/ATLAS-2860
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch includes changes in Atlas client to remove the dependency with atlas application properties, so that it can be reused from non Atlas application env.
>
>
> Diffs
> -----
>
> addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookIT.java c0d0318d8
> client/client-v1/src/test/java/org/apache/atlas/AtlasClientTest.java ce4e014f7
> client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java d6f767e52
> client/common/src/main/java/org/apache/atlas/security/SecureClientUtils.java d5392b2e4
> intg/src/main/java/org/apache/atlas/ApplicationProperties.java a35bdfee7
>
>
> Diff: https://reviews.apache.org/r/68735/diff/2/
>
>
> Testing
> -------
>
> Testing Atlas with QuickStart and Atlas_admin.py script which use Atlas client.
>
>
> Thanks,
>
> Nixon Rodrigues
>
>
Re: Review Request 68735: ATLAS-2860- Remove Atlas client dependency
with atlas-application properties
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68735/#review208688
-----------------------------------------------------------
client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java
Line 261 (original), 261 (patched)
<https://reviews.apache.org/r/68735/#comment292812>
Why the access was changed from 'protected' to 'public'? This method is not called from outside this class hierarchy.
client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java
Line 321 (original), 321 (patched)
<https://reviews.apache.org/r/68735/#comment292813>
Why the access was changed from 'protected' to 'public'? This method is not called from outside this class hierarchy.
client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java
Line 434 (original), 434 (patched)
<https://reviews.apache.org/r/68735/#comment292814>
Why the access was changed from default to 'public'? This method is not called from outside this package.
client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java
Lines 440 (patched)
<https://reviews.apache.org/r/68735/#comment292815>
Why this refactor, to create setBasicAuth() method? This method is not called from anywhere else.
- Madhan Neethiraj
On Sept. 17, 2018, 6:37 p.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68735/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2018, 6:37 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2860
> https://issues.apache.org/jira/browse/ATLAS-2860
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch includes changes in Atlas client to remove the dependency with atlas application properties, so that it can be reused from non Atlas application env.
>
>
> Diffs
> -----
>
> addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookIT.java c0d0318d8
> client/client-v1/src/test/java/org/apache/atlas/AtlasClientTest.java ce4e014f7
> client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java d6f767e52
> client/common/src/main/java/org/apache/atlas/security/SecureClientUtils.java d5392b2e4
> intg/src/main/java/org/apache/atlas/ApplicationProperties.java a35bdfee7
>
>
> Diff: https://reviews.apache.org/r/68735/diff/2/
>
>
> Testing
> -------
>
> Testing Atlas with QuickStart and Atlas_admin.py script which use Atlas client.
>
>
> Thanks,
>
> Nixon Rodrigues
>
>
Re: Review Request 68735: ATLAS-2860- Remove Atlas client dependency
with atlas-application properties
Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68735/
-----------------------------------------------------------
(Updated Sept. 17, 2018, 6:37 p.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
Changes
-------
This patch consist fix to address review comment from Madhan N.
Bugs: ATLAS-2860
https://issues.apache.org/jira/browse/ATLAS-2860
Repository: atlas
Description
-------
This patch includes changes in Atlas client to remove the dependency with atlas application properties, so that it can be reused from non Atlas application env.
Diffs (updated)
-----
addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookIT.java c0d0318d8
client/client-v1/src/test/java/org/apache/atlas/AtlasClientTest.java ce4e014f7
client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java d6f767e52
client/common/src/main/java/org/apache/atlas/security/SecureClientUtils.java d5392b2e4
intg/src/main/java/org/apache/atlas/ApplicationProperties.java a35bdfee7
Diff: https://reviews.apache.org/r/68735/diff/2/
Changes: https://reviews.apache.org/r/68735/diff/1-2/
Testing
-------
Testing Atlas with QuickStart and Atlas_admin.py script which use Atlas client.
Thanks,
Nixon Rodrigues
Re: Review Request 68735: ATLAS-2860- Remove Atlas client dependency
with atlas-application properties
Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
> On Sept. 17, 2018, 4:29 p.m., Madhan Neethiraj wrote:
> > client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java
> > Line 430 (original), 430 (patched)
> > <https://reviews.apache.org/r/68735/diff/1/?file=2089902#file2089902line430>
> >
> > Why make initializeState() methods public? These methods don't seem to be called from outside this class.
Make sense
- Nixon
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68735/#review208682
-----------------------------------------------------------
On Sept. 17, 2018, 6:37 p.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68735/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2018, 6:37 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2860
> https://issues.apache.org/jira/browse/ATLAS-2860
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch includes changes in Atlas client to remove the dependency with atlas application properties, so that it can be reused from non Atlas application env.
>
>
> Diffs
> -----
>
> addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookIT.java c0d0318d8
> client/client-v1/src/test/java/org/apache/atlas/AtlasClientTest.java ce4e014f7
> client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java d6f767e52
> client/common/src/main/java/org/apache/atlas/security/SecureClientUtils.java d5392b2e4
> intg/src/main/java/org/apache/atlas/ApplicationProperties.java a35bdfee7
>
>
> Diff: https://reviews.apache.org/r/68735/diff/2/
>
>
> Testing
> -------
>
> Testing Atlas with QuickStart and Atlas_admin.py script which use Atlas client.
>
>
> Thanks,
>
> Nixon Rodrigues
>
>
Re: Review Request 68735: ATLAS-2860- Remove Atlas client dependency
with atlas-application properties
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68735/#review208682
-----------------------------------------------------------
client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java
Line 430 (original), 430 (patched)
<https://reviews.apache.org/r/68735/#comment292810>
Why make initializeState() methods public? These methods don't seem to be called from outside this class.
- Madhan Neethiraj
On Sept. 17, 2018, 1:29 p.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68735/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2018, 1:29 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2860
> https://issues.apache.org/jira/browse/ATLAS-2860
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch includes changes in Atlas client to remove the dependency with atlas application properties, so that it can be reused from non Atlas application env.
>
>
> Diffs
> -----
>
> addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookIT.java c0d0318d8
> client/client-v1/src/test/java/org/apache/atlas/AtlasClientTest.java ce4e014f7
> client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java d6f767e52
> client/common/src/main/java/org/apache/atlas/security/SecureClientUtils.java d5392b2e4
> intg/src/main/java/org/apache/atlas/ApplicationProperties.java a35bdfee7
>
>
> Diff: https://reviews.apache.org/r/68735/diff/1/
>
>
> Testing
> -------
>
> Testing Atlas with QuickStart and Atlas_admin.py script which use Atlas client.
>
>
> Thanks,
>
> Nixon Rodrigues
>
>