You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Tim Harper (JIRA)" <ji...@apache.org> on 2018/07/19 19:00:00 UTC

[jira] [Commented] (MESOS-9095) Consider including public protobuf definitions in generated jar

    [ https://issues.apache.org/jira/browse/MESOS-9095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549695#comment-16549695 ] 

Tim Harper commented on MESOS-9095:
-----------------------------------

Thank you for filing this, Benjamin. This will be really helpful.

Currently, Marathon does what you say (we copy the Proto sources into our own code base, and check in the generated code).

> Consider including public protobuf definitions in generated jar
> ---------------------------------------------------------------
>
>                 Key: MESOS-9095
>                 URL: https://issues.apache.org/jira/browse/MESOS-9095
>             Project: Mesos
>          Issue Type: Improvement
>          Components: java api
>            Reporter: Benjamin Bannier
>            Priority: Major
>
> We currently do not package public proto sources alongside other resources in the jar. This is inconsistent with what we do e.g., for packages or {{install rules}} on the C++ side.
> Frameworks seem to work around this by forking required proto sources into their own source code, or (slightly less worse) fetching them from potentially poorly versioned internet resources. Both approaches can lead to complicate dependencies between used jar and proto sources.
> We should include them in the jar we publish, e.g., by declaring them as {{resources}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)