[mynewt-core] branch master updated: dialog/da1469x: Fix array pointer re-referencing bug

[be...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

benmccrea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git


The following commit(s) were added to refs/heads/master by this push:
     new 23b6039  dialog/da1469x: Fix array pointer re-referencing bug
     new 60ed56a  Merge pull request #2226 from JuulLabs/fix/da1469x_pd_apply_trimv
23b6039 is described below

commit 23b60393fd81d750fac7cf3498b96fdbe2ede994
Author: Ben McCrea <bm...@juul.com>
AuthorDate: Tue Mar 3 19:09:41 2020 -0800

    dialog/da1469x: Fix array pointer re-referencing bug
    
    Register trim values from OTP were not being applied. Upon inspection it
    was found that da1469x_pd_apply_trimv() was improperly assigning 'reg' to the
    address of 'trimv_words[idx *2]'.
    
    With this fix the OTP register values appear to be properly applied.
---
 hw/mcu/dialog/da1469x/src/da1469x_pd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/mcu/dialog/da1469x/src/da1469x_pd.c b/hw/mcu/dialog/da1469x/src/da1469x_pd.c
index b138b22..08ca79f 100644
--- a/hw/mcu/dialog/da1469x/src/da1469x_pd.c
+++ b/hw/mcu/dialog/da1469x/src/da1469x_pd.c
@@ -96,7 +96,7 @@ da1469x_pd_apply_trimv(uint8_t pd)
     }
 
     for (idx = 0; idx < pdd->trimv_count; idx++) {
-        reg = &pdd->trimv_words[idx * 2];
+        reg = (uint32_t *) pdd->trimv_words[idx * 2];
         val = pdd->trimv_words[idx * 2 + 1];
         *reg = val;
     }