You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/01/16 16:10:55 UTC
[GitHub] codecov-io commented on issue #6690: Improve Unicode support for
MSSQL
codecov-io commented on issue #6690: Improve Unicode support for MSSQL
URL: https://github.com/apache/incubator-superset/pull/6690#issuecomment-454837248
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6690?src=pr&el=h1) Report
> Merging [#6690](https://codecov.io/gh/apache/incubator-superset/pull/6690?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4667f0c2889ee3d7941859cbb25df6acf4ef36e8?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `85.71%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/6690?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6690 +/- ##
==========================================
- Coverage 56.22% 56.19% -0.03%
==========================================
Files 519 520 +1
Lines 23098 23188 +90
Branches 2759 2765 +6
==========================================
+ Hits 12986 13031 +45
- Misses 9702 9747 +45
Partials 410 410
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/6690?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/6690/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.62% <ø> (-0.05%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/6690/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `77.96% <100%> (+0.04%)` | :arrow_up: |
| [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/6690/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `55.04% <83.33%> (+0.02%)` | :arrow_up: |
| [.../assets/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6690/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TcWxFZGl0b3JMZWZ0QmFyLmpzeA==) | `36.53% <0%> (-52.58%)` | :arrow_down: |
| [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6690/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvRGF0YXNvdXJjZUNvbnRyb2wuanN4) | `54.16% <0%> (-2.5%)` | :arrow_down: |
| [...uperset/assets/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6690/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXRhc291cmNlL0RhdGFzb3VyY2VFZGl0b3IuanN4) | `61.58% <0%> (-0.74%)` | :arrow_down: |
| [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6690/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | `100% <0%> (ø)` | :arrow_up: |
| [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/6690/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | `0% <0%> (ø)` | :arrow_up: |
| [superset/data/bart\_lines.py](https://codecov.io/gh/apache/incubator-superset/pull/6690/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YS9iYXJ0X2xpbmVzLnB5) | `38.46% <0%> (ø)` | :arrow_up: |
| ... and [498 more](https://codecov.io/gh/apache/incubator-superset/pull/6690/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6690?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6690?src=pr&el=footer). Last update [4667f0c...ad856aa](https://codecov.io/gh/apache/incubator-superset/pull/6690?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org