You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "David Knupp (Code Review)" <ge...@cloudera.org> on 2019/04/08 20:58:02 UTC

[Impala-ASF-CR] IMPALA-8346: Specify hadoop user explicitly during data load 

David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12958


Change subject: IMPALA-8346: Specify hadoop user explicitly during data load
......................................................................

IMPALA-8346: Specify hadoop user explicitly during data load

Directory ownership and permissions need to be set differently,
depending upon whether the test data is being setup for running
tests on a local mini-cluster vs. a remote deployed cluster.

Tested by installing data successfully in both contexts.

Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
---
M testdata/bin/create-tpcds-testcase-files.sh
1 file changed, 8 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/12958/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
Gerrit-Change-Number: 12958
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>

[Impala-ASF-CR] IMPALA-8346: Specify hadoop user explicitly during data load

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 )

Change subject: IMPALA-8346: Specify hadoop user explicitly during data load
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2682/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
Gerrit-Change-Number: 12958
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Apr 2019 21:30:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 )

Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

This makes sense to me. If there are not other comments, I will +2.

http://gerrit.cloudera.org:8080/#/c/12958/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12958/4//COMMIT_MSG@14
PS4, Line 14: It skips the creation of TPCDS
            : testcase files when the cluster under test is a remote deployed one.
Maybe add one line saying that the testcase files are used during the frontend tests, and the frontend tests don't work against remote deployed clusters.



-- 
To view, visit http://gerrit.cloudera.org:8080/12958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
Gerrit-Change-Number: 12958
Gerrit-PatchSet: 4
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Apr 2019 20:34:29 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally

Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 )

Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12958/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12958/4//COMMIT_MSG@14
PS4, Line 14: It skips the creation of TPCDS
            : testcase files that are used by the FE java tests. These tests don't
> Maybe add one line saying that the testcase files are used during the front
Thanks Joe. Done.



-- 
To view, visit http://gerrit.cloudera.org:8080/12958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
Gerrit-Change-Number: 12958
Gerrit-PatchSet: 5
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Apr 2019 22:05:23 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless tetsing locally

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 )

Change subject: IMPALA-8346: Don't create FE testcase files unless tetsing locally
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2742/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
Gerrit-Change-Number: 12958
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Apr 2019 23:24:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 )

Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally
......................................................................


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4018/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/12958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
Gerrit-Change-Number: 12958
Gerrit-PatchSet: 6
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Apr 2019 22:50:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless tetsing locally

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 )

Change subject: IMPALA-8346: Don't create FE testcase files unless tetsing locally
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2741/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
Gerrit-Change-Number: 12958
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Apr 2019 23:18:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8346: Specify hadoop user explicitly during data load

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 )

Change subject: IMPALA-8346: Specify hadoop user explicitly during data load
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12958/1/testdata/bin/create-tpcds-testcase-files.sh
File testdata/bin/create-tpcds-testcase-files.sh:

http://gerrit.cloudera.org:8080/#/c/12958/1/testdata/bin/create-tpcds-testcase-files.sh@24
PS1, Line 24: # Directory ownership and permissions need to be set differently,
I'm not super convinced this is the right solution. How about fixing the remote data load to run consistently as a single user (impala)? Am I missing something?



-- 
To view, visit http://gerrit.cloudera.org:8080/12958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
Gerrit-Change-Number: 12958
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Apr 2019 22:04:53 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally

Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
Hello Bharath Vissapragada, Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12958

to look at the new patch set (#5).

Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally
......................................................................

IMPALA-8346: Don't create FE testcase files unless testing locally

The same test data setup scripts get called when loading data for
mini-cluster testing and testing against a real deployed cluster.
Unfortunately, we're seeing more and more that not all set up steps
apply equally in both situations.

This patch avoids one such example. It skips the creation of TPCDS
testcase files that are used by the FE java tests. These tests don't
run against deployed clusters.

Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
---
M testdata/bin/create-load-data.sh
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/12958/5
-- 
To view, visit http://gerrit.cloudera.org:8080/12958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
Gerrit-Change-Number: 12958
Gerrit-PatchSet: 5
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally

Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12958 )

Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally
......................................................................

IMPALA-8346: Don't create FE testcase files unless testing locally

The same test data setup scripts get called when loading data for
mini-cluster testing and testing against a real deployed cluster.
Unfortunately, we're seeing more and more that not all set up steps
apply equally in both situations.

This patch avoids one such example. It skips the creation of TPCDS
testcase files when the cluster under test is a remote deployed one.

Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
---
M testdata/bin/create-load-data.sh
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/12958/4
-- 
To view, visit http://gerrit.cloudera.org:8080/12958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
Gerrit-Change-Number: 12958
Gerrit-PatchSet: 4
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 )

Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2759/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
Gerrit-Change-Number: 12958
Gerrit-PatchSet: 4
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Apr 2019 20:29:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 )

Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally
......................................................................


Patch Set 6: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/12958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
Gerrit-Change-Number: 12958
Gerrit-PatchSet: 6
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Sat, 13 Apr 2019 03:48:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12958 )

Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally
......................................................................

IMPALA-8346: Don't create FE testcase files unless testing locally

The same test data setup scripts get called when loading data for
mini-cluster testing and testing against a real deployed cluster.
Unfortunately, we're seeing more and more that not all set up steps
apply equally in both situations.

This patch avoids one such example. It skips the creation of TPCDS
testcase files that are used by the FE java tests. These tests don't
run against deployed clusters.

Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
Reviewed-on: http://gerrit.cloudera.org:8080/12958
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/bin/create-load-data.sh
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/12958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
Gerrit-Change-Number: 12958
Gerrit-PatchSet: 7
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 )

Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
Gerrit-Change-Number: 12958
Gerrit-PatchSet: 5
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Apr 2019 22:14:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless tetsing locally

Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
Hello Bharath Vissapragada, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12958

to look at the new patch set (#3).

Change subject: IMPALA-8346: Don't create FE testcase files unless tetsing locally
......................................................................

IMPALA-8346: Don't create FE testcase files unless tetsing locally

The same test data setup scripts get called when loading data for
mini-cluster testing and testing against a real deployed cluster.
Unfortunately, we're seeing more and more that not all set up steps
apply equally in both situations.

This patch avoids one such example. It skips the creation of TPCDS
testcase files when the cluster under test is a remote deployed one.

Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
---
M testdata/bin/create-load-data.sh
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/12958/3
-- 
To view, visit http://gerrit.cloudera.org:8080/12958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
Gerrit-Change-Number: 12958
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless tetsing locally

Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
Hello Bharath Vissapragada, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12958

to look at the new patch set (#2).

Change subject: IMPALA-8346: Don't create FE testcase files unless tetsing locally
......................................................................

IMPALA-8346: Don't create FE testcase files unless tetsing locally

The same test data setup scripts get called when loading data for
mini-cluster testing and testing against a real deployed cluster.
Unfortunately, we're seeing more and more that not all set up steps
apply equally in both situations.

This patch avoids one such example. It skips the creation of TPCDS
testcase files when the cluster under test is a remote deployed one.

Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
---
M testdata/bin/create-load-data.sh
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/12958/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
Gerrit-Change-Number: 12958
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 )

Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
Gerrit-Change-Number: 12958
Gerrit-PatchSet: 6
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Apr 2019 22:50:05 +0000
Gerrit-HasComments: No