[GitHub] [cloudstack] weizhouapache commented on a change in pull request #6164: Mount disabled storage pool on host reboot

[GitBox <gi...@apache.org>]

weizhouapache commented on a change in pull request #6164:
URL: https://github.com/apache/cloudstack/pull/6164#discussion_r836702454



##########
File path: server/src/main/java/com/cloud/storage/listener/StoragePoolMonitor.java
##########
@@ -108,10 +108,12 @@ public void processConnect(Host host, StartupCommand cmd, boolean forRebalance)
                 List<StoragePoolVO> zoneStoragePoolsByAnyHypervisor = _poolDao.findZoneWideStoragePoolsByHypervisor(host.getDataCenterId(), HypervisorType.Any);
                 pools.addAll(zoneStoragePoolsByAnyHypervisor);
 
+                // get the disabled pools list if global setting is true.
+                if (StorageManager.MountDisabledStoragePool.value()) {
+                    pools.addAll(_poolDao.findDisabledPoolsByScope(host.getDataCenterId(), null, null, ScopeType.ZONE));

Review comment:
       @ravening 
   how about cluster wide storage pools ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org