You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2014/11/14 20:37:34 UTC

[jira] [Commented] (LUCENE-6004) Highlighting AnalyzingInfixSuggester skips non-highlighted key

    [ https://issues.apache.org/jira/browse/LUCENE-6004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14212712#comment-14212712 ] 

Michael McCandless commented on LUCENE-6004:
--------------------------------------------

Thanks Christian and jane, I think this makes sense ... I'll commit shortly.

> Highlighting AnalyzingInfixSuggester skips non-highlighted key
> --------------------------------------------------------------
>
>                 Key: LUCENE-6004
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6004
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/other
>    Affects Versions: 4.10
>            Reporter: Christian Reuschling
>            Priority: Trivial
>              Labels: easyfix
>         Attachments: LUCENE-6004.patch
>
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> when setting 'doHighlight' to true at AnalyzingInfixSuggester.lookup(..), both the key and the highlightKey inside the returned lookupresult are set to the highlighted string. See at AnalyzingInfixSuggester.createResults, line 530:
> if (doHighlight) {
>         Object highlightKey = highlight(text, matchedTokens, prefixToken);
>         result = new LookupResult(highlightKey.toString(), highlightKey, score, payload, contexts);
>       } else {
>         result = new LookupResult(text, score, payload, contexts);
>       }
> As I understand, the key should'nt be highlighted in any case, only the highlightKey.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org