You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Evelina Dumitrescu <ev...@gmail.com> on 2014/10/31 21:29:47 UTC
Review Request 27446: libprocess: Renamed the Node class in Endpoint
and
replaced the ip and port pairs from UPID class and process namespace with
this concept.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27446/
-----------------------------------------------------------
Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
Bugs: MESOS-2019
https://issues.apache.org/jira/browse/MESOS-2019
Repository: mesos-git
Description
-------
The Node class abstracts the endpoint notion: it defines the association of the ip and port for a connection. A node defines more the host(which can have multiple active endpoints).
At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
I want to propose to rename this class in Endpoint and also extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
Diffs
-----
3rdparty/libprocess/include/Makefile.am 542ae1c39283087da6fef69be29c811ac35f00f4
3rdparty/libprocess/include/process/endpoint.hpp PRE-CREATION
3rdparty/libprocess/include/process/node.hpp 7a96894456683be60595a8f96f85df37947ff5b6
3rdparty/libprocess/include/process/pid.hpp 23453229c2a868a62b143416de33cf630268a64e
3rdparty/libprocess/include/process/process.hpp 81a1f7a3fece78bb7df1e86850572922c8704ea4
3rdparty/libprocess/src/http.cpp 4ef00d11de4ff4e7eb4e44aac204147799f85ac2
3rdparty/libprocess/src/pid.cpp 20ff25c0959c247687955535f02e0397653af52a
3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668
3rdparty/libprocess/src/tests/benchmarks.cpp 3177a8ecac6adf8b52c3160587dc3a4fe2707d26
3rdparty/libprocess/src/tests/http_tests.cpp a1c3685c88d268c7ecdc2dad22608198dc0b295d
3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75
3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
Diff: https://reviews.apache.org/r/27446/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 27446: libprocess: Replaced the ip and port pairs
from UPID class and process namespace with Node class
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On Nov. 6, 2014, 5:44 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/src/http.cpp, line 90
> > <https://reviews.apache.org/r/27446/diff/3/?file=751387#file751387line90>
> >
> > actually, a utility method on Node to return the string host might be useful. Or a Try<string> host, actually.
I think we can just add stringify(node) since the Node class overloads the << operator.
> On Nov. 6, 2014, 5:44 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/src/http.cpp, line 84
> > <https://reviews.apache.org/r/27446/diff/3/?file=751387#file751387line84>
> >
> > worth adding an accessor to Node to return the in_addr*?
I want to replace the uint32_t type with IPAddress for the ip field and all the inet_ntop/inet_pton calls will be handled in the IPAddress struct. For example, we can replace this call with stringify method for IPAddress and overload the << operator:
inline
std::ostream &
operator<< (std::ostream & stream, const IPAddress & ipaddr)
{
if (ipaddr.family == AF_INET)
{
char str[INET_ADDRSTRLEN];
struct in_addr addr;
inet_ntop (AF_INET, &addr, str, INET_ADDRSTRLEN);
stream << str;
}
else
{
char str[INET6_ADDRSTRLEN];
struct in6_addr addr;
inet_ntop (AF_INET6, &addr, str, INET6_ADDRSTRLEN);
stream << str;
}
return stream;
}
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27446/#review60189
-----------------------------------------------------------
On Nov. 6, 2014, 3:07 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27446/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 3:07 a.m.)
>
>
> Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
>
>
> Bugs: MESOS-2019
> https://issues.apache.org/jira/browse/MESOS-2019
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
> I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/node.hpp 7a96894456683be60595a8f96f85df37947ff5b6
> 3rdparty/libprocess/include/process/pid.hpp 23453229c2a868a62b143416de33cf630268a64e
> 3rdparty/libprocess/include/process/process.hpp 81a1f7a3fece78bb7df1e86850572922c8704ea4
> 3rdparty/libprocess/src/http.cpp 4ef00d11de4ff4e7eb4e44aac204147799f85ac2
> 3rdparty/libprocess/src/pid.cpp 20ff25c0959c247687955535f02e0397653af52a
> 3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668
> 3rdparty/libprocess/src/tests/benchmarks.cpp 3177a8ecac6adf8b52c3160587dc3a4fe2707d26
> 3rdparty/libprocess/src/tests/http_tests.cpp a1c3685c88d268c7ecdc2dad22608198dc0b295d
> 3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75
> 3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
>
> Diff: https://reviews.apache.org/r/27446/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 27446: libprocess: Replaced the ip and port pairs
from UPID class and process namespace with Node class
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On Nov. 6, 2014, 5:44 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/include/process/pid.hpp, line 59
> > <https://reviews.apache.org/r/27446/diff/3/?file=751385#file751385line59>
> >
> > this can be simplified by adding an operator < to Node.
I didn't noticed that. Actually there is a < operator defined for the Node class.
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27446/#review60189
-----------------------------------------------------------
On Nov. 6, 2014, 3:07 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27446/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 3:07 a.m.)
>
>
> Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
>
>
> Bugs: MESOS-2019
> https://issues.apache.org/jira/browse/MESOS-2019
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
> I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/node.hpp 7a96894456683be60595a8f96f85df37947ff5b6
> 3rdparty/libprocess/include/process/pid.hpp 23453229c2a868a62b143416de33cf630268a64e
> 3rdparty/libprocess/include/process/process.hpp 81a1f7a3fece78bb7df1e86850572922c8704ea4
> 3rdparty/libprocess/src/http.cpp 4ef00d11de4ff4e7eb4e44aac204147799f85ac2
> 3rdparty/libprocess/src/pid.cpp 20ff25c0959c247687955535f02e0397653af52a
> 3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668
> 3rdparty/libprocess/src/tests/benchmarks.cpp 3177a8ecac6adf8b52c3160587dc3a4fe2707d26
> 3rdparty/libprocess/src/tests/http_tests.cpp a1c3685c88d268c7ecdc2dad22608198dc0b295d
> 3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75
> 3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
>
> Diff: https://reviews.apache.org/r/27446/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 27446: libprocess: Replaced the ip and port pairs
from UPID class and process namespace with Node class
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27446/#review60189
-----------------------------------------------------------
3rdparty/libprocess/include/process/node.hpp
<https://reviews.apache.org/r/27446/#comment101529>
this is actually a dangerous constructor as it is not marked explicit but can be called with a single argument. Ie, we might get an implicit cast by mistake.
Please instead add a second constructor:
Node() : ip(0), port(0) {}
Node(uint32_t _ip, uint16_t _port)
: ip(_ip), port(_port) {}
3rdparty/libprocess/include/process/node.hpp
<https://reviews.apache.org/r/27446/#comment101526>
we don't need this check - it makes things more complex for a minor optimization.
3rdparty/libprocess/include/process/pid.hpp
<https://reviews.apache.org/r/27446/#comment101530>
unnecessary - the default constructor for node takes care of the 0s.
3rdparty/libprocess/include/process/pid.hpp
<https://reviews.apache.org/r/27446/#comment101534>
this can be simplified by adding an operator < to Node.
3rdparty/libprocess/src/http.cpp
<https://reviews.apache.org/r/27446/#comment101537>
worth adding an accessor to Node to return the in_addr*?
3rdparty/libprocess/src/http.cpp
<https://reviews.apache.org/r/27446/#comment101539>
actually, a utility method on Node to return the string host might be useful. Or a Try<string> host, actually.
3rdparty/libprocess/src/pid.cpp
<https://reviews.apache.org/r/27446/#comment101541>
stream << pid.id << "@" << pid.node.host();
for example :)
3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/27446/#comment101545>
is this the same as
if (node != __node__ && persists.count(node) == 0) {
?
3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/27446/#comment101546>
define a != operator on node and define in terms of the == operator
bool operator != (const Node& that) const {
return !(*this == that);
}
- Dominic Hamon
On Nov. 5, 2014, 7:07 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27446/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2014, 7:07 p.m.)
>
>
> Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
>
>
> Bugs: MESOS-2019
> https://issues.apache.org/jira/browse/MESOS-2019
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
> I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/node.hpp 7a96894456683be60595a8f96f85df37947ff5b6
> 3rdparty/libprocess/include/process/pid.hpp 23453229c2a868a62b143416de33cf630268a64e
> 3rdparty/libprocess/include/process/process.hpp 81a1f7a3fece78bb7df1e86850572922c8704ea4
> 3rdparty/libprocess/src/http.cpp 4ef00d11de4ff4e7eb4e44aac204147799f85ac2
> 3rdparty/libprocess/src/pid.cpp 20ff25c0959c247687955535f02e0397653af52a
> 3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668
> 3rdparty/libprocess/src/tests/benchmarks.cpp 3177a8ecac6adf8b52c3160587dc3a4fe2707d26
> 3rdparty/libprocess/src/tests/http_tests.cpp a1c3685c88d268c7ecdc2dad22608198dc0b295d
> 3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75
> 3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
>
> Diff: https://reviews.apache.org/r/27446/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 27446: libprocess: Replaced the ip and port pairs
from UPID class and process namespace with Node class.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On Nov. 7, 2014, 5:12 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/include/process/node.hpp, line 51
> > <https://reviews.apache.org/r/27446/diff/5/?file=754538#file754538line51>
> >
> > this should be on the previous line and spaced differently - did you run the check style script? support/mesos-style.py
> >
> > if you install the git precommit hook from support/ it will run on commit, which is really helpful.
When I have commited the code, the precommit hook didn't noticed me in this case.
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27446/#review60341
-----------------------------------------------------------
On Nov. 7, 2014, 5:34 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27446/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 5:34 p.m.)
>
>
> Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
>
>
> Bugs: MESOS-2019
> https://issues.apache.org/jira/browse/MESOS-2019
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
> I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/node.hpp 7a96894456683be60595a8f96f85df37947ff5b6
> 3rdparty/libprocess/include/process/pid.hpp 23453229c2a868a62b143416de33cf630268a64e
> 3rdparty/libprocess/include/process/process.hpp 81a1f7a3fece78bb7df1e86850572922c8704ea4
> 3rdparty/libprocess/src/http.cpp 4ef00d11de4ff4e7eb4e44aac204147799f85ac2
> 3rdparty/libprocess/src/pid.cpp 20ff25c0959c247687955535f02e0397653af52a
> 3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668
> 3rdparty/libprocess/src/tests/benchmarks.cpp 3177a8ecac6adf8b52c3160587dc3a4fe2707d26
> 3rdparty/libprocess/src/tests/http_tests.cpp a1c3685c88d268c7ecdc2dad22608198dc0b295d
> 3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75
> 3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
>
> Diff: https://reviews.apache.org/r/27446/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 27446: libprocess: Replaced the ip and port pairs
from UPID class and process namespace with Node class.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27446/#review60341
-----------------------------------------------------------
Ship it!
so much cleaner!
fix up the style nits below and i'll wait for someone else to review before committing.
3rdparty/libprocess/include/process/node.hpp
<https://reviews.apache.org/r/27446/#comment101709>
is there an extra space before 'port'?
3rdparty/libprocess/include/process/node.hpp
<https://reviews.apache.org/r/27446/#comment101708>
you don't need the () around 'that'
3rdparty/libprocess/include/process/node.hpp
<https://reviews.apache.org/r/27446/#comment101711>
this should be on the previous line and spaced differently - did you run the check style script? support/mesos-style.py
if you install the git precommit hook from support/ it will run on commit, which is really helpful.
3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/27446/#comment101713>
space before the <<
- Dominic Hamon
On Nov. 7, 2014, 7:49 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27446/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 7:49 a.m.)
>
>
> Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
>
>
> Bugs: MESOS-2019
> https://issues.apache.org/jira/browse/MESOS-2019
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
> I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/node.hpp 7a96894456683be60595a8f96f85df37947ff5b6
> 3rdparty/libprocess/include/process/pid.hpp 23453229c2a868a62b143416de33cf630268a64e
> 3rdparty/libprocess/include/process/process.hpp 81a1f7a3fece78bb7df1e86850572922c8704ea4
> 3rdparty/libprocess/src/http.cpp 4ef00d11de4ff4e7eb4e44aac204147799f85ac2
> 3rdparty/libprocess/src/pid.cpp 20ff25c0959c247687955535f02e0397653af52a
> 3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668
> 3rdparty/libprocess/src/tests/benchmarks.cpp 3177a8ecac6adf8b52c3160587dc3a4fe2707d26
> 3rdparty/libprocess/src/tests/http_tests.cpp a1c3685c88d268c7ecdc2dad22608198dc0b295d
> 3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75
> 3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
>
> Diff: https://reviews.apache.org/r/27446/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 27446: libprocess: Replaced the ip and port pairs
from UPID class and process namespace with Node class.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On Nov. 11, 2014, 1:59 a.m., Michael Park wrote:
> > 3rdparty/libprocess/include/process/node.hpp, line 42
> > <https://reviews.apache.org/r/27446/diff/6/?file=754587#file754587line42>
> >
> > Does this compile...? It should be `!(this->operator == (that));` for it to be valid. Preferably we simply do: `!(*this == that);`
Corrected also in pid.hpp
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27446/#review60720
-----------------------------------------------------------
On Nov. 7, 2014, 5:34 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27446/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 5:34 p.m.)
>
>
> Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
>
>
> Bugs: MESOS-2019
> https://issues.apache.org/jira/browse/MESOS-2019
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
> I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/node.hpp 7a96894456683be60595a8f96f85df37947ff5b6
> 3rdparty/libprocess/include/process/pid.hpp 23453229c2a868a62b143416de33cf630268a64e
> 3rdparty/libprocess/include/process/process.hpp 81a1f7a3fece78bb7df1e86850572922c8704ea4
> 3rdparty/libprocess/src/http.cpp 4ef00d11de4ff4e7eb4e44aac204147799f85ac2
> 3rdparty/libprocess/src/pid.cpp 20ff25c0959c247687955535f02e0397653af52a
> 3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668
> 3rdparty/libprocess/src/tests/benchmarks.cpp 3177a8ecac6adf8b52c3160587dc3a4fe2707d26
> 3rdparty/libprocess/src/tests/http_tests.cpp a1c3685c88d268c7ecdc2dad22608198dc0b295d
> 3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75
> 3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
>
> Diff: https://reviews.apache.org/r/27446/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 27446: libprocess: Replaced the ip and port pairs
from UPID class and process namespace with Node class.
Posted by Michael Park <mc...@gmail.com>.
> On Nov. 11, 2014, 1:59 a.m., Michael Park wrote:
> >
>
> Michael Park wrote:
> Looks good, fairly straigth forward transformation :)
s/straigth/straight/
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27446/#review60720
-----------------------------------------------------------
On Nov. 7, 2014, 5:34 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27446/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 5:34 p.m.)
>
>
> Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
>
>
> Bugs: MESOS-2019
> https://issues.apache.org/jira/browse/MESOS-2019
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
> I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/node.hpp 7a96894456683be60595a8f96f85df37947ff5b6
> 3rdparty/libprocess/include/process/pid.hpp 23453229c2a868a62b143416de33cf630268a64e
> 3rdparty/libprocess/include/process/process.hpp 81a1f7a3fece78bb7df1e86850572922c8704ea4
> 3rdparty/libprocess/src/http.cpp 4ef00d11de4ff4e7eb4e44aac204147799f85ac2
> 3rdparty/libprocess/src/pid.cpp 20ff25c0959c247687955535f02e0397653af52a
> 3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668
> 3rdparty/libprocess/src/tests/benchmarks.cpp 3177a8ecac6adf8b52c3160587dc3a4fe2707d26
> 3rdparty/libprocess/src/tests/http_tests.cpp a1c3685c88d268c7ecdc2dad22608198dc0b295d
> 3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75
> 3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
>
> Diff: https://reviews.apache.org/r/27446/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 27446: libprocess: Replaced the ip and port pairs
from UPID class and process namespace with Node class.
Posted by Michael Park <mc...@gmail.com>.
> On Nov. 11, 2014, 1:59 a.m., Michael Park wrote:
> >
Looks good, fairly straigth forward transformation :)
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27446/#review60720
-----------------------------------------------------------
On Nov. 7, 2014, 5:34 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27446/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 5:34 p.m.)
>
>
> Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
>
>
> Bugs: MESOS-2019
> https://issues.apache.org/jira/browse/MESOS-2019
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
> I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/node.hpp 7a96894456683be60595a8f96f85df37947ff5b6
> 3rdparty/libprocess/include/process/pid.hpp 23453229c2a868a62b143416de33cf630268a64e
> 3rdparty/libprocess/include/process/process.hpp 81a1f7a3fece78bb7df1e86850572922c8704ea4
> 3rdparty/libprocess/src/http.cpp 4ef00d11de4ff4e7eb4e44aac204147799f85ac2
> 3rdparty/libprocess/src/pid.cpp 20ff25c0959c247687955535f02e0397653af52a
> 3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668
> 3rdparty/libprocess/src/tests/benchmarks.cpp 3177a8ecac6adf8b52c3160587dc3a4fe2707d26
> 3rdparty/libprocess/src/tests/http_tests.cpp a1c3685c88d268c7ecdc2dad22608198dc0b295d
> 3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75
> 3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
>
> Diff: https://reviews.apache.org/r/27446/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 27446: libprocess: Replaced the ip and port pairs
from UPID class and process namespace with Node class.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27446/#review60720
-----------------------------------------------------------
3rdparty/libprocess/include/process/node.hpp
<https://reviews.apache.org/r/27446/#comment102100>
style nit: we order headers alphabetically, grouped in the following order: C, C++, external, internal.
In this case,
```cpp
#include <arpa/inet.h>
#include <unistd.h>
#include <sstream>
#include <glog/logging.h>
```
3rdparty/libprocess/include/process/node.hpp
<https://reviews.apache.org/r/27446/#comment102113>
I know you didn't touch this part, but this I imagine wasn't being used at all. Could you get rid of it?
3rdparty/libprocess/include/process/node.hpp
<https://reviews.apache.org/r/27446/#comment102106>
Does this compile...? It should be `!(this->operator == (that));` for it to be valid. Preferably we simply do: `!(*this == that);`
3rdparty/libprocess/include/process/pid.hpp
<https://reviews.apache.org/r/27446/#comment102114>
Unreachable
3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/27446/#comment102101>
Let's just replace the 3 references to `node` to `to.node` rather than copying here.
- Michael Park
On Nov. 7, 2014, 5:34 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27446/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 5:34 p.m.)
>
>
> Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
>
>
> Bugs: MESOS-2019
> https://issues.apache.org/jira/browse/MESOS-2019
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
> I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/node.hpp 7a96894456683be60595a8f96f85df37947ff5b6
> 3rdparty/libprocess/include/process/pid.hpp 23453229c2a868a62b143416de33cf630268a64e
> 3rdparty/libprocess/include/process/process.hpp 81a1f7a3fece78bb7df1e86850572922c8704ea4
> 3rdparty/libprocess/src/http.cpp 4ef00d11de4ff4e7eb4e44aac204147799f85ac2
> 3rdparty/libprocess/src/pid.cpp 20ff25c0959c247687955535f02e0397653af52a
> 3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668
> 3rdparty/libprocess/src/tests/benchmarks.cpp 3177a8ecac6adf8b52c3160587dc3a4fe2707d26
> 3rdparty/libprocess/src/tests/http_tests.cpp a1c3685c88d268c7ecdc2dad22608198dc0b295d
> 3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75
> 3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
>
> Diff: https://reviews.apache.org/r/27446/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 27446: libprocess: Replaced the ip and port pairs
from UPID class and process namespace with Node class.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27446/#review60827
-----------------------------------------------------------
3rdparty/libprocess/include/process/node.hpp
<https://reviews.apache.org/r/27446/#comment102234>
nit: we keep the & with the types:
inline std::ostream& operator << (std::ostream& stream, const Node& node)
{
...
}
3rdparty/libprocess/include/process/pid.hpp
<https://reviews.apache.org/r/27446/#comment102235>
nit: add a newline before <process/> include.
- Dominic Hamon
On Nov. 11, 2014, 4:54 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27446/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2014, 4:54 a.m.)
>
>
> Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
>
>
> Bugs: MESOS-2019
> https://issues.apache.org/jira/browse/MESOS-2019
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
> I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/node.hpp 7a96894456683be60595a8f96f85df37947ff5b6
> 3rdparty/libprocess/include/process/pid.hpp 23453229c2a868a62b143416de33cf630268a64e
> 3rdparty/libprocess/include/process/process.hpp 81a1f7a3fece78bb7df1e86850572922c8704ea4
> 3rdparty/libprocess/src/http.cpp 4ef00d11de4ff4e7eb4e44aac204147799f85ac2
> 3rdparty/libprocess/src/pid.cpp 20ff25c0959c247687955535f02e0397653af52a
> 3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668
> 3rdparty/libprocess/src/tests/benchmarks.cpp 3177a8ecac6adf8b52c3160587dc3a4fe2707d26
> 3rdparty/libprocess/src/tests/http_tests.cpp a1c3685c88d268c7ecdc2dad22608198dc0b295d
> 3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75
> 3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
>
> Diff: https://reviews.apache.org/r/27446/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 27446: libprocess: Replaced the ip and port pairs
from UPID class and process namespace with Node class.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27446/
-----------------------------------------------------------
(Updated Nov. 12, 2014, 12:28 a.m.)
Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
Changes
-------
Fixed coding style.
Bugs: MESOS-2019
https://issues.apache.org/jira/browse/MESOS-2019
Repository: mesos-git
Description
-------
At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
Diffs (updated)
-----
3rdparty/libprocess/include/process/node.hpp 7a96894456683be60595a8f96f85df37947ff5b6
3rdparty/libprocess/include/process/pid.hpp 23453229c2a868a62b143416de33cf630268a64e
3rdparty/libprocess/include/process/process.hpp 81a1f7a3fece78bb7df1e86850572922c8704ea4
3rdparty/libprocess/src/http.cpp 4ef00d11de4ff4e7eb4e44aac204147799f85ac2
3rdparty/libprocess/src/pid.cpp 20ff25c0959c247687955535f02e0397653af52a
3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668
3rdparty/libprocess/src/tests/benchmarks.cpp 3177a8ecac6adf8b52c3160587dc3a4fe2707d26
3rdparty/libprocess/src/tests/http_tests.cpp a1c3685c88d268c7ecdc2dad22608198dc0b295d
3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75
3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
Diff: https://reviews.apache.org/r/27446/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 27446: libprocess: Replaced the ip and port pairs
from UPID class and process namespace with Node class.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27446/
-----------------------------------------------------------
(Updated Nov. 11, 2014, 12:54 p.m.)
Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
Bugs: MESOS-2019
https://issues.apache.org/jira/browse/MESOS-2019
Repository: mesos-git
Description
-------
At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
Diffs (updated)
-----
3rdparty/libprocess/include/process/node.hpp 7a96894456683be60595a8f96f85df37947ff5b6
3rdparty/libprocess/include/process/pid.hpp 23453229c2a868a62b143416de33cf630268a64e
3rdparty/libprocess/include/process/process.hpp 81a1f7a3fece78bb7df1e86850572922c8704ea4
3rdparty/libprocess/src/http.cpp 4ef00d11de4ff4e7eb4e44aac204147799f85ac2
3rdparty/libprocess/src/pid.cpp 20ff25c0959c247687955535f02e0397653af52a
3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668
3rdparty/libprocess/src/tests/benchmarks.cpp 3177a8ecac6adf8b52c3160587dc3a4fe2707d26
3rdparty/libprocess/src/tests/http_tests.cpp a1c3685c88d268c7ecdc2dad22608198dc0b295d
3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75
3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
Diff: https://reviews.apache.org/r/27446/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 27446: libprocess: Replaced the ip and port pairs
from UPID class and process namespace with Node class.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27446/
-----------------------------------------------------------
(Updated Nov. 7, 2014, 5:34 p.m.)
Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
Changes
-------
Fixed coding style issues.
Bugs: MESOS-2019
https://issues.apache.org/jira/browse/MESOS-2019
Repository: mesos-git
Description
-------
At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
Diffs (updated)
-----
3rdparty/libprocess/include/process/node.hpp 7a96894456683be60595a8f96f85df37947ff5b6
3rdparty/libprocess/include/process/pid.hpp 23453229c2a868a62b143416de33cf630268a64e
3rdparty/libprocess/include/process/process.hpp 81a1f7a3fece78bb7df1e86850572922c8704ea4
3rdparty/libprocess/src/http.cpp 4ef00d11de4ff4e7eb4e44aac204147799f85ac2
3rdparty/libprocess/src/pid.cpp 20ff25c0959c247687955535f02e0397653af52a
3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668
3rdparty/libprocess/src/tests/benchmarks.cpp 3177a8ecac6adf8b52c3160587dc3a4fe2707d26
3rdparty/libprocess/src/tests/http_tests.cpp a1c3685c88d268c7ecdc2dad22608198dc0b295d
3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75
3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
Diff: https://reviews.apache.org/r/27446/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 27446: libprocess: Replaced the ip and port pairs
from UPID class and process namespace with Node class.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27446/
-----------------------------------------------------------
(Updated Nov. 7, 2014, 3:49 p.m.)
Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
Changes
-------
I forgot to remove this != &that check
Bugs: MESOS-2019
https://issues.apache.org/jira/browse/MESOS-2019
Repository: mesos-git
Description
-------
At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
Diffs (updated)
-----
3rdparty/libprocess/include/process/node.hpp 7a96894456683be60595a8f96f85df37947ff5b6
3rdparty/libprocess/include/process/pid.hpp 23453229c2a868a62b143416de33cf630268a64e
3rdparty/libprocess/include/process/process.hpp 81a1f7a3fece78bb7df1e86850572922c8704ea4
3rdparty/libprocess/src/http.cpp 4ef00d11de4ff4e7eb4e44aac204147799f85ac2
3rdparty/libprocess/src/pid.cpp 20ff25c0959c247687955535f02e0397653af52a
3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668
3rdparty/libprocess/src/tests/benchmarks.cpp 3177a8ecac6adf8b52c3160587dc3a4fe2707d26
3rdparty/libprocess/src/tests/http_tests.cpp a1c3685c88d268c7ecdc2dad22608198dc0b295d
3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75
3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
Diff: https://reviews.apache.org/r/27446/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 27446: libprocess: Replaced the ip and port pairs
from UPID class and process namespace with Node class.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27446/
-----------------------------------------------------------
(Updated Nov. 7, 2014, 3:23 a.m.)
Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
Summary (updated)
-----------------
libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class.
Bugs: MESOS-2019
https://issues.apache.org/jira/browse/MESOS-2019
Repository: mesos-git
Description
-------
At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
Diffs (updated)
-----
3rdparty/libprocess/include/process/node.hpp 7a96894456683be60595a8f96f85df37947ff5b6
3rdparty/libprocess/include/process/pid.hpp 23453229c2a868a62b143416de33cf630268a64e
3rdparty/libprocess/include/process/process.hpp 81a1f7a3fece78bb7df1e86850572922c8704ea4
3rdparty/libprocess/src/http.cpp 4ef00d11de4ff4e7eb4e44aac204147799f85ac2
3rdparty/libprocess/src/pid.cpp 20ff25c0959c247687955535f02e0397653af52a
3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668
3rdparty/libprocess/src/tests/benchmarks.cpp 3177a8ecac6adf8b52c3160587dc3a4fe2707d26
3rdparty/libprocess/src/tests/http_tests.cpp a1c3685c88d268c7ecdc2dad22608198dc0b295d
3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75
3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
Diff: https://reviews.apache.org/r/27446/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 27446: libprocess: Replaced the ip and port pairs
from UPID class and process namespace with Node class
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27446/
-----------------------------------------------------------
(Updated Nov. 6, 2014, 3:07 a.m.)
Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
Changes
-------
Changed commit message.
Summary (updated)
-----------------
libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class
Bugs: MESOS-2019
https://issues.apache.org/jira/browse/MESOS-2019
Repository: mesos-git
Description
-------
At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
Diffs (updated)
-----
3rdparty/libprocess/include/process/node.hpp 7a96894456683be60595a8f96f85df37947ff5b6
3rdparty/libprocess/include/process/pid.hpp 23453229c2a868a62b143416de33cf630268a64e
3rdparty/libprocess/include/process/process.hpp 81a1f7a3fece78bb7df1e86850572922c8704ea4
3rdparty/libprocess/src/http.cpp 4ef00d11de4ff4e7eb4e44aac204147799f85ac2
3rdparty/libprocess/src/pid.cpp 20ff25c0959c247687955535f02e0397653af52a
3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668
3rdparty/libprocess/src/tests/benchmarks.cpp 3177a8ecac6adf8b52c3160587dc3a4fe2707d26
3rdparty/libprocess/src/tests/http_tests.cpp a1c3685c88d268c7ecdc2dad22608198dc0b295d
3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75
3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
Diff: https://reviews.apache.org/r/27446/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 27446: libprocess: Replaced the ip and port pairs
from UPID class and process namespace with Node class.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27446/
-----------------------------------------------------------
(Updated Nov. 6, 2014, 2:51 a.m.)
Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
Summary (updated)
-----------------
libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class.
Bugs: MESOS-2019
https://issues.apache.org/jira/browse/MESOS-2019
Repository: mesos-git
Description
-------
At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
Diffs
-----
3rdparty/libprocess/include/process/node.hpp 7a96894456683be60595a8f96f85df37947ff5b6
3rdparty/libprocess/include/process/pid.hpp 23453229c2a868a62b143416de33cf630268a64e
3rdparty/libprocess/include/process/process.hpp 81a1f7a3fece78bb7df1e86850572922c8704ea4
3rdparty/libprocess/src/http.cpp 4ef00d11de4ff4e7eb4e44aac204147799f85ac2
3rdparty/libprocess/src/pid.cpp 20ff25c0959c247687955535f02e0397653af52a
3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668
3rdparty/libprocess/src/tests/benchmarks.cpp 3177a8ecac6adf8b52c3160587dc3a4fe2707d26
3rdparty/libprocess/src/tests/http_tests.cpp a1c3685c88d268c7ecdc2dad22608198dc0b295d
3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75
3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
Diff: https://reviews.apache.org/r/27446/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 27446: libprocess: Renamed the Node class in
Endpoint and
replaced the ip and port pairs from UPID class and process namespace with
this concept
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27446/
-----------------------------------------------------------
(Updated Nov. 6, 2014, 1:23 a.m.)
Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
Changes
-------
Switched back from Endpoint to Node.
Summary (updated)
-----------------
libprocess: Renamed the Node class in Endpoint and replaced the ip and port pairs from UPID class and process namespace with this concept
Bugs: MESOS-2019
https://issues.apache.org/jira/browse/MESOS-2019
Repository: mesos-git
Description (updated)
-------
At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
Diffs (updated)
-----
3rdparty/libprocess/include/process/node.hpp 7a96894456683be60595a8f96f85df37947ff5b6
3rdparty/libprocess/include/process/pid.hpp 23453229c2a868a62b143416de33cf630268a64e
3rdparty/libprocess/include/process/process.hpp 81a1f7a3fece78bb7df1e86850572922c8704ea4
3rdparty/libprocess/src/http.cpp 4ef00d11de4ff4e7eb4e44aac204147799f85ac2
3rdparty/libprocess/src/pid.cpp 20ff25c0959c247687955535f02e0397653af52a
3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668
3rdparty/libprocess/src/tests/benchmarks.cpp 3177a8ecac6adf8b52c3160587dc3a4fe2707d26
3rdparty/libprocess/src/tests/http_tests.cpp a1c3685c88d268c7ecdc2dad22608198dc0b295d
3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75
3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
Diff: https://reviews.apache.org/r/27446/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu