You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Zack Shoylev <no...@github.com> on 2015/11/18 15:56:33 UTC
[jclouds] Fixes tenantId when using the keystone admin extension
(#880)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/880
-- Commit Summary --
* Fixes tenantId when using the keystone admin extension
-- File Changes --
M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/options/CreateUserOptions.java (6)
M apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/extensions/UserAdminApiMockTest.java (5)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/880.patch
https://github.com/jclouds/jclouds/pull/880.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/880
Re: [jclouds] Fixes tenantId when using the keystone admin extension
(#880)
Posted by Andrew Phillips <no...@github.com>.
> @@ -97,7 +97,7 @@ private ServerRequest(String name, String password) {
> if (password != null)
> user.password = password;
> if (tenant != null)
> - user.tenant = tenant;
> + user.tenantId = tenant;
Would it make sense to also rename the other variable to `tenantId`, or should we leave that as it is?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/880/files#r45214464
Re: [jclouds] Fixes tenantId when using the keystone admin extension
(#880)
Posted by Andrew Phillips <no...@github.com>.
@zack-shoylev: you beat me to it ;-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/880#issuecomment-157751720
Re: [jclouds] Fixes tenantId when using the keystone admin extension
(#880)
Posted by Zack Shoylev <no...@github.com>.
Closed #880.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/880#event-472671083
Re: [jclouds] Fixes tenantId when using the keystone admin extension
(#880)
Posted by Zack Shoylev <no...@github.com>.
Also should be backported.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/880#issuecomment-157740457
Re: [jclouds] Fixes tenantId when using the keystone admin extension
(#880)
Posted by Zack Shoylev <no...@github.com>.
> @@ -97,7 +97,7 @@ private ServerRequest(String name, String password) {
> if (password != null)
> user.password = password;
> if (tenant != null)
> - user.tenant = tenant;
> + user.tenantId = tenant;
I would rather not change the other one, as then it would be consistent to also change the getters/setters - and break backwards compatibility.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/880/files#r45216200
Re: [jclouds] Fixes tenantId when using the keystone admin extension
(#880)
Posted by Zack Shoylev <no...@github.com>.
merged and backported
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/880#issuecomment-159094136