You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "yangzhang75 (via GitHub)" <gi...@apache.org> on 2026/09/17 20:37:35 UTC
[PR] feat(workflow): mark the pinned version in the revision history [texera]
yangzhang75 opened a new pull request, #8577:
URL: https://github.com/apache/texera/pull/8577
### What changes were proposed in this PR?
Which version is the public one should be answerable, and the answer should be a row the author
can already see — the version panel is where they go to look at, and restore, an earlier version.
- **A pin leaves an anchor in the revision history.** Its delta is the identity patch, so replaying
that row returns what was published however many edits pile up later. An existing version row
cannot stand in: one replays to the content as it was *before* the change it records, so it
names the wrong thing by exactly one save. Pinning again with nothing changed reuses the anchor
rather than adding a twin, and `workflow.published_version_id` names it.
- **The anchor is a marker, not an edit.** It is always shown, so the author can find and restore
what the public has, but it must not start the panel's aggregation window — the save it was
pinned from is seconds older and would otherwise be folded into it and disappear.
- **The public view is dated by the version on show**, not by the author's most recent private
edit, and the share dialog names the same date from the same row, so the two cannot disagree.
- **Pinning takes the row's lock first.** Two pins racing would otherwise both read before either
wrote, and both insert an anchor.
### Any related issues, documentation, discussions?
Closes #7941
Part of #7828. Design discussion: #7128. Stacked on #7853, #8575 and #8576; until those merge
this PR shows their commits too, and the review here is the last one.
### How was this PR tested?
8 new cases in `WorkflowPublishSpec` and `WorkflowVersionResourceSpec` (567 in the dashboard
package):
- an anchor the author can identify in the panel, and the save it was pinned from still visible
beside it rather than folded into it;
- pinning again unchanged reusing the anchor instead of adding a second one;
- the version the pin was taken from surviving after the pin is dropped;
- the public view dated by the pinned version, and the same date reported by the share dialog;
- a workflow that is following carrying no anchor at all.
`scalafmtCheckAll` clean.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 5)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(workflow): mark the pinned version in the revision history [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8577:
URL: https://github.com/apache/texera/pull/8577#issuecomment-5720900804
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@aglinxinyuan`, `@tanishqgandhi1908`
You can notify them by mentioning `@aglinxinyuan`, `@tanishqgandhi1908` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(workflow): mark the pinned version in the revision history [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8577:
URL: https://github.com/apache/texera/pull/8577#issuecomment-5721050867
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8577?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.03279%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 92.76%. Comparing base ([`f9b899a`](https://app.codecov.io/gh/apache/texera/commit/f9b899a52890347d8d44c72c325863ff96fcb714?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`127a900`](https://app.codecov.io/gh/apache/texera/commit/127a900dce998a31052989176cc934a65843dfa6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 9 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/texera/pull/8577?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...shboard/user/workflow/WorkflowPublishService.scala](https://app.codecov.io/gh/apache/texera/pull/8577?src=pr&el=tree&filepath=amber%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Ftexera%2Fweb%2Fresource%2Fdashboard%2Fuser%2Fworkflow%2FWorkflowPublishService.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YW1iZXIvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS90ZXhlcmEvd2ViL3Jlc291cmNlL2Rhc2hib2FyZC91c2VyL3dvcmtmbG93L1dvcmtmbG93UHVibGlzaFNlcnZpY2Uuc2NhbGE=) | 86.53% | [4 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/texera/pull/8577?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ra/web/resource/dashboard/SearchQueryBuilder.scala](https://app.codecov.io/gh/apache/texera/pull/8577?src=pr&el=tree&filepath=amber%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Ftexera%2Fweb%2Fresource%2Fdashboard%2FSearchQueryBuilder.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YW1iZXIvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS90ZXhlcmEvd2ViL3Jlc291cmNlL2Rhc2hib2FyZC9TZWFyY2hRdWVyeUJ1aWxkZXIuc2NhbGE=) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/texera/pull/8577?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...esource/dashboard/WorkflowSearchQueryBuilder.scala](https://app.codecov.io/gh/apache/texera/pull/8577?src=pr&el=tree&filepath=amber%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Ftexera%2Fweb%2Fresource%2Fdashboard%2FWorkflowSearchQueryBuilder.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YW1iZXIvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS90ZXhlcmEvd2ViL3Jlc291cmNlL2Rhc2hib2FyZC9Xb3JrZmxvd1NlYXJjaFF1ZXJ5QnVpbGRlci5zY2FsYQ==) | 97.82% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/texera/pull/8577?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rce/dashboard/user/workflow/WorkflowResource.scala](https://app.codecov.io/gh/apache/texera/pull/8577?src=pr&el=tree&filepath=amber%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Ftexera%2Fweb%2Fresource%2Fdashboard%2Fuser%2Fworkflow%2FWorkflowResource.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YW1iZXIvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS90ZXhlcmEvd2ViL3Jlc291cmNlL2Rhc2hib2FyZC91c2VyL3dvcmtmbG93L1dvcmtmbG93UmVzb3VyY2Uuc2NhbGE=) | 98.36% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/texera/pull/8577?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8577 +/- ##
============================================
- Coverage 92.91% 92.76% -0.16%
- Complexity 4884 4906 +22
============================================
Files 1224 1226 +2
Lines 51298 51619 +321
Branches 6322 6368 +46
============================================
+ Hits 47664 47884 +220
- Misses 2070 2160 +90
- Partials 1564 1575 +11
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/8577/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8577/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `71.78% <ø> (ø)` | | Carriedforward from [dbcf2ec](https://app.codecov.io/gh/apache/texera/commit/dbcf2ec3964d75f22a033406f85066b25bc46c04?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/8577/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.32% <ø> (ø)` | | Carriedforward from [dbcf2ec](https://app.codecov.io/gh/apache/texera/commit/dbcf2ec3964d75f22a033406f85066b25bc46c04?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/8577/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `88.64% <93.03%> (-0.37%)` | :arrow_down: | |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8577/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `54.61% <ø> (ø)` | | Carriedforward from [dbcf2ec](https://app.codecov.io/gh/apache/texera/commit/dbcf2ec3964d75f22a033406f85066b25bc46c04?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/8577/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.25% <ø> (ø)` | | Carriedforward from [dbcf2ec](https://app.codecov.io/gh/apache/texera/commit/dbcf2ec3964d75f22a033406f85066b25bc46c04?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/8577/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.53% <ø> (ø)` | | Carriedforward from [dbcf2ec](https://app.codecov.io/gh/apache/texera/commit/dbcf2ec3964d75f22a033406f85066b25bc46c04?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/8577/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.68% <ø> (ø)` | | Carriedforward from [dbcf2ec](https://app.codecov.io/gh/apache/texera/commit/dbcf2ec3964d75f22a033406f85066b25bc46c04?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8577/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.73% <ø> (ø)` | | Carriedforward from [dbcf2ec](https://app.codecov.io/gh/apache/texera/commit/dbcf2ec3964d75f22a033406f85066b25bc46c04?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/8577/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.47% <ø> (ø)` | | Carriedforward from [dbcf2ec](https://app.codecov.io/gh/apache/texera/commit/dbcf2ec3964d75f22a033406f85066b25bc46c04?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8577/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.09% <ø> (ø)` | | Carriedforward from [dbcf2ec](https://app.codecov.io/gh/apache/texera/commit/dbcf2ec3964d75f22a033406f85066b25bc46c04?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8577?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(workflow): mark the pinned version in the revision history [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8577:
URL: https://github.com/apache/texera/pull/8577#issuecomment-5720973666
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 2 better · 🔴 3 worse · ⚪ 10 noise (<±5%) · 0 without baseline
> Compared against main `471e53c` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/35271938180)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 401 | 0.245 | 24,531/29,830/29,830 us | 🟢 -9.0% / 🔴 +105.5% |
| 🔴 | bs=100 sw=10 sl=64 | 785 | 0.479 | 126,797/140,467/140,467 us | 🔴 +9.1% / 🔴 +40.6% |
| ⚪ | bs=1000 sw=10 sl=64 | 903 | 0.551 | 1,103,799/1,177,335/1,177,335 us | ⚪ within ±5% / 🔴 +22.7% |
<details><summary>Baseline details</summary>
Latest main `471e53c` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 401 tuples/sec | 431 tuples/sec | 839.58 tuples/sec | -7.0% | -52.2% |
| bs=10 sw=10 sl=64 | MB/s | 0.245 MB/s | 0.263 MB/s | 0.512 MB/s | -6.8% | -52.2% |
| bs=10 sw=10 sl=64 | p50 | 24,531 us | 24,494 us | 11,937 us | +0.2% | +105.5% |
| bs=10 sw=10 sl=64 | p95 | 29,830 us | 32,764 us | 14,976 us | -9.0% | +99.2% |
| bs=10 sw=10 sl=64 | p99 | 29,830 us | 32,764 us | 19,204 us | -9.0% | +55.3% |
| bs=100 sw=10 sl=64 | throughput | 785 tuples/sec | 825 tuples/sec | 1,096 tuples/sec | -4.8% | -28.4% |
| bs=100 sw=10 sl=64 | MB/s | 0.479 MB/s | 0.504 MB/s | 0.669 MB/s | -5.0% | -28.4% |
| bs=100 sw=10 sl=64 | p50 | 126,797 us | 116,227 us | 94,033 us | +9.1% | +34.8% |
| bs=100 sw=10 sl=64 | p95 | 140,467 us | 145,786 us | 99,939 us | -3.6% | +40.6% |
| bs=100 sw=10 sl=64 | p99 | 140,467 us | 145,786 us | 110,148 us | -3.6% | +27.5% |
| bs=1000 sw=10 sl=64 | throughput | 903 tuples/sec | 907 tuples/sec | 1,128 tuples/sec | -0.4% | -19.9% |
| bs=1000 sw=10 sl=64 | MB/s | 0.551 MB/s | 0.554 MB/s | 0.688 MB/s | -0.5% | -20.0% |
| bs=1000 sw=10 sl=64 | p50 | 1,103,799 us | 1,099,923 us | 921,191 us | +0.4% | +19.8% |
| bs=1000 sw=10 sl=64 | p95 | 1,177,335 us | 1,171,908 us | 959,735 us | +0.5% | +22.7% |
| bs=1000 sw=10 sl=64 | p99 | 1,177,335 us | 1,171,908 us | 988,604 us | +0.5% | +19.1% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,499.10,200,128000,401,0.245,24531.19,29830.07,29830.07
1,100,10,64,20,2549.21,2000,1280000,785,0.479,126797.06,140466.86,140466.86
2,1000,10,64,20,22149.36,20000,12800000,903,0.551,1103799.02,1177334.66,1177334.66
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(workflow): mark the pinned version in the revision history [texera]
Posted by "yangzhang75 (via GitHub) via notifications" <no...@texera.apache.org>.
yangzhang75 commented on PR #8577:
URL: https://github.com/apache/texera/pull/8577#issuecomment-6573806497
/request-review: @aglinxinyuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org