[GitHub] [iceberg] singhpk234 commented on a diff in pull request #7128: Core: Optimize S3 layout of Datafiles by expanding first character set of the hash

["singhpk234 (via GitHub)" <gi...@apache.org>]

singhpk234 commented on code in PR #7128:
URL: https://github.com/apache/iceberg/pull/7128#discussion_r1156129628


##########
core/src/main/java/org/apache/iceberg/LocationProviders.java:
##########
@@ -104,9 +106,11 @@ public String newDataLocation(String filename) {
   }
 
   static class ObjectStoreLocationProvider implements LocationProvider {
-    private static final Function<Object, Integer> HASH_FUNC =
-        Transforms.bucket(Integer.MAX_VALUE).bind(Types.StringType.get());
 
+    private static final HashFunction HASH_FUNC = Hashing.murmur3_32_fixed();
+    private static final BaseEncoding BASE64_ENCODER =
+        BaseEncoding.base64Url().lowerCase().omitPadding();

Review Comment:
   ACK removed the lowercase() from here .



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org