[jira] [Commented] (STORM-1565) Multi-Lang Performance Improvements

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15341467#comment-15341467 ] 

ASF GitHub Bot commented on STORM-1565:
---------------------------------------

Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/1136
  
    @vesense 
    Sorry to reach out too late. Some comments for me:
    
    1. We might want to include this to multilang (like multilang-serializer) module so that it doesn't affect dependency if users don't use multilang feature. But I'm also OK to have this to core if we are OK to just shade msgpack.
    2. As @dan-blanchard stated we may want to have stable implementation of serializer if possible.
    3. I totally agree with @dan-blanchard that changing default behavior should be avoided unless releasing major version.
    4. It requires users to implement custom multi-lang logic to apply deserialization. IMO, I think it makes issue more complicated. We could provide implementation by default, but it will force user to have dependency at all, and more bad thing is that we need to address this at least three languages.
    
    Personally I feel that we're stuck on having less-maintaining and non-library-dependent default implementations. I can take care of python / ruby implementation though I'm not expert on these, but have no idea on nodejs.


> Multi-Lang Performance Improvements
> -----------------------------------
>
>                 Key: STORM-1565
>                 URL: https://issues.apache.org/jira/browse/STORM-1565
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-core
>            Reporter: Xin Wang
>            Assignee: Xin Wang
>
> 1. add _org.apache.storm.multilang.MessagePackSerializer_
> 2. change default "topology.multilang.serializer" to _MessagePackSerializer_
> According to http://msgpack.org/ : It's like JSON, but fast and small.
> {quote}
> MessagePack is an efficient binary serialization format. It lets you exchange data among multiple languages like JSON. But it's faster and smaller. Small integers are encoded into a single byte, and typical short strings require only one extra byte in addition to the strings themselves.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)