You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "munendrasn (via GitHub)" <gi...@apache.org> on 2023/04/16 07:06:42 UTC
[GitHub] [iceberg] munendrasn opened a new pull request, #7358: AWS: Fix default warehouse path in Dynamodb catalog
munendrasn opened a new pull request, #7358:
URL: https://github.com/apache/iceberg/pull/7358
Without getting the string value of the attribute, the formed the defaultWarehousePath is not in expected format.
cc @amogh-jahagirdar @jackye1995 @yyanyy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] munendrasn commented on a diff in pull request #7358: AWS: Fix default warehouse path in Dynamodb catalog
Posted by "munendrasn (via GitHub)" <gi...@apache.org>.
munendrasn commented on code in PR #7358:
URL: https://github.com/apache/iceberg/pull/7358#discussion_r1175229444
##########
aws/src/test/java/org/apache/iceberg/aws/dynamodb/TestDynamoDbCatalog.java:
##########
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.aws.dynamodb;
+
+import static org.apache.iceberg.aws.dynamodb.DynamoDbCatalog.toPropertyCol;
+import static org.mockito.ArgumentMatchers.any;
+
+import org.apache.iceberg.aws.AwsProperties;
+import org.apache.iceberg.catalog.TableIdentifier;
+import org.apache.iceberg.exceptions.NoSuchNamespaceException;
+import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
+import org.apache.iceberg.relocated.com.google.common.collect.Maps;
+import org.assertj.core.api.Assertions;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.Mockito;
+import software.amazon.awssdk.services.dynamodb.DynamoDbClient;
+import software.amazon.awssdk.services.dynamodb.model.AttributeValue;
+import software.amazon.awssdk.services.dynamodb.model.GetItemRequest;
+import software.amazon.awssdk.services.dynamodb.model.GetItemResponse;
+import software.amazon.awssdk.services.glue.model.*;
+
+public class TestDynamoDbCatalog {
+
+ private static final String WAREHOUSE_PATH = "s3://bucket";
+ private static final String CATALOG_NAME = "dynamodb";
+ private DynamoDbClient dynamo;
+ private DynamoDbCatalog dynamoCatalog;
+
+ @Before
+ public void before() {
+ dynamo = Mockito.mock(DynamoDbClient.class);
+ dynamoCatalog = new DynamoDbCatalog();
+ dynamoCatalog.initialize(CATALOG_NAME, WAREHOUSE_PATH, new AwsProperties(), dynamo, null);
+ }
+
+ @Test
+ public void testConstructorWarehousePathWithEndSlash() {
+ DynamoDbCatalog catalogWithSlash = new DynamoDbCatalog();
+ catalogWithSlash.initialize(
+ CATALOG_NAME, WAREHOUSE_PATH + "/", new AwsProperties(), dynamo, null);
+ Mockito.doReturn(GetItemResponse.builder().item(Maps.newHashMap()).build())
+ .when(dynamo)
+ .getItem(any(GetItemRequest.class));
+ String location = catalogWithSlash.defaultWarehouseLocation(TableIdentifier.of("db", "table"));
+ Assert.assertEquals(WAREHOUSE_PATH + "/db.db/table", location);
Review Comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] JonasJ-ap commented on a diff in pull request #7358: AWS: Fix default warehouse path in Dynamodb catalog
Posted by "JonasJ-ap (via GitHub)" <gi...@apache.org>.
JonasJ-ap commented on code in PR #7358:
URL: https://github.com/apache/iceberg/pull/7358#discussion_r1174610184
##########
aws/src/test/java/org/apache/iceberg/aws/dynamodb/TestDynamoDbCatalog.java:
##########
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.aws.dynamodb;
+
+import static org.apache.iceberg.aws.dynamodb.DynamoDbCatalog.toPropertyCol;
+import static org.mockito.ArgumentMatchers.any;
+
+import org.apache.iceberg.aws.AwsProperties;
+import org.apache.iceberg.catalog.TableIdentifier;
+import org.apache.iceberg.exceptions.NoSuchNamespaceException;
+import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
+import org.apache.iceberg.relocated.com.google.common.collect.Maps;
+import org.assertj.core.api.Assertions;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.Mockito;
+import software.amazon.awssdk.services.dynamodb.DynamoDbClient;
+import software.amazon.awssdk.services.dynamodb.model.AttributeValue;
+import software.amazon.awssdk.services.dynamodb.model.GetItemRequest;
+import software.amazon.awssdk.services.dynamodb.model.GetItemResponse;
+import software.amazon.awssdk.services.glue.model.*;
Review Comment:
Seems this is not used in any test. Could you please delete this import? I think running `spotlessApply` can automatically delete this import and fix some other checkstyle issue if exists
##########
aws/src/test/java/org/apache/iceberg/aws/dynamodb/TestDynamoDbCatalog.java:
##########
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.aws.dynamodb;
+
+import static org.apache.iceberg.aws.dynamodb.DynamoDbCatalog.toPropertyCol;
+import static org.mockito.ArgumentMatchers.any;
+
+import org.apache.iceberg.aws.AwsProperties;
+import org.apache.iceberg.catalog.TableIdentifier;
+import org.apache.iceberg.exceptions.NoSuchNamespaceException;
+import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
+import org.apache.iceberg.relocated.com.google.common.collect.Maps;
+import org.assertj.core.api.Assertions;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.Mockito;
+import software.amazon.awssdk.services.dynamodb.DynamoDbClient;
+import software.amazon.awssdk.services.dynamodb.model.AttributeValue;
+import software.amazon.awssdk.services.dynamodb.model.GetItemRequest;
+import software.amazon.awssdk.services.dynamodb.model.GetItemResponse;
+import software.amazon.awssdk.services.glue.model.*;
+
+public class TestDynamoDbCatalog {
+
+ private static final String WAREHOUSE_PATH = "s3://bucket";
+ private static final String CATALOG_NAME = "dynamodb";
+ private DynamoDbClient dynamo;
+ private DynamoDbCatalog dynamoCatalog;
+
+ @Before
+ public void before() {
+ dynamo = Mockito.mock(DynamoDbClient.class);
+ dynamoCatalog = new DynamoDbCatalog();
+ dynamoCatalog.initialize(CATALOG_NAME, WAREHOUSE_PATH, new AwsProperties(), dynamo, null);
+ }
+
+ @Test
+ public void testConstructorWarehousePathWithEndSlash() {
+ DynamoDbCatalog catalogWithSlash = new DynamoDbCatalog();
+ catalogWithSlash.initialize(
+ CATALOG_NAME, WAREHOUSE_PATH + "/", new AwsProperties(), dynamo, null);
+ Mockito.doReturn(GetItemResponse.builder().item(Maps.newHashMap()).build())
+ .when(dynamo)
+ .getItem(any(GetItemRequest.class));
+ String location = catalogWithSlash.defaultWarehouseLocation(TableIdentifier.of("db", "table"));
+ Assert.assertEquals(WAREHOUSE_PATH + "/db.db/table", location);
Review Comment:
How about using `Assertj` here too?
```suggestion
Assertions.assertThat(location).isEqualTo(WAREHOUSE_PATH + "/db.db/table");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] munendrasn commented on a diff in pull request #7358: AWS: Fix default warehouse path in Dynamodb catalog
Posted by "munendrasn (via GitHub)" <gi...@apache.org>.
munendrasn commented on code in PR #7358:
URL: https://github.com/apache/iceberg/pull/7358#discussion_r1175230382
##########
aws/src/test/java/org/apache/iceberg/aws/dynamodb/TestDynamoDbCatalog.java:
##########
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.aws.dynamodb;
+
+import static org.apache.iceberg.aws.dynamodb.DynamoDbCatalog.toPropertyCol;
+import static org.mockito.ArgumentMatchers.any;
+
+import org.apache.iceberg.aws.AwsProperties;
+import org.apache.iceberg.catalog.TableIdentifier;
+import org.apache.iceberg.exceptions.NoSuchNamespaceException;
+import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
+import org.apache.iceberg.relocated.com.google.common.collect.Maps;
+import org.assertj.core.api.Assertions;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.Mockito;
+import software.amazon.awssdk.services.dynamodb.DynamoDbClient;
+import software.amazon.awssdk.services.dynamodb.model.AttributeValue;
+import software.amazon.awssdk.services.dynamodb.model.GetItemRequest;
+import software.amazon.awssdk.services.dynamodb.model.GetItemResponse;
+import software.amazon.awssdk.services.glue.model.*;
Review Comment:
Spotless doesn't seems to be delete this unused import, maybe because of `*`. I have manually deleted it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on a diff in pull request #7358: AWS: Fix default warehouse path in Dynamodb catalog
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on code in PR #7358:
URL: https://github.com/apache/iceberg/pull/7358#discussion_r1171793456
##########
aws/src/integration/java/org/apache/iceberg/aws/dynamodb/TestDynamoDbCatalog.java:
##########
@@ -379,6 +379,21 @@ public void testRegisterTable() {
Assertions.assertThat(catalog.dropNamespace(namespace)).isTrue();
}
+ @Test
+ public void testDefaultWarehousePathWithLocation() {
Review Comment:
+1 for adding a unit test, @munendrasn let me know if you could add that as suggested, other things looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #7358: AWS: Fix default warehouse path in Dynamodb catalog
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on PR #7358:
URL: https://github.com/apache/iceberg/pull/7358#issuecomment-1520633267
Thanks, merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] JonasJ-ap commented on a diff in pull request #7358: AWS: Fix default warehouse path in Dynamodb catalog
Posted by "JonasJ-ap (via GitHub)" <gi...@apache.org>.
JonasJ-ap commented on code in PR #7358:
URL: https://github.com/apache/iceberg/pull/7358#discussion_r1167979582
##########
aws/src/integration/java/org/apache/iceberg/aws/dynamodb/TestDynamoDbCatalog.java:
##########
@@ -379,6 +379,21 @@ public void testRegisterTable() {
Assertions.assertThat(catalog.dropNamespace(namespace)).isTrue();
}
+ @Test
+ public void testDefaultWarehousePathWithLocation() {
Review Comment:
Thank you for your contribution. I was wondering if it would be possible to add a unit test for this change in addition to the aws integration test. like:
https://github.com/apache/iceberg/blob/b78d3361635e924ed23fd8fe87b5f966b1953dd9/aws/src/test/java/org/apache/iceberg/aws/glue/TestGlueCatalog.java#L143-L153
Since the AWS integration test is not currently run with CI, having a unit test could help catch errors more quickly and ensure that future development reflects this change accurately. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] munendrasn commented on a diff in pull request #7358: AWS: Fix default warehouse path in Dynamodb catalog
Posted by "munendrasn (via GitHub)" <gi...@apache.org>.
munendrasn commented on code in PR #7358:
URL: https://github.com/apache/iceberg/pull/7358#discussion_r1175468506
##########
aws/src/test/java/org/apache/iceberg/aws/dynamodb/TestDynamoDbCatalog.java:
##########
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.aws.dynamodb;
+
+import static org.apache.iceberg.aws.dynamodb.DynamoDbCatalog.toPropertyCol;
+import static org.mockito.ArgumentMatchers.any;
+
+import org.apache.iceberg.aws.AwsProperties;
+import org.apache.iceberg.catalog.TableIdentifier;
+import org.apache.iceberg.exceptions.NoSuchNamespaceException;
+import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
+import org.apache.iceberg.relocated.com.google.common.collect.Maps;
+import org.assertj.core.api.Assertions;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.Mockito;
+import software.amazon.awssdk.services.dynamodb.DynamoDbClient;
+import software.amazon.awssdk.services.dynamodb.model.AttributeValue;
+import software.amazon.awssdk.services.dynamodb.model.GetItemRequest;
+import software.amazon.awssdk.services.dynamodb.model.GetItemResponse;
+
+public class TestDynamoDbCatalog {
+
+ private static final String WAREHOUSE_PATH = "s3://bucket";
+ private static final String CATALOG_NAME = "dynamodb";
+ private DynamoDbClient dynamo;
+ private DynamoDbCatalog dynamoCatalog;
+
+ @Before
+ public void before() {
+ dynamo = Mockito.mock(DynamoDbClient.class);
+ dynamoCatalog = new DynamoDbCatalog();
+ dynamoCatalog.initialize(CATALOG_NAME, WAREHOUSE_PATH, new AwsProperties(), dynamo, null);
+ }
+
+ @Test
+ public void testConstructorWarehousePathWithEndSlash() {
+ DynamoDbCatalog catalogWithSlash = new DynamoDbCatalog();
+ catalogWithSlash.initialize(
+ CATALOG_NAME, WAREHOUSE_PATH + "/", new AwsProperties(), dynamo, null);
+ Mockito.doReturn(GetItemResponse.builder().item(Maps.newHashMap()).build())
+ .when(dynamo)
+ .getItem(any(GetItemRequest.class));
+ String location = catalogWithSlash.defaultWarehouseLocation(TableIdentifier.of("db", "table"));
Review Comment:
Thanks for the review, moved it to constant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #7358: AWS: Fix default warehouse path in Dynamodb catalog
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on code in PR #7358:
URL: https://github.com/apache/iceberg/pull/7358#discussion_r1175442035
##########
aws/src/test/java/org/apache/iceberg/aws/dynamodb/TestDynamoDbCatalog.java:
##########
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.aws.dynamodb;
+
+import static org.apache.iceberg.aws.dynamodb.DynamoDbCatalog.toPropertyCol;
+import static org.mockito.ArgumentMatchers.any;
+
+import org.apache.iceberg.aws.AwsProperties;
+import org.apache.iceberg.catalog.TableIdentifier;
+import org.apache.iceberg.exceptions.NoSuchNamespaceException;
+import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
+import org.apache.iceberg.relocated.com.google.common.collect.Maps;
+import org.assertj.core.api.Assertions;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.Mockito;
+import software.amazon.awssdk.services.dynamodb.DynamoDbClient;
+import software.amazon.awssdk.services.dynamodb.model.AttributeValue;
+import software.amazon.awssdk.services.dynamodb.model.GetItemRequest;
+import software.amazon.awssdk.services.dynamodb.model.GetItemResponse;
+
+public class TestDynamoDbCatalog {
+
+ private static final String WAREHOUSE_PATH = "s3://bucket";
+ private static final String CATALOG_NAME = "dynamodb";
+ private DynamoDbClient dynamo;
+ private DynamoDbCatalog dynamoCatalog;
+
+ @Before
+ public void before() {
+ dynamo = Mockito.mock(DynamoDbClient.class);
+ dynamoCatalog = new DynamoDbCatalog();
+ dynamoCatalog.initialize(CATALOG_NAME, WAREHOUSE_PATH, new AwsProperties(), dynamo, null);
+ }
+
+ @Test
+ public void testConstructorWarehousePathWithEndSlash() {
+ DynamoDbCatalog catalogWithSlash = new DynamoDbCatalog();
+ catalogWithSlash.initialize(
+ CATALOG_NAME, WAREHOUSE_PATH + "/", new AwsProperties(), dynamo, null);
+ Mockito.doReturn(GetItemResponse.builder().item(Maps.newHashMap()).build())
+ .when(dynamo)
+ .getItem(any(GetItemRequest.class));
+ String location = catalogWithSlash.defaultWarehouseLocation(TableIdentifier.of("db", "table"));
Review Comment:
Nit: can we move TableIdentifier.of("db", "table") to a constant? It's used multiple times
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] munendrasn commented on a diff in pull request #7358: AWS: Fix default warehouse path in Dynamodb catalog
Posted by "munendrasn (via GitHub)" <gi...@apache.org>.
munendrasn commented on code in PR #7358:
URL: https://github.com/apache/iceberg/pull/7358#discussion_r1174522019
##########
aws/src/integration/java/org/apache/iceberg/aws/dynamodb/TestDynamoDbCatalog.java:
##########
@@ -379,6 +379,21 @@ public void testRegisterTable() {
Assertions.assertThat(catalog.dropNamespace(namespace)).isTrue();
}
+ @Test
+ public void testDefaultWarehousePathWithLocation() {
Review Comment:
I have included the unit tests, but for now, included tests only for defaultwarehouse location path in unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] munendrasn commented on a diff in pull request #7358: AWS: Fix default warehouse path in Dynamodb catalog
Posted by "munendrasn (via GitHub)" <gi...@apache.org>.
munendrasn commented on code in PR #7358:
URL: https://github.com/apache/iceberg/pull/7358#discussion_r1172753771
##########
aws/src/integration/java/org/apache/iceberg/aws/dynamodb/TestDynamoDbCatalog.java:
##########
@@ -379,6 +379,21 @@ public void testRegisterTable() {
Assertions.assertThat(catalog.dropNamespace(namespace)).isTrue();
}
+ @Test
+ public void testDefaultWarehousePathWithLocation() {
Review Comment:
@JonasJ-ap @jackye1995 Thanks for the review. I will include the unit test as suggested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 merged pull request #7358: AWS: Fix default warehouse path in Dynamodb catalog
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 merged PR #7358:
URL: https://github.com/apache/iceberg/pull/7358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org