You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/12/11 14:36:44 UTC

[kudu-CR] Remove gcc/libstdcxx from thirdparty/LICENSE.txt 

Hello Adar Dembo,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/5466

to review the following change.

Change subject: Remove gcc/libstdcxx from thirdparty/LICENSE.txt
......................................................................

Remove gcc/libstdcxx from thirdparty/LICENSE.txt

We no longer download and build libstdcxx, but forgot to remove this
from the LICENSE.txt file.

Change-Id: I6c040520f701d4b8b4f04176aa03640b38451fea
---
M thirdparty/LICENSE.txt
1 file changed, 0 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/5466/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c040520f701d4b8b4f04176aa03640b38451fea
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>

[kudu-CR] Remove gcc/libstdcxx from thirdparty/LICENSE.txt

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: Remove gcc/libstdcxx from thirdparty/LICENSE.txt
......................................................................


Remove gcc/libstdcxx from thirdparty/LICENSE.txt

We no longer download and build libstdcxx, but forgot to remove this
from the LICENSE.txt file.

Change-Id: I6c040520f701d4b8b4f04176aa03640b38451fea
Reviewed-on: http://gerrit.cloudera.org:8080/5466
Tested-by: Todd Lipcon <to...@apache.org>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M thirdparty/LICENSE.txt
1 file changed, 0 insertions(+), 5 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Todd Lipcon: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6c040520f701d4b8b4f04176aa03640b38451fea
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Remove gcc/libstdcxx from thirdparty/LICENSE.txt

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: Remove gcc/libstdcxx from thirdparty/LICENSE.txt
......................................................................


Patch Set 1: Verified+1

Failed with a flake that I'm aware of

-- 
To view, visit http://gerrit.cloudera.org:8080/5466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c040520f701d4b8b4f04176aa03640b38451fea
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Remove gcc/libstdcxx from thirdparty/LICENSE.txt

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: Remove gcc/libstdcxx from thirdparty/LICENSE.txt
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c040520f701d4b8b4f04176aa03640b38451fea
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No