You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2017/05/06 10:40:04 UTC
[jira] [Commented] (ISIS-1595) Configuration property for JDOQL
VARIABLES clause mismatch
[ https://issues.apache.org/jira/browse/ISIS-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999379#comment-15999379 ]
ASF subversion and git services commented on ISIS-1595:
-------------------------------------------------------
Commit 21baee141058fdad42836544570a227dc4443547 in isis's branch refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=21baee1 ]
ISIS-1595: updates migration notes
> Configuration property for JDOQL VARIABLES clause mismatch
> ----------------------------------------------------------
>
> Key: ISIS-1595
> URL: https://issues.apache.org/jira/browse/ISIS-1595
> Project: Isis
> Issue Type: Bug
> Affects Versions: 1.14.0
> Reporter: Sander Ginn
> Assignee: Dan Haywood
> Fix For: 1.15.0
>
>
> The [migration notes for 1.14.0|http://isis.apache.org/migration-notes.html#_migration-notes_1.13.0-to-1.14.0] states that the configuration property to check for JDOQL {{VARIABLES}} class name validity is:
> {{isis.reflector.validator.jdoqlVariablesClause}}
> However, the [corresponding facet factory|https://github.com/apache/isis/blob/master/core/metamodel/src/main/java/org/apache/isis/objectstore/jdo/metamodel/facets/object/query/JdoQueryAnnotationFacetFactory.java] defines the property differently:
> {{public static final String ISIS_REFLECTOR_VALIDATOR_JDOQL_VARIABLES_CLAUSE_KEY = "isis.reflector.validator.variablesFromClause";}}
> I would argue that the documentation's version is better, since the factory version is rather ambiguous with respect to the property that defines JDOQL {{FROM}} clause validation. I will raise a PR that changes the constant to match the documentation.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)