You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@accumulo.apache.org by ctubbsii <gi...@git.apache.org> on 2017/04/19 19:59:22 UTC

[GitHub] accumulo pull request #252: ACCUMULO-4084 ACCUMULO-4085 volumechooserenv

GitHub user ctubbsii opened a pull request:

    https://github.com/apache/accumulo/pull/252

    ACCUMULO-4084 ACCUMULO-4085 volumechooserenv

    Adds some improvements to the VolumeChooserEnvironment, and creates a "logger" scope so that VolumeChooser implementations can be configured to choose volumes for WALs. (Expect an implementation of such a VolumeChooser in an upcoming PR. I've separated it to make it easier to review.)
    
    This PR depends on #250  (also included in this PR).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ctubbsii/accumulo ACCUMULO-4084-ACCUMULO-4085-volumechooserenv

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/252.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #252
    
----
commit c22031a9c67769bb0a90cbeeb9e935dd8accafbc
Author: Christopher Tubbs <ct...@apache.org>
Date:   2017-04-19T18:25:13Z

    ACCUMULO-3384 support custom system props
    
    Add a property prefix for custom system-wide properties

commit 6812c5efaf6eeee48df46074fc94cf506b5d364a
Author: Christopher Tubbs <ct...@apache.org>
Date:   2017-04-19T18:33:22Z

    ACCUMULO-4084 improve VolumeChooserEnvironment
    
    Update the VolumeManager interface to take a VolumeChooserEnvironment, for maintainability

commit a98cad348bede1fcf597ee1e28d4c8483420508c
Author: Christopher Tubbs <ct...@apache.org>
Date:   2017-04-19T18:53:47Z

    ACCUMULO-4085 Add non-table scope to chooser env
    
    Create a non-table volume chooser scope in the volume chooser
    environment to support choosing volumes for situations other than for
    compacting a particular table.
    
    Initially support a logger scope. Can add others as needed.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] accumulo pull request #252: ACCUMULO-4084 ACCUMULO-4085 volumechooserenv

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/accumulo/pull/252


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] accumulo issue #252: ACCUMULO-4084 ACCUMULO-4085 volumechooserenv

Posted by ctubbsii <gi...@git.apache.org>.

Github user ctubbsii commented on the issue:

    https://github.com/apache/accumulo/pull/252
  
    Rebased this. It's pretty trivial internal improvements, but another set of eyes on it would be helpful just to make sure it doesn't do anything stupid.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] accumulo issue #252: ACCUMULO-4084 ACCUMULO-4085 volumechooserenv

Posted by ctubbsii <gi...@git.apache.org>.

Github user ctubbsii commented on the issue:

    https://github.com/apache/accumulo/pull/252
  
    This PR contains ACCUMULO-4085 also.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] accumulo issue #252: ACCUMULO-4084 ACCUMULO-4085 volumechooserenv

Posted by ctubbsii <gi...@git.apache.org>.

Github user ctubbsii commented on the issue:

    https://github.com/apache/accumulo/pull/252
  
    I'm just going to merge this. It's pretty trivial internals-only change that is relatively small. No review in 24+ hours and I need it for follow-on changes. Can make updates if folks review later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---