[GitHub] [incubator-daffodil] olabusayoT commented on a change in pull request #453: Add SAX Unparse Event Batching

[GitBox <gi...@apache.org>]

olabusayoT commented on a change in pull request #453:
URL: https://github.com/apache/incubator-daffodil/pull/453#discussion_r520059244



##########
File path: daffodil-core/src/test/scala/org/apache/daffodil/processor/TestSAXUnparseAPI.scala
##########
@@ -46,6 +49,24 @@ class TestSAXUnparseAPI {
     assertEquals(testData, bao.toString)
   }
 
+  @Test def testUnparseContentHandler_unparse_saxUnparseEventBatchSize_0(): Unit = {
+    val dpT = testDataprocessor(testSchema, Some(Map("saxUnparseEventBatchSize" -> "0")))

Review comment:
       Correct the minimum batch size should always be 1, so this test ensures there would be an error should the user provide 0 as the batchSize. I'll add a comment to say as much




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org