[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #5379: AWS: Use executor service by default when performing batch deletion of files

[GitBox <gi...@apache.org>]

amogh-jahagirdar commented on code in PR #5379:
URL: https://github.com/apache/iceberg/pull/5379#discussion_r933901731


##########
aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIO.java:
##########
@@ -81,7 +81,9 @@ public class TestS3FileIO {
           "s3.write.tags.tagKey1",
           "TagValue1",
           "s3.delete.batch-size",
-          Integer.toString(batchDeletionSize));
+          Integer.toString(batchDeletionSize),
+          "s3.delete.num-threads",
+          "1");

Review Comment:
   S3Mock is not handling concurrent deletions well and now that multi-threading batch delete is set by default, the testPrefixDelete is failing. Our integ tests give us good coverage for concurrent requests. For removing noise in the normal unit tests due to our dependency on s3mock, for now I've set the delete threadpool size to 1.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org