You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sumit Mohanty <sm...@hortonworks.com> on 2015/03/20 21:01:05 UTC
Review Request 32326: Enable unit tests to run on Mac
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32326/
-----------------------------------------------------------
Review request for Ambari and Jonathan Hurley.
Bugs: AMBARI-10166
https://issues.apache.org/jira/browse/AMBARI-10166
Repository: ambari
Description
-------
Enable unit tests to run on Mac
Diffs
-----
ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 6c14e33
ambari-agent/src/test/python/ambari_agent/TestController.py e2fd7a7
ambari-agent/src/test/python/unitTests.py 0fd6b49
ambari-common/src/main/python/ambari_commons/os_check.py 4e93feb
Diff: https://reviews.apache.org/r/32326/diff/
Testing
-------
Ran the agent unit tests and ensured that new tests got enabled. I will progressively enable other tests verifying that they do not start failing on mac.
The failed test was failing earlier for me as well.
======================================================================
FAIL: test_dump_command_to_json (TestCustomServiceOrchestrator.TestCustomServiceOrchestrator)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/smohanty/enlistments/asf-ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
return func(*args, **keywargs)
File "/Users/smohanty/enlistments/asf-ambari/ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py", line 126, in test_dump_command_to_json
self.assertEqual(oct(os.stat(json_file).st_mode & 0777), '0600')
AssertionError: '0644' != '0600'
----------------------------------------------------------------------
Ran 307 tests in 19.563s
FAILED (failures=1)
Thanks,
Sumit Mohanty
Re: Review Request 32326: Enable unit tests to run on Mac
Posted by Sumit Mohanty <sm...@hortonworks.com>.
> On March 20, 2015, 8:25 p.m., Alejandro Fernandez wrote:
> >
Done.
- Sumit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32326/#review77266
-----------------------------------------------------------
On March 20, 2015, 11:57 p.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32326/
> -----------------------------------------------------------
>
> (Updated March 20, 2015, 11:57 p.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-10166
> https://issues.apache.org/jira/browse/AMBARI-10166
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Enable unit tests to run on Mac
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 6c14e33
> ambari-agent/src/test/python/ambari_agent/TestController.py e2fd7a7
> ambari-agent/src/test/python/unitTests.py 0fd6b49
> ambari-common/src/main/python/ambari_commons/os_check.py 4e93feb
>
> Diff: https://reviews.apache.org/r/32326/diff/
>
>
> Testing
> -------
>
> Ran the agent unit tests and ensured that new tests got enabled. I will progressively enable other tests verifying that they do not start failing on mac.
>
> The failed test was failing earlier for me as well.
>
> ======================================================================
> FAIL: test_dump_command_to_json (TestCustomServiceOrchestrator.TestCustomServiceOrchestrator)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/Users/smohanty/enlistments/asf-ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> return func(*args, **keywargs)
> File "/Users/smohanty/enlistments/asf-ambari/ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py", line 126, in test_dump_command_to_json
> self.assertEqual(oct(os.stat(json_file).st_mode & 0777), '0600')
> AssertionError: '0644' != '0600'
>
> ----------------------------------------------------------------------
> Ran 307 tests in 19.563s
>
> FAILED (failures=1)
>
>
> Thanks,
>
> Sumit Mohanty
>
>
Re: Review Request 32326: Enable unit tests to run on Mac
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32326/#review77266
-----------------------------------------------------------
ambari-common/src/main/python/ambari_commons/os_check.py
<https://reviews.apache.org/r/32326/#comment125145>
to .lower() and compare to "darwin"
- Alejandro Fernandez
On March 20, 2015, 8:01 p.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32326/
> -----------------------------------------------------------
>
> (Updated March 20, 2015, 8:01 p.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-10166
> https://issues.apache.org/jira/browse/AMBARI-10166
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Enable unit tests to run on Mac
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 6c14e33
> ambari-agent/src/test/python/ambari_agent/TestController.py e2fd7a7
> ambari-agent/src/test/python/unitTests.py 0fd6b49
> ambari-common/src/main/python/ambari_commons/os_check.py 4e93feb
>
> Diff: https://reviews.apache.org/r/32326/diff/
>
>
> Testing
> -------
>
> Ran the agent unit tests and ensured that new tests got enabled. I will progressively enable other tests verifying that they do not start failing on mac.
>
> The failed test was failing earlier for me as well.
>
> ======================================================================
> FAIL: test_dump_command_to_json (TestCustomServiceOrchestrator.TestCustomServiceOrchestrator)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/Users/smohanty/enlistments/asf-ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> return func(*args, **keywargs)
> File "/Users/smohanty/enlistments/asf-ambari/ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py", line 126, in test_dump_command_to_json
> self.assertEqual(oct(os.stat(json_file).st_mode & 0777), '0600')
> AssertionError: '0644' != '0600'
>
> ----------------------------------------------------------------------
> Ran 307 tests in 19.563s
>
> FAILED (failures=1)
>
>
> Thanks,
>
> Sumit Mohanty
>
>
Re: Review Request 32326: Enable unit tests to run on Mac
Posted by Sumit Mohanty <sm...@hortonworks.com>.
> On March 20, 2015, 8:13 p.m., Jonathan Hurley wrote:
> >
Yes, I did not see any difference. The check is only used in few places where we may a call based on the OS - e.g WINDOWS vs. LINUX. This changes only removes the error where the code does not recognize the OS.
- Sumit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32326/#review77265
-----------------------------------------------------------
On March 20, 2015, 11:57 p.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32326/
> -----------------------------------------------------------
>
> (Updated March 20, 2015, 11:57 p.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-10166
> https://issues.apache.org/jira/browse/AMBARI-10166
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Enable unit tests to run on Mac
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 6c14e33
> ambari-agent/src/test/python/ambari_agent/TestController.py e2fd7a7
> ambari-agent/src/test/python/unitTests.py 0fd6b49
> ambari-common/src/main/python/ambari_commons/os_check.py 4e93feb
>
> Diff: https://reviews.apache.org/r/32326/diff/
>
>
> Testing
> -------
>
> Ran the agent unit tests and ensured that new tests got enabled. I will progressively enable other tests verifying that they do not start failing on mac.
>
> The failed test was failing earlier for me as well.
>
> ======================================================================
> FAIL: test_dump_command_to_json (TestCustomServiceOrchestrator.TestCustomServiceOrchestrator)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/Users/smohanty/enlistments/asf-ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> return func(*args, **keywargs)
> File "/Users/smohanty/enlistments/asf-ambari/ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py", line 126, in test_dump_command_to_json
> self.assertEqual(oct(os.stat(json_file).st_mode & 0777), '0600')
> AssertionError: '0644' != '0600'
>
> ----------------------------------------------------------------------
> Ran 307 tests in 19.563s
>
> FAILED (failures=1)
>
>
> Thanks,
>
> Sumit Mohanty
>
>
Re: Review Request 32326: Enable unit tests to run on Mac
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32326/#review77265
-----------------------------------------------------------
ambari-common/src/main/python/ambari_commons/os_check.py
<https://reviews.apache.org/r/32326/#comment125144>
Interesting change here. Does this affect the Ambari Server python tests on OSX? Do they still run correctly now?
- Jonathan Hurley
On March 20, 2015, 4:01 p.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32326/
> -----------------------------------------------------------
>
> (Updated March 20, 2015, 4:01 p.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-10166
> https://issues.apache.org/jira/browse/AMBARI-10166
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Enable unit tests to run on Mac
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 6c14e33
> ambari-agent/src/test/python/ambari_agent/TestController.py e2fd7a7
> ambari-agent/src/test/python/unitTests.py 0fd6b49
> ambari-common/src/main/python/ambari_commons/os_check.py 4e93feb
>
> Diff: https://reviews.apache.org/r/32326/diff/
>
>
> Testing
> -------
>
> Ran the agent unit tests and ensured that new tests got enabled. I will progressively enable other tests verifying that they do not start failing on mac.
>
> The failed test was failing earlier for me as well.
>
> ======================================================================
> FAIL: test_dump_command_to_json (TestCustomServiceOrchestrator.TestCustomServiceOrchestrator)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/Users/smohanty/enlistments/asf-ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> return func(*args, **keywargs)
> File "/Users/smohanty/enlistments/asf-ambari/ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py", line 126, in test_dump_command_to_json
> self.assertEqual(oct(os.stat(json_file).st_mode & 0777), '0600')
> AssertionError: '0644' != '0600'
>
> ----------------------------------------------------------------------
> Ran 307 tests in 19.563s
>
> FAILED (failures=1)
>
>
> Thanks,
>
> Sumit Mohanty
>
>
Re: Review Request 32326: Enable unit tests to run on Mac
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32326/#review77326
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On March 20, 2015, 11:57 p.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32326/
> -----------------------------------------------------------
>
> (Updated March 20, 2015, 11:57 p.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-10166
> https://issues.apache.org/jira/browse/AMBARI-10166
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Enable unit tests to run on Mac
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 6c14e33
> ambari-agent/src/test/python/ambari_agent/TestController.py e2fd7a7
> ambari-agent/src/test/python/unitTests.py 0fd6b49
> ambari-common/src/main/python/ambari_commons/os_check.py 4e93feb
>
> Diff: https://reviews.apache.org/r/32326/diff/
>
>
> Testing
> -------
>
> Ran the agent unit tests and ensured that new tests got enabled. I will progressively enable other tests verifying that they do not start failing on mac.
>
> The failed test was failing earlier for me as well.
>
> ======================================================================
> FAIL: test_dump_command_to_json (TestCustomServiceOrchestrator.TestCustomServiceOrchestrator)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/Users/smohanty/enlistments/asf-ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> return func(*args, **keywargs)
> File "/Users/smohanty/enlistments/asf-ambari/ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py", line 126, in test_dump_command_to_json
> self.assertEqual(oct(os.stat(json_file).st_mode & 0777), '0600')
> AssertionError: '0644' != '0600'
>
> ----------------------------------------------------------------------
> Ran 307 tests in 19.563s
>
> FAILED (failures=1)
>
>
> Thanks,
>
> Sumit Mohanty
>
>
Re: Review Request 32326: Enable unit tests to run on Mac
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On March 22, 2015, 8:46 a.m., Jonathan Hurley wrote:
> > Ship It!
>
> Jonathan Hurley wrote:
> Ping. This issue seems to be closed, can we close the review?
Ping again.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32326/#review77350
-----------------------------------------------------------
On March 20, 2015, 7:57 p.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32326/
> -----------------------------------------------------------
>
> (Updated March 20, 2015, 7:57 p.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-10166
> https://issues.apache.org/jira/browse/AMBARI-10166
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Enable unit tests to run on Mac
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 6c14e33
> ambari-agent/src/test/python/ambari_agent/TestController.py e2fd7a7
> ambari-agent/src/test/python/unitTests.py 0fd6b49
> ambari-common/src/main/python/ambari_commons/os_check.py 4e93feb
>
> Diff: https://reviews.apache.org/r/32326/diff/
>
>
> Testing
> -------
>
> Ran the agent unit tests and ensured that new tests got enabled. I will progressively enable other tests verifying that they do not start failing on mac.
>
> The failed test was failing earlier for me as well.
>
> ======================================================================
> FAIL: test_dump_command_to_json (TestCustomServiceOrchestrator.TestCustomServiceOrchestrator)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/Users/smohanty/enlistments/asf-ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> return func(*args, **keywargs)
> File "/Users/smohanty/enlistments/asf-ambari/ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py", line 126, in test_dump_command_to_json
> self.assertEqual(oct(os.stat(json_file).st_mode & 0777), '0600')
> AssertionError: '0644' != '0600'
>
> ----------------------------------------------------------------------
> Ran 307 tests in 19.563s
>
> FAILED (failures=1)
>
>
> Thanks,
>
> Sumit Mohanty
>
>
Re: Review Request 32326: Enable unit tests to run on Mac
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On March 22, 2015, 8:46 a.m., Jonathan Hurley wrote:
> > Ship It!
Ping. This issue seems to be closed, can we close the review?
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32326/#review77350
-----------------------------------------------------------
On March 20, 2015, 7:57 p.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32326/
> -----------------------------------------------------------
>
> (Updated March 20, 2015, 7:57 p.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-10166
> https://issues.apache.org/jira/browse/AMBARI-10166
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Enable unit tests to run on Mac
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 6c14e33
> ambari-agent/src/test/python/ambari_agent/TestController.py e2fd7a7
> ambari-agent/src/test/python/unitTests.py 0fd6b49
> ambari-common/src/main/python/ambari_commons/os_check.py 4e93feb
>
> Diff: https://reviews.apache.org/r/32326/diff/
>
>
> Testing
> -------
>
> Ran the agent unit tests and ensured that new tests got enabled. I will progressively enable other tests verifying that they do not start failing on mac.
>
> The failed test was failing earlier for me as well.
>
> ======================================================================
> FAIL: test_dump_command_to_json (TestCustomServiceOrchestrator.TestCustomServiceOrchestrator)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/Users/smohanty/enlistments/asf-ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> return func(*args, **keywargs)
> File "/Users/smohanty/enlistments/asf-ambari/ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py", line 126, in test_dump_command_to_json
> self.assertEqual(oct(os.stat(json_file).st_mode & 0777), '0600')
> AssertionError: '0644' != '0600'
>
> ----------------------------------------------------------------------
> Ran 307 tests in 19.563s
>
> FAILED (failures=1)
>
>
> Thanks,
>
> Sumit Mohanty
>
>
Re: Review Request 32326: Enable unit tests to run on Mac
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32326/#review77350
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On March 20, 2015, 7:57 p.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32326/
> -----------------------------------------------------------
>
> (Updated March 20, 2015, 7:57 p.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-10166
> https://issues.apache.org/jira/browse/AMBARI-10166
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Enable unit tests to run on Mac
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 6c14e33
> ambari-agent/src/test/python/ambari_agent/TestController.py e2fd7a7
> ambari-agent/src/test/python/unitTests.py 0fd6b49
> ambari-common/src/main/python/ambari_commons/os_check.py 4e93feb
>
> Diff: https://reviews.apache.org/r/32326/diff/
>
>
> Testing
> -------
>
> Ran the agent unit tests and ensured that new tests got enabled. I will progressively enable other tests verifying that they do not start failing on mac.
>
> The failed test was failing earlier for me as well.
>
> ======================================================================
> FAIL: test_dump_command_to_json (TestCustomServiceOrchestrator.TestCustomServiceOrchestrator)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/Users/smohanty/enlistments/asf-ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> return func(*args, **keywargs)
> File "/Users/smohanty/enlistments/asf-ambari/ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py", line 126, in test_dump_command_to_json
> self.assertEqual(oct(os.stat(json_file).st_mode & 0777), '0600')
> AssertionError: '0644' != '0600'
>
> ----------------------------------------------------------------------
> Ran 307 tests in 19.563s
>
> FAILED (failures=1)
>
>
> Thanks,
>
> Sumit Mohanty
>
>
Re: Review Request 32326: Enable unit tests to run on Mac
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32326/
-----------------------------------------------------------
(Updated March 20, 2015, 11:57 p.m.)
Review request for Ambari and Jonathan Hurley.
Changes
-------
Incorporated comments.
Bugs: AMBARI-10166
https://issues.apache.org/jira/browse/AMBARI-10166
Repository: ambari
Description
-------
Enable unit tests to run on Mac
Diffs (updated)
-----
ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 6c14e33
ambari-agent/src/test/python/ambari_agent/TestController.py e2fd7a7
ambari-agent/src/test/python/unitTests.py 0fd6b49
ambari-common/src/main/python/ambari_commons/os_check.py 4e93feb
Diff: https://reviews.apache.org/r/32326/diff/
Testing
-------
Ran the agent unit tests and ensured that new tests got enabled. I will progressively enable other tests verifying that they do not start failing on mac.
The failed test was failing earlier for me as well.
======================================================================
FAIL: test_dump_command_to_json (TestCustomServiceOrchestrator.TestCustomServiceOrchestrator)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/smohanty/enlistments/asf-ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
return func(*args, **keywargs)
File "/Users/smohanty/enlistments/asf-ambari/ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py", line 126, in test_dump_command_to_json
self.assertEqual(oct(os.stat(json_file).st_mode & 0777), '0600')
AssertionError: '0644' != '0600'
----------------------------------------------------------------------
Ran 307 tests in 19.563s
FAILED (failures=1)
Thanks,
Sumit Mohanty