[GitHub] [superset] rusackas commented on a change in pull request #17792: feat: improve color consistency

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #17792:
URL: https://github.com/apache/superset/pull/17792#discussion_r808434743



##########
File path: superset-frontend/src/dashboard/actions/dashboardState.js
##########
@@ -474,6 +480,21 @@ export function addSliceToDashboard(id, component) {
       if (selectedSlice && selectedSlice.viz_type === 'filter_box') {
         dispatch(addFilter(id, component, selectedSlice.form_data));
       }
+
+      setTimeout(() => {

Review comment:
       Agreed. I'm not sure what the 500ms is based on, but it feels arbitrary compared to what's likely to happen in reality. I'm hopeful that there's something we can `await` here. I'm not sure exactly what yet... will need to dig a bit deeper.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org