[GitHub] [pulsar] merlimat opened a new pull request, #16065: Avoid AuthenticationDataSource mutation for subscription name

[GitBox <gi...@apache.org>]

merlimat opened a new pull request, #16065:
URL: https://github.com/apache/pulsar/pull/16065

   ### Motivation
   
   The `authenticationData` field in `ServerCnx` is being mutated to add the `subscription` field that will be passed on to the authorization plugin. The problem is that `authenticationData` is scoped to the whole connection and it should be getting mutated for each consumer that is created on the connection. 
   
   The current code leads to a race condition where the subscription name used in the authz plugin is already modified while we're looking at it. Instead, we should create a new object and enforce the final modifier.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #16065: Avoid AuthenticationDataSource mutation for subscription name

[GitBox <gi...@apache.org>]

codelipenghui merged PR #16065:
URL: https://github.com/apache/pulsar/pull/16065


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org