You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2020/12/07 07:37:59 UTC

[GitHub] [cxf] rmannibucau commented on pull request #721: [cxf-8340] add precompiled class for Graalvm native support

rmannibucau commented on pull request #721:
URL: https://github.com/apache/cxf/pull/721#issuecomment-739732809


   Except ClassGeneratorClassLoader static variables which still look fishy and unexpected - they hide another bug to be concrete like during redeployment of a server with some different config for resource selection - it looks very good for a first mergeable set of changes. I'd just add some doc, maybe some javadoc with a pointer to the doc (if on a wiki/website) to explain how to use it as you did in the test and it is all good for me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org