You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "jamesnetherton (via GitHub)" <gi...@apache.org> on 2023/07/04 12:49:15 UTC

[GitHub] [camel-quarkus-examples] jamesnetherton commented on a diff in pull request #154: Improve Tracing docs

jamesnetherton commented on code in PR #154:
URL: https://github.com/apache/camel-quarkus-examples/pull/154#discussion_r1251974510


##########
observability/README.adoc:
##########
@@ -124,27 +124,27 @@ You can also directly leverage MicroProfile Health APIs to create checks. Class
 
 === Tracing
 
-The tracing configuration for the application can be found within `application.properties`.
+To be able to diagnose problems in the Camel Quarkus application, you can start tracing messages.

Review Comment:
   ```suggestion
   To be able to diagnose problems in Camel Quarkus applications, you can start tracing messages.
   ```



##########
observability/README.adoc:
##########
@@ -124,27 +124,27 @@ You can also directly leverage MicroProfile Health APIs to create checks. Class
 
 === Tracing
 
-The tracing configuration for the application can be found within `application.properties`.
+To be able to diagnose problems in the Camel Quarkus application, you can start tracing messages.
+We will use OpenTelemetry standard suited for cloud environments.
 
-The default configuration uses the OTLP exporter, but it can be easily switched to the Jaeger exporter by applying this change in `application.properties`:
+All you need is adding `camel-quarkus-opentelemetry` dependency (see link:pom.xml#L101-L104[pom.xml]):

Review Comment:
   ```suggestion
   All you need is to add the `camel-quarkus-opentelemetry` dependency (see link:pom.xml#L101-L104[pom.xml]):
   ```



##########
observability/README.adoc:
##########
@@ -124,27 +124,27 @@ You can also directly leverage MicroProfile Health APIs to create checks. Class
 
 === Tracing
 
-The tracing configuration for the application can be found within `application.properties`.
+To be able to diagnose problems in the Camel Quarkus application, you can start tracing messages.
+We will use OpenTelemetry standard suited for cloud environments.
 
-The default configuration uses the OTLP exporter, but it can be easily switched to the Jaeger exporter by applying this change in `application.properties`:
+All you need is adding `camel-quarkus-opentelemetry` dependency (see link:pom.xml#L101-L104[pom.xml]):
 
-[source,shell]
+[source, xml]
 ----
-- quarkus.otel.exporter.otlp.traces.endpoint=http://localhost:4317
-+ quarkus.otel.exporter.jaeger.traces.endpoint=http://localhost:14250
+<dependency>
+    <groupId>org.apache.camel.quarkus</groupId>
+    <artifactId>camel-quarkus-opentelemetry</artifactId>
+</dependency>
 ----
 
-and this change in `pom.xml`:
+and configuring (we are using placeholder to be able to test this example in convenient way in cloud environment) the exporter (see link:src/main/resources/application.properties#L28[application.properties]) :

Review Comment:
   ```suggestion
   and configure (we are using placeholder to be able to test this example in convenient way in cloud environment) the exporter (see link:src/main/resources/application.properties#L28[application.properties]) :
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org