You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Reijhanniel Jearl Campos <no...@github.com> on 2016/09/07 00:40:18 UTC

Re: [jclouds/jclouds-labs] Pb compute api (#292)

Hi @alibazlamit !

The initial comments on this PR haven't been addressed yet; see [Files Changed](https://github.com/jclouds/jclouds-labs/pull/292/files) tab of this PR, most notably style-checks. The diff made it looked like that this PR changed *everything* due to the formatting changes. While this does not necessarily break code correctness, reviewing becomes 10x more times difficult (actually, 5700+ additions ;) ), as we're *might* be seeing changes not intentionally addressed by this PR (i.e.: Compute Service).

Could you take care of that first, by removing the disabled `<checkstyle.skip>`s, and reformatting the source? If you're using eclipse or idea, they have a profile you can format [here](https://cwiki.apache.org/confluence/display/JCLOUDS/Coding+Standards).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/292#issuecomment-245140170