You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Hisoka-X (via GitHub)" <gi...@apache.org> on 2023/09/26 13:02:14 UTC

[GitHub] [spark] Hisoka-X commented on a diff in pull request #43126: [SPARK-45338][CORE][SQL] Replace `scala.collection.JavaConverters` to `scala.jdk.CollectionConverters`

Hisoka-X commented on code in PR #43126:
URL: https://github.com/apache/spark/pull/43126#discussion_r1337172580


##########
mllib/src/main/scala/org/apache/spark/mllib/api/python/GaussianMixtureModelWrapper.scala:
##########
@@ -17,7 +17,7 @@
 
 package org.apache.spark.mllib.api.python
 
-import scala.collection.JavaConverters
+import scala.jdk.javaapi.CollectionConverters.asJava

Review Comment:
   Thansk for review! Addressed all



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org