You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/12/03 13:09:09 UTC

Re: [PR] Improve numerice_coercion and reuse in both compare op and math op [arrow-datafusion]

alamb commented on PR #8385:
URL: https://github.com/apache/arrow-datafusion/pull/8385#issuecomment-1837476159

   Thanks @jayzhan211  -- I think this PR needs some careful review to ensure it doesn't introduce subtle bugs / logic errors. I will try and find time but I worry about this PR introducing regressions for no (practical) benefit.
   
   Could you please:
   1. Add the new tests as a separate PR (to better document the current behavior)
   2. Explain what, if any, issue this is solving (e.g. what queries run with this PR that did not before, or what cases work better than they did)
   
   Thank you
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org