You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "bschuchardt (GitHub)" <gi...@apache.org> on 2018/12/01 00:02:23 UTC
[GitHub] [geode] bschuchardt opened pull request #2935: GEODE-6121
Port SnappyData DirectChannel comms changes to Geode
Not ready for review! This PR is for running precheckin tests.
Initial port of SnappyData peer-to-peer communication changes to Geode.
See https://github.com/SnappyDataInc/snappy-store/commit/49222766a35c99f4853b7b6661457f37b3c39349
The current changes have connection-streaming and conserve-sockets=false
as the default for testing but I will be changing this. The connection-streaming
feature will be an opt-in thing at first and probably be marked experimental.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/2935 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] bschuchardt commented on issue #2935: GEODE-6121
Port SnappyData DirectChannel comms changes to Geode
Posted by "bschuchardt (GitHub)" <gi...@apache.org>.
Closing this PR as the changes from SnappyData aren't backward compatible and are not showing performance improvements. In general I'm seeing performance stay the same or degrade.
[ Full content available at: https://github.com/apache/geode/pull/2935 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] bschuchardt closed pull request #2935: GEODE-6121
Port SnappyData DirectChannel comms changes to Geode
Posted by "bschuchardt (GitHub)" <gi...@apache.org>.
[ pull request closed by bschuchardt ]
[ Full content available at: https://github.com/apache/geode/pull/2935 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org