[GitHub] [hbase] Apache9 commented on a change in pull request #2853: HBASE-25471 Move RegionScannerImpl out of HRegion

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #2853:
URL: https://github.com/apache/hbase/pull/2853#discussion_r553770251



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -4039,7 +4031,7 @@ private static Get toGet(final Mutation mutation) throws IOException {
       // Sort the cells so that they match the order that they appear in the Get results.
       // Otherwise, we won't be able to find the existing values if the cells are not specified
       // in order by the client since cells are in an array list.
-      sort(deltas, store.getComparator());
+      deltas.sort(store.getComparator());

Review comment:
       HRegion.sort is also referenced in RegionScannerImpl and it is just a one line function, so just removed it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org