You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Yujie Li <ry...@gmail.com> on 2017/05/18 20:27:24 UTC
Review Request 59376: RANGER-1584 Allow tagsync to support log
directory from Ambari configuration
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59376/
-----------------------------------------------------------
Review request for ranger.
Repository: ranger
Description
-------
Currently Tagsync hardcodes the log directory as /var/log/ranger/tagsync. It doesn't support customization setting for log location from Ambari side.
But Ambari is exporting an environment as RANGER_TAGSYNC_LOG_DIR for tagsync log dir already. Ranger should pick up this to work with Ambari configuration instead of hardcoding it.
Diffs
-----
tagsync/scripts/ranger-tagsync-services.sh 3b90d116
Diff: https://reviews.apache.org/r/59376/diff/1/
Testing
-------
New Installation with Amabri.
Replacing the script with exisiting ranger installation.
Thanks,
Yujie Li
Re: Review Request 59376: RANGER-1584 Allow tagsync to support log
directory from Ambari configuration
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59376/#review175775
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 18, 2017, 8:36 p.m., Yujie Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59376/
> -----------------------------------------------------------
>
> (Updated May 18, 2017, 8:36 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1584
> https://issues.apache.org/jira/browse/RANGER-1584
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently Tagsync hardcodes the log directory as /var/log/ranger/tagsync. It doesn't support customization setting for log location from Ambari side.
> But Ambari is exporting an environment as RANGER_TAGSYNC_LOG_DIR for tagsync log dir already. Ranger should pick up this to work with Ambari configuration instead of hardcoding it.
>
>
> Diffs
> -----
>
> tagsync/scripts/ranger-tagsync-services.sh 3b90d116
>
>
> Diff: https://reviews.apache.org/r/59376/diff/1/
>
>
> Testing
> -------
>
> New Installation with Amabri.
>
> Replacing the script with exisiting ranger installation.
>
>
> Thanks,
>
> Yujie Li
>
>
Re: Review Request 59376: RANGER-1584 Allow tagsync to support log
directory from Ambari configuration
Posted by Yujie Li <ry...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59376/
-----------------------------------------------------------
(Updated May 18, 2017, 8:36 p.m.)
Review request for ranger.
Bugs: RANGER-1584
https://issues.apache.org/jira/browse/RANGER-1584
Repository: ranger
Description
-------
Currently Tagsync hardcodes the log directory as /var/log/ranger/tagsync. It doesn't support customization setting for log location from Ambari side.
But Ambari is exporting an environment as RANGER_TAGSYNC_LOG_DIR for tagsync log dir already. Ranger should pick up this to work with Ambari configuration instead of hardcoding it.
Diffs
-----
tagsync/scripts/ranger-tagsync-services.sh 3b90d116
Diff: https://reviews.apache.org/r/59376/diff/1/
Testing
-------
New Installation with Amabri.
Replacing the script with exisiting ranger installation.
Thanks,
Yujie Li