You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/13 08:49:44 UTC

[GitHub] [spark] AngersZhuuuu opened a new pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

AngersZhuuuu opened a new pull request #33736:
URL: https://github.com/apache/spark/pull/33736


   ### What changes were proposed in this pull request?
   Add PlanStability suite for TPCH
   
   
   ### Why are the changes needed?
   Add PlanStability suite for TPCH
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Added UT
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899428203


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47009/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899171541






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-901443351


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142619/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898798085


   **[Test build #142461 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142461/testReport)** for PR 33736 at commit [`7e54bf8`](https://github.com/apache/spark/commit/7e54bf8bdfb9b6d7f10d7514ac4bf6534a8ad0b5).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900203600


   **[Test build #142539 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142539/testReport)** for PR 33736 at commit [`25a3b60`](https://github.com/apache/spark/commit/25a3b60dc470c5e0a4f1796bde7d25bef567d9d4).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-901377839


   **[Test build #142615 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142615/testReport)** for PR 33736 at commit [`ec79d4b`](https://github.com/apache/spark/commit/ec79d4b1ebc9dbd7e592cd3d438f4521fd0460a9).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899224037


   **[Test build #142487 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142487/testReport)** for PR 33736 at commit [`d2f0cfa`](https://github.com/apache/spark/commit/d2f0cfacd64689ce555fc6d450037cc0242031bf).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900641022


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142558/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900641022






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898815242


   **[Test build #142463 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142463/testReport)** for PR 33736 at commit [`5e3f257`](https://github.com/apache/spark/commit/5e3f257334082553f32423a7aca40f5b712354e1).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900639671


   **[Test build #142558 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142558/testReport)** for PR 33736 at commit [`21539ff`](https://github.com/apache/spark/commit/21539ff5e7b7be2f278195617a01457297c09f50).
    * This patch **fails from timeout after a configured wait of `500m`**.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `trait PlanStabilitySuite extends DisableAdaptiveExecutionSuite `
     * `class TPCDSV1_4_PlanStabilitySuite extends PlanStabilitySuite with TPCDSBase `
     * `class TPCDSV1_4_PlanStabilityWithStatsSuite extends PlanStabilitySuite with TPCDSBase `
     * `class TPCDSV2_7_PlanStabilitySuite extends PlanStabilitySuite with TPCDSBase `
     * `class TPCDSV2_7_PlanStabilityWithStatsSuite extends PlanStabilitySuite with TPCDSBase `
     * `class TPCDSModifiedPlanStabilitySuite extends PlanStabilitySuite with TPCDSBase `
     * `class TPCDSModifiedPlanStabilityWithStatsSuite extends PlanStabilitySuite with TPCDSBase `
     * `class TPCHPlanStabilitySuite extends PlanStabilitySuite with TPCHBase `
     * `trait PlanSuiteBase extends SharedSparkSession `
     * `trait TPCDSBase extends PlanSuiteBase with TPCDSSchema `
     * `trait TPCHBase extends PlanSuiteBase `


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900097478


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47041/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900639671






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900097478


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47041/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #33736:
URL: https://github.com/apache/spark/pull/33736#discussion_r690071365



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
##########
@@ -79,6 +79,17 @@ trait TPCDSBase extends SharedSparkSession with TPCDSSchema {
        """.stripMargin)
   }
 
+  def createTables(): Unit = {

Review comment:
       > where else do we call this method?
   
   Since PlanStabilitySuite extends TPCDSBase and the create table in `beforeAll`, here we split `createTables`
   then for TPCH suite we can only just create our needed table.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898876311


   **[Test build #142464 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142464/testReport)** for PR 33736 at commit [`b4151d5`](https://github.com/apache/spark/commit/b4151d5031b5107fed078f2e79d7a18aa2195d79).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898860533


   **[Test build #142463 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142463/testReport)** for PR 33736 at commit [`5e3f257`](https://github.com/apache/spark/commit/5e3f257334082553f32423a7aca40f5b712354e1).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900764647


   **[Test build #142575 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142575/testReport)** for PR 33736 at commit [`21539ff`](https://github.com/apache/spark/commit/21539ff5e7b7be2f278195617a01457297c09f50).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan closed pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #33736:
URL: https://github.com/apache/spark/pull/33736


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-901257632


   **[Test build #142619 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142619/testReport)** for PR 33736 at commit [`c2940dc`](https://github.com/apache/spark/commit/c2940dc75b7de57ae3b625ddf912bbe1068d7e39).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900762616


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898846668


   **[Test build #142464 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142464/testReport)** for PR 33736 at commit [`b4151d5`](https://github.com/apache/spark/commit/b4151d5031b5107fed078f2e79d7a18aa2195d79).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33736:
URL: https://github.com/apache/spark/pull/33736#discussion_r691307948



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
##########
@@ -102,15 +88,9 @@ trait TPCDSBase extends SharedSparkSession with TPCDSSchema {
     }
   }
 
-  override def afterAll(): Unit = {
-    conf.setConf(SQLConf.CBO_ENABLED, originalCBCEnabled)
-    conf.setConf(SQLConf.PLAN_STATS_ENABLED, originalPlanStatsEnabled)
-    conf.setConf(SQLConf.JOIN_REORDER_ENABLED, originalJoinReorderEnabled)
+  override def dropTables(): Unit = {
     tableNames.foreach { tableName =>
       spark.sessionState.catalog.dropTable(TableIdentifier(tableName), true, true)
     }
-    super.afterAll()
   }
-
-  protected def injectStats: Boolean = false

Review comment:
       where is `injectStats` defined now?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899291198


   **[Test build #142487 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142487/testReport)** for PR 33736 at commit [`d2f0cfa`](https://github.com/apache/spark/commit/d2f0cfacd64689ce555fc6d450037cc0242031bf).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #33736:
URL: https://github.com/apache/spark/pull/33736#discussion_r691318695



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/PlanSuiteBase.scala
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql
+
+import org.apache.spark.sql.internal.SQLConf
+import org.apache.spark.sql.test.SharedSparkSession
+
+trait PlanSuiteBase extends SharedSparkSession {
+
+  private val originalCBCEnabled = conf.cboEnabled

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900278003






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33736:
URL: https://github.com/apache/spark/pull/33736#discussion_r690046057



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/PlanStabilitySuite.scala
##########
@@ -333,3 +340,22 @@ class TPCDSModifiedPlanStabilityWithStatsSuite extends PlanStabilitySuite {
     }
   }
 }
+
+abstract class TPCHPlanStabilitySuiteBase extends PlanStabilitySuite {

Review comment:
       why add an abstract class that has only one child?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899202485


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46985/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-901379124


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142615/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900966756


   **[Test build #142605 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142605/testReport)** for PR 33736 at commit [`989c823`](https://github.com/apache/spark/commit/989c823b71858860d61318e9d1d59dcc3e3dd801).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900096719


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47040/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899181875


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46984/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900063261


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47041/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899356892


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47002/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33736:
URL: https://github.com/apache/spark/pull/33736#discussion_r691305225



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/PlanSuiteBase.scala
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql
+
+import org.apache.spark.sql.internal.SQLConf
+import org.apache.spark.sql.test.SharedSparkSession
+
+trait PlanSuiteBase extends SharedSparkSession {
+
+  private val originalCBCEnabled = conf.cboEnabled

Review comment:
       ```suggestion
     private val originalCBOEnabled = conf.cboEnabled
   ```

##########
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
##########
@@ -102,15 +88,9 @@ trait TPCDSBase extends SharedSparkSession with TPCDSSchema {
     }
   }
 
-  override def afterAll(): Unit = {
-    conf.setConf(SQLConf.CBO_ENABLED, originalCBCEnabled)
-    conf.setConf(SQLConf.PLAN_STATS_ENABLED, originalPlanStatsEnabled)
-    conf.setConf(SQLConf.JOIN_REORDER_ENABLED, originalJoinReorderEnabled)
+  override def dropTables(): Unit = {
     tableNames.foreach { tableName =>
       spark.sessionState.catalog.dropTable(TableIdentifier(tableName), true, true)
     }
-    super.afterAll()
   }
-
-  protected def injectStats: Boolean = false

Review comment:
       where is `injectStats` defined now?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899584008


   **[Test build #142508 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142508/testReport)** for PR 33736 at commit [`054a5e0`](https://github.com/apache/spark/commit/054a5e0f91f0663184b838f6406c46a5e26b70c6).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900092622


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47040/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898920919






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899397152


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47002/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-901164044


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142605/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900797947


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47076/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900966756


   **[Test build #142605 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142605/testReport)** for PR 33736 at commit [`989c823`](https://github.com/apache/spark/commit/989c823b71858860d61318e9d1d59dcc3e3dd801).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898920819


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46975/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899398247


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142501/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899191927


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46984/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899397989


   **[Test build #142501 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142501/testReport)** for PR 33736 at commit [`17d3014`](https://github.com/apache/spark/commit/17d301435f77be134a93b1eec9a85db749e3a6ae).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899283196


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46986/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-901164044


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142605/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898804972


   Kubernetes integration test unable to build dist.
   
   exiting with code: 1
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46967/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-901007756


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47105/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898846668


   **[Test build #142464 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142464/testReport)** for PR 33736 at commit [`b4151d5`](https://github.com/apache/spark/commit/b4151d5031b5107fed078f2e79d7a18aa2195d79).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900205558


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142539/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898815579


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142461/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #33736:
URL: https://github.com/apache/spark/pull/33736#discussion_r690070608



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/PlanStabilitySuite.scala
##########
@@ -333,3 +340,22 @@ class TPCDSModifiedPlanStabilityWithStatsSuite extends PlanStabilitySuite {
     }
   }
 }
+
+abstract class TPCHPlanStabilitySuiteBase extends PlanStabilitySuite {

Review comment:
       > why add an abstract class that has only one child?
   
   Have [withState]  subclass before but found not have stats data then remove it.  Remove  TPCHPlanStabilitySuiteBase now




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900822986


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142575/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900820397


   **[Test build #142575 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142575/testReport)** for PR 33736 at commit [`21539ff`](https://github.com/apache/spark/commit/21539ff5e7b7be2f278195617a01457297c09f50).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `trait PlanStabilitySuite extends DisableAdaptiveExecutionSuite `
     * `class TPCDSV1_4_PlanStabilitySuite extends PlanStabilitySuite with TPCDSBase `
     * `class TPCDSV1_4_PlanStabilityWithStatsSuite extends PlanStabilitySuite with TPCDSBase `
     * `class TPCDSV2_7_PlanStabilitySuite extends PlanStabilitySuite with TPCDSBase `
     * `class TPCDSV2_7_PlanStabilityWithStatsSuite extends PlanStabilitySuite with TPCDSBase `
     * `class TPCDSModifiedPlanStabilitySuite extends PlanStabilitySuite with TPCDSBase `
     * `class TPCDSModifiedPlanStabilityWithStatsSuite extends PlanStabilitySuite with TPCDSBase `
     * `class TPCHPlanStabilitySuite extends PlanStabilitySuite with TPCHBase `
     * `trait PlanSuiteBase extends SharedSparkSession `
     * `trait TPCDSBase extends PlanSuiteBase with TPCDSSchema `
     * `trait TPCHBase extends PlanSuiteBase `


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33736:
URL: https://github.com/apache/spark/pull/33736#discussion_r690045699



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
##########
@@ -79,6 +79,17 @@ trait TPCDSBase extends SharedSparkSession with TPCDSSchema {
        """.stripMargin)
   }
 
+  def createTables(): Unit = {

Review comment:
       where else do we call this method?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898815579






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899250123


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46986/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900278003


   **[Test build #142558 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142558/testReport)** for PR 33736 at commit [`21539ff`](https://github.com/apache/spark/commit/21539ff5e7b7be2f278195617a01457297c09f50).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898449880


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142424/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900324751


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47060/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898815538


   **[Test build #142461 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142461/testReport)** for PR 33736 at commit [`7e54bf8`](https://github.com/apache/spark/commit/7e54bf8bdfb9b6d7f10d7514ac4bf6534a8ad0b5).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `public class BlockPushNonFatalFailure extends RuntimeException `
     * `public class TimerWithCustomTimeUnit extends Timer `
     * `  class BlockFetchErrorHandler implements ErrorHandler `
     * `public class NoOpMergedShuffleFileManager implements MergedShuffleFileManager `
     * `  public static class AppShuffleMergePartitionsInfo `
     * `  public static class AppShuffleInfo `
     * `public class RetryingBlockTransferor `
     * `public class ShuffleChecksumHelper `
     * `public class BlockPushReturnCode extends BlockTransferMessage `
     * `public class CorruptionCause extends BlockTransferMessage `
     * `public class DiagnoseCorruption extends BlockTransferMessage `
     * `public final class SparkOutOfMemoryError extends OutOfMemoryError implements SparkThrowable `
     * `final class ShuffleExternalSorter extends MemoryConsumer implements ShuffleChecksumSupport `
     * `      throw new IllegalArgumentException(s\"Cannot find error class '$errorClass'\"))`
     * `class SparkArithmeticException(errorClass: String, messageParameters: Array[String])`
     * `class MutableCheckedOutputStream(out: OutputStream) extends OutputStream `
     * `case class ShuffleChecksumBlockId(shuffleId: Int, mapId: Long, reduceId: Int) extends BlockId `
     * `case class ShufflePushBlockId(`
     * `case class ShuffleMergedBlockId(`
     * `case class ShuffleMergedDataBlockId(`
     * `  class RemoteBlockDownloadFileManager(`
     * `class BlockSavedOnDecommissionedBlockManagerException(blockId: BlockId)`
     * `public final class JavaStructuredComplexSessionization `
     * `  public static class Sessions `
     * `  public static class SessionEvent implements Serializable `
     * `  public static class SessionAcc implements Serializable `
     * `  public static class Session implements Serializable `
     * `case class SessionEvent(`
     * `case class SessionAcc(events: List[SessionEvent]) `
     * `case class Session(`
     * `  case class AvroMatchedField(`
     * `public final class Aggregation implements Serializable `
     * `public final class Count implements AggregateFunc `
     * `public final class CountStar implements AggregateFunc `
     * `public final class Max implements AggregateFunc `
     * `public final class Min implements AggregateFunc `
     * `public final class Sum implements AggregateFunc `
     * `case class UnresolvedFieldPosition(position: ColumnPosition) extends FieldPosition `
     * `case class ExpressionEquals(e: Expression) `
     * `case class ExpressionStats(expr: Expression)(var useCount: Int = 1) `
     * `case class SessionWindow(timeColumn: Expression, gapDuration: Long) extends UnaryExpression`
     * `case class Average(`
     * `case class Sum(`
     * `case class SubExprEliminationState(eval: ExprCode, children: Seq[SubExprEliminationState])`
     * `case class LocalTimestamp(timeZoneId: Option[String] = None) extends LeafExpression`
     * `case class GetTimestamp(`
     * `case class ParseToTimestampLTZ(`
     * `case class ParseToTimestamp(`
     * `case class MakeTimestampNTZ(`
     * `case class MakeTimestampLTZ(`
     * `case class DomainJoin(`
     * `trait AlterTableCommand extends UnaryCommand `
     * `case class CommentOnTable(table: LogicalPlan, comment: String) extends AlterTableCommand `
     * `case class SetTableLocation(`
     * `case class SetTableProperties(`
     * `case class UnsetTableProperties(`
     * `case class AddColumns(`
     * `case class ReplaceColumns(`
     * `case class DropColumns(`
     * `case class RenameColumn(`
     * `case class AlterColumn(`
     * `      .doc(\"The custom cost evaluator class to be used for adaptive execution. If not being set,\" +`
     * `  static class IntegerUpdater implements ParquetVectorUpdater `
     * `class Observation(name: String) `
     * `case class CoalescedMapperPartitionSpec(`
     * `trait AQEShuffleReadRule extends Rule[SparkPlan] `
     * `case class CoalesceShufflePartitions(session: SparkSession) extends AQEShuffleReadRule `
     * `class BasicWriteTaskStatsTracker(`
     * `protected abstract class ConnectionProviderBase extends Logging `
     * `case class ScanBuilderHolder(`
     * `case class EnsureRequirements(optimizeOutRepartition: Boolean = true) extends Rule[SparkPlan] `
     * `class MergingSortWithSessionWindowStateIterator(`
     * `class ContinuousWriteRDD(var prev: RDD[InternalRow], writerFactory: StreamingDataWriterFactory,`
     * `case class WriteToContinuousDataSource(write: StreamingWrite, query: LogicalPlan,`
     * `case class WriteToContinuousDataSourceExec(write: StreamingWrite, query: SparkPlan,`
     * `trait HDFSBackedStateStoreMap `
     * `class NoPrefixHDFSBackedStateStoreMap extends HDFSBackedStateStoreMap `
     * `class PrefixScannableHDFSBackedStateStoreMap(`
     * `  class HDFSBackedReadStateStore(val version: Long, map: HDFSBackedStateStoreMap)`
     * `  class HDFSBackedStateStore(val version: Long, mapToUpdate: HDFSBackedStateStoreMap)`
     * `case class RocksDBMetrics(`
     * `case class RocksDBNativeHistogram(`
     * `case class RocksDBFileManagerMetrics(`
     * `sealed trait RocksDBStateEncoder `
     * `class PrefixKeyScanStateEncoder(`
     * `class NoPrefixKeyStateEncoder(keySchema: StructType, valueSchema: StructType)`
     * `  class RocksDBStateStore(lastVersion: Long) extends StateStore `
     * `sealed trait StreamingSessionWindowStateManager extends Serializable `
     * `class StreamingSessionWindowStateManagerImplV1(`
     * `class StreamingSessionWindowHelper(sessionExpression: Attribute, inputSchema: Seq[Attribute]) `
     * `case class SessionWindowStateStoreRestoreExec(`
     * `case class SessionWindowStateStoreSaveExec(`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898815242


   **[Test build #142463 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142463/testReport)** for PR 33736 at commit [`5e3f257`](https://github.com/apache/spark/commit/5e3f257334082553f32423a7aca40f5b712354e1).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899403987


   **[Test build #142508 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142508/testReport)** for PR 33736 at commit [`054a5e0`](https://github.com/apache/spark/commit/054a5e0f91f0663184b838f6406c46a5e26b70c6).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898819883


   Kubernetes integration test unable to build dist.
   
   exiting with code: 1
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46969/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899597442


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142508/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899322935


   **[Test build #142501 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142501/testReport)** for PR 33736 at commit [`17d3014`](https://github.com/apache/spark/commit/17d301435f77be134a93b1eec9a85db749e3a6ae).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-901238651


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47116/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-901278506


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47116/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899446931






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33736:
URL: https://github.com/apache/spark/pull/33736#discussion_r690234889



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/PlanStabilitySuite.scala
##########
@@ -66,7 +66,7 @@ import org.apache.spark.sql.internal.SQLConf
  * }}}
  */
 // scalastyle:on line.size.limit
-trait PlanStabilitySuite extends TPCDSBase with DisableAdaptiveExecutionSuite {
+trait PlanStabilitySuite extends TPCDSBase with TPCHBase with DisableAdaptiveExecutionSuite {

Review comment:
       It's a bit weird that `TPCDSBase` and `TPCHBase` are not at the same level (`TPCDSBase` is much more complicated). Can we do a bit more refactoring? Probably pull out some logic (e.g. `createTable`) from `TPCDSBase` to `PlanStabilitySuite` or a new `trait`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900785917


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47076/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899291654


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142487/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-901185645


   **[Test build #142615 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142615/testReport)** for PR 33736 at commit [`ec79d4b`](https://github.com/apache/spark/commit/ec79d4b1ebc9dbd7e592cd3d438f4521fd0460a9).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-901293499


   Kubernetes integration test unable to build dist.
   
   exiting with code: 1
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47120/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900058163


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47040/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900096719


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47040/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898383470


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46930/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899224037


   **[Test build #142487 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142487/testReport)** for PR 33736 at commit [`d2f0cfa`](https://github.com/apache/spark/commit/d2f0cfacd64689ce555fc6d450037cc0242031bf).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898863861






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898946994


   **[Test build #142468 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142468/testReport)** for PR 33736 at commit [`04bcc51`](https://github.com/apache/spark/commit/04bcc517e237f3a4297c21b2ef8eca9b7b07bbcb).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-901185645


   **[Test build #142615 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142615/testReport)** for PR 33736 at commit [`ec79d4b`](https://github.com/apache/spark/commit/ec79d4b1ebc9dbd7e592cd3d438f4521fd0460a9).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898947739


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142468/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900032200


   **[Test build #142539 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142539/testReport)** for PR 33736 at commit [`25a3b60`](https://github.com/apache/spark/commit/25a3b60dc470c5e0a4f1796bde7d25bef567d9d4).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33736:
URL: https://github.com/apache/spark/pull/33736#discussion_r691305225



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/PlanSuiteBase.scala
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql
+
+import org.apache.spark.sql.internal.SQLConf
+import org.apache.spark.sql.test.SharedSparkSession
+
+trait PlanSuiteBase extends SharedSparkSession {
+
+  private val originalCBCEnabled = conf.cboEnabled

Review comment:
       ```suggestion
     private val originalCBOEnabled = conf.cboEnabled
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-901584521


   thanks, merging to master!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #33736:
URL: https://github.com/apache/spark/pull/33736#discussion_r691314539



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
##########
@@ -102,15 +88,9 @@ trait TPCDSBase extends SharedSparkSession with TPCDSSchema {
     }
   }
 
-  override def afterAll(): Unit = {
-    conf.setConf(SQLConf.CBO_ENABLED, originalCBCEnabled)
-    conf.setConf(SQLConf.PLAN_STATS_ENABLED, originalPlanStatsEnabled)
-    conf.setConf(SQLConf.JOIN_REORDER_ENABLED, originalJoinReorderEnabled)
+  override def dropTables(): Unit = {
     tableNames.foreach { tableName =>
       spark.sessionState.catalog.dropTable(TableIdentifier(tableName), true, true)
     }
-    super.afterAll()
   }
-
-  protected def injectStats: Boolean = false

Review comment:
       > injectStats
   
   PlanSuiteBase

##########
File path: sql/core/src/test/scala/org/apache/spark/sql/PlanSuiteBase.scala
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql
+
+import org.apache.spark.sql.internal.SQLConf
+import org.apache.spark.sql.test.SharedSparkSession
+
+trait PlanSuiteBase extends SharedSparkSession {
+
+  private val originalCBCEnabled = conf.cboEnabled

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-901297491






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899380253


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47002/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898911863


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46975/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898808051


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46967/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-901222097


   Kubernetes integration test unable to build dist.
   
   exiting with code: 1
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47115/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900032200


   **[Test build #142539 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142539/testReport)** for PR 33736 at commit [`25a3b60`](https://github.com/apache/spark/commit/25a3b60dc470c5e0a4f1796bde7d25bef567d9d4).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899254332






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900278003


   **[Test build #142558 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142558/testReport)** for PR 33736 at commit [`21539ff`](https://github.com/apache/spark/commit/21539ff5e7b7be2f278195617a01457297c09f50).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898907331


   **[Test build #142468 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142468/testReport)** for PR 33736 at commit [`04bcc51`](https://github.com/apache/spark/commit/04bcc517e237f3a4297c21b2ef8eca9b7b07bbcb).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899193842


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46985/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898348538


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46930/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898876421


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142464/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-901007701


   Kubernetes integration test unable to build dist.
   
   exiting with code: 1
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47105/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898313278


   **[Test build #142424 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142424/testReport)** for PR 33736 at commit [`ad6585e`](https://github.com/apache/spark/commit/ad6585eee7e1c878b88990d853beb244b0f9db80).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899397152


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47002/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899191944


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46984/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898449880


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142424/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899446931


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47009/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899171541


   **[Test build #142477 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142477/testReport)** for PR 33736 at commit [`5c3805f`](https://github.com/apache/spark/commit/5c3805f9ee676f9ca15f2e234bfe8f46e89635e5).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899254332






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898862745


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46971/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899283196


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46986/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900641022






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898436694


   **[Test build #142424 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142424/testReport)** for PR 33736 at commit [`ad6585e`](https://github.com/apache/spark/commit/ad6585eee7e1c878b88990d853beb244b0f9db80).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899398247


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142501/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900764647


   **[Test build #142575 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142575/testReport)** for PR 33736 at commit [`21539ff`](https://github.com/apache/spark/commit/21539ff5e7b7be2f278195617a01457297c09f50).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898863861






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #33736:
URL: https://github.com/apache/spark/pull/33736#discussion_r690343645



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/PlanStabilitySuite.scala
##########
@@ -66,7 +66,7 @@ import org.apache.spark.sql.internal.SQLConf
  * }}}
  */
 // scalastyle:on line.size.limit
-trait PlanStabilitySuite extends TPCDSBase with DisableAdaptiveExecutionSuite {
+trait PlanStabilitySuite extends TPCDSBase with TPCHBase with DisableAdaptiveExecutionSuite {

Review comment:
       > It's a bit weird that `TPCDSBase` and `TPCHBase` are not at the same level (`TPCDSBase` is much more complicated). Can we do a bit more refactoring? Probably pull out some logic (e.g. `createTable`) from `TPCDSBase` to `PlanStabilitySuite` or a new `trait`.
   
   How about current?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900324751


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47060/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898383470


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46930/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898798085


   **[Test build #142461 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142461/testReport)** for PR 33736 at commit [`7e54bf8`](https://github.com/apache/spark/commit/7e54bf8bdfb9b6d7f10d7514ac4bf6534a8ad0b5).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-901432414


   **[Test build #142619 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142619/testReport)** for PR 33736 at commit [`c2940dc`](https://github.com/apache/spark/commit/c2940dc75b7de57ae3b625ddf912bbe1068d7e39).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `trait TPCBase extends SharedSparkSession `
     * `trait TPCDSBase extends TPCBase with TPCDSSchema `
     * `trait TPCHBase extends TPCBase `


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33736:
URL: https://github.com/apache/spark/pull/33736#discussion_r694054229



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCBase.scala
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql
+
+import org.apache.spark.SparkConf
+import org.apache.spark.sql.internal.SQLConf
+import org.apache.spark.sql.test.SharedSparkSession
+
+trait TPCBase extends SharedSparkSession {
+
+  protected def injectStats: Boolean = false
+
+  override def sparkConf: SparkConf = {

Review comment:
       nit: we should not remove the `protected` modifier here. It forces all the traits/classes extending this trait to also remove the `protected` modifier, which is an unnecessary breaking.
   
   See https://github.com/apache/spark/pull/33736/files#diff-67f98139e0b98db9e0e896ffbfe9d4a761bd579c8047c304bdca12906c476384L76




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898808051


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46967/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898920919


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46975/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898907331


   **[Test build #142468 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142468/testReport)** for PR 33736 at commit [`04bcc51`](https://github.com/apache/spark/commit/04bcc517e237f3a4297c21b2ef8eca9b7b07bbcb).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898824392


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46969/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898876421


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142464/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900205558


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142539/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898858958


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46971/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898311321


   FYI @wangyum @cloud-fan 
   Also ping @maropu What should I do with statistic data， I see you add tpcds's statistic data.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899191944






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899250993


   **[Test build #142477 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142477/testReport)** for PR 33736 at commit [`5c3805f`](https://github.com/apache/spark/commit/5c3805f9ee676f9ca15f2e234bfe8f46e89635e5).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-901297487






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899291654


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142487/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899446904


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47009/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898369943


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46930/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899322935


   **[Test build #142501 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142501/testReport)** for PR 33736 at commit [`17d3014`](https://github.com/apache/spark/commit/17d301435f77be134a93b1eec9a85db749e3a6ae).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-901222186


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47115/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899403987


   **[Test build #142508 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142508/testReport)** for PR 33736 at commit [`054a5e0`](https://github.com/apache/spark/commit/054a5e0f91f0663184b838f6406c46a5e26b70c6).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899184571


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46985/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-901007756


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47105/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-901222186


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47115/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900641022


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142558/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900822986


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142575/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-901379124


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142615/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #33736:
URL: https://github.com/apache/spark/pull/33736#discussion_r691314539



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
##########
@@ -102,15 +88,9 @@ trait TPCDSBase extends SharedSparkSession with TPCDSSchema {
     }
   }
 
-  override def afterAll(): Unit = {
-    conf.setConf(SQLConf.CBO_ENABLED, originalCBCEnabled)
-    conf.setConf(SQLConf.PLAN_STATS_ENABLED, originalPlanStatsEnabled)
-    conf.setConf(SQLConf.JOIN_REORDER_ENABLED, originalJoinReorderEnabled)
+  override def dropTables(): Unit = {
     tableNames.foreach { tableName =>
       spark.sessionState.catalog.dropTable(TableIdentifier(tableName), true, true)
     }
-    super.afterAll()
   }
-
-  protected def injectStats: Boolean = false

Review comment:
       > injectStats
   
   PlanSuiteBase




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899266804


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46986/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899170324


   **[Test build #142476 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142476/testReport)** for PR 33736 at commit [`5d0fedf`](https://github.com/apache/spark/commit/5d0fedf12b38b8e2e8acae37e09374f07d1d33e8).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-899244825


   **[Test build #142476 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142476/testReport)** for PR 33736 at commit [`5d0fedf`](https://github.com/apache/spark/commit/5d0fedf12b38b8e2e8acae37e09374f07d1d33e8).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `case class SessionWindow(timeColumn: Expression, gapDuration: Expression) extends Expression`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900797947


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47076/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900797833


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47076/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900324719


   Kubernetes integration test unable to build dist.
   
   exiting with code: 1
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47060/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-901443351


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142619/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900762616


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-900097247


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47041/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-898313278


   **[Test build #142424 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142424/testReport)** for PR 33736 at commit [`ad6585e`](https://github.com/apache/spark/commit/ad6585eee7e1c878b88990d853beb244b0f9db80).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33736:
URL: https://github.com/apache/spark/pull/33736#issuecomment-901153518


   **[Test build #142605 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142605/testReport)** for PR 33736 at commit [`989c823`](https://github.com/apache/spark/commit/989c823b71858860d61318e9d1d59dcc3e3dd801).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org