You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2011/01/24 20:16:45 UTC
[jira] Created: (HBASE-3470) Check that hbase-default.xml is loaded
from within jar
Check that hbase-default.xml is loaded from within jar
------------------------------------------------------
Key: HBASE-3470
URL: https://issues.apache.org/jira/browse/HBASE-3470
Project: HBase
Issue Type: Improvement
Affects Versions: 0.90.1
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Fix For: 0.90.1
Running hbase with an old version of hbase-default.xml on the classpath (as might happen when upgrading from 0.20 where it wasn't in the jar) can cause lots of strange problems. We should add a check at startup time that ensures that the hbase-default.xml file is coming out of the jar rather than somewhere on the classpath.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-3470) Check that hbase-default.xml is loaded
from within jar
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HBASE-3470:
-------------------------------
Attachment: hbase-3470.txt
Tested this patch by putting an hbase-default.xml on my classpath and verifying that "hbase shell" errored out. Removed the file and it worked OK. Tested in both a dev environment and an assembly environment.
> Check that hbase-default.xml is loaded from within jar
> ------------------------------------------------------
>
> Key: HBASE-3470
> URL: https://issues.apache.org/jira/browse/HBASE-3470
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.90.1
>
> Attachments: hbase-3470.txt
>
>
> Running hbase with an old version of hbase-default.xml on the classpath (as might happen when upgrading from 0.20 where it wasn't in the jar) can cause lots of strange problems. We should add a check at startup time that ensures that the hbase-default.xml file is coming out of the jar rather than somewhere on the classpath.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3470) Check that hbase-default.xml is
loaded from within jar
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990920#comment-12990920 ]
stack commented on HBASE-3470:
------------------------------
Should you say more in the RuntimeException your throw? E.g. Remove conf/hbase-default.xml if present? Otherwise, looks great.
> Check that hbase-default.xml is loaded from within jar
> ------------------------------------------------------
>
> Key: HBASE-3470
> URL: https://issues.apache.org/jira/browse/HBASE-3470
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.90.1
>
> Attachments: hbase-3470.txt
>
>
> Running hbase with an old version of hbase-default.xml on the classpath (as might happen when upgrading from 0.20 where it wasn't in the jar) can cause lots of strange problems. We should add a check at startup time that ensures that the hbase-default.xml file is coming out of the jar rather than somewhere on the classpath.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3470) Check that hbase-default.xml is
loaded from within jar
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12992300#comment-12992300 ]
Hudson commented on HBASE-3470:
-------------------------------
Integrated in HBase-TRUNK #1739 (See [https://hudson.apache.org/hudson/job/HBase-TRUNK/1739/])
Revert HBASE-3470 since it breaks job submission (HBASE-3517)
> Check that hbase-default.xml is loaded from within jar
> ------------------------------------------------------
>
> Key: HBASE-3470
> URL: https://issues.apache.org/jira/browse/HBASE-3470
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.90.1
>
> Attachments: hbase-3470.txt
>
>
> Running hbase with an old version of hbase-default.xml on the classpath (as might happen when upgrading from 0.20 where it wasn't in the jar) can cause lots of strange problems. We should add a check at startup time that ensures that the hbase-default.xml file is coming out of the jar rather than somewhere on the classpath.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HBASE-3470) Check that hbase-default.xml is
loaded from within jar
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon resolved HBASE-3470.
--------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Committed to branch and trunk. Amended the error message as suggested by Stack.
> Check that hbase-default.xml is loaded from within jar
> ------------------------------------------------------
>
> Key: HBASE-3470
> URL: https://issues.apache.org/jira/browse/HBASE-3470
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.90.1
>
> Attachments: hbase-3470.txt
>
>
> Running hbase with an old version of hbase-default.xml on the classpath (as might happen when upgrading from 0.20 where it wasn't in the jar) can cause lots of strange problems. We should add a check at startup time that ensures that the hbase-default.xml file is coming out of the jar rather than somewhere on the classpath.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3470) Check that hbase-default.xml is
loaded from within jar
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991804#comment-12991804 ]
Hudson commented on HBASE-3470:
-------------------------------
Integrated in HBase-TRUNK #1737 (See [https://hudson.apache.org/hudson/job/HBase-TRUNK/1737/])
> Check that hbase-default.xml is loaded from within jar
> ------------------------------------------------------
>
> Key: HBASE-3470
> URL: https://issues.apache.org/jira/browse/HBASE-3470
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.90.1
>
> Attachments: hbase-3470.txt
>
>
> Running hbase with an old version of hbase-default.xml on the classpath (as might happen when upgrading from 0.20 where it wasn't in the jar) can cause lots of strange problems. We should add a check at startup time that ensures that the hbase-default.xml file is coming out of the jar rather than somewhere on the classpath.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira