You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "viirya (via GitHub)" <gi...@apache.org> on 2026/01/12 23:33:58 UTC
[PR] [SPARK-XXXXX][SQL] Prevent stack overflow when SQLConf.get is called during sessionState initialization [spark]
viirya opened a new pull request, #53777:
URL: https://github.com/apache/spark/pull/53777
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
The fix adds a sessionStateInitialized flag to track whether sessionState has completed initialization. The confGetter now checks this flag before accessing sessionState.conf. When the flag is false (still initializing), it falls back to SQLConf.getFallbackConf instead of causing recursion.
Changes:
- Add sessionStateInitialized boolean flag to SparkSession
- Modify sessionState lazy val to set flag in finally block
- Add isSessionStateInitialized method to check initialization state
- Modify confGetter to check flag before accessing sessionState.conf
- Add two tests to verify the fix works correctly
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
This commit fixes a potential stack overflow issue that can occur when SQLConf.get.getConf() is called during SparkSession's sessionState initialization. The problem happens when:
1. SparkSession becomes active via setDefaultAndActiveSession
2. sessionState lazy val starts initializing (not yet complete)
3. During initialization, code calls SQLConf.get.getConf()
4. confGetter tries to access sessionState.conf
5. This creates a recursive loop because sessionState is still initializing
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Unit test
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
Generated-by: Claude Sonnet 4.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55016][SQL] Prevent stack overflow when SQLConf.get is called during sessionState initialization [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #53777:
URL: https://github.com/apache/spark/pull/53777#issuecomment-3741260674
> Thank you for improving this and adding a test case, @viirya . Just a question about test cases, they are not reproducing the stack overflow, aren't they? Do you have a code snippet to reproduce the initial finding?
No, they're not. We hit this issue when the SessionState initialization calls into `SQLConf.get.getConf`. That is some internal registration codes check SQLConf config to determine its behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55016][SQL] Prevent stack overflow when SQLConf.get is called during sessionState initialization [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #53777:
URL: https://github.com/apache/spark/pull/53777#discussion_r2688646231
##########
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionBuilderSuite.scala:
##########
@@ -598,4 +598,65 @@ class SparkSessionBuilderSuite extends SparkFunSuite with Eventually {
.getOrCreate()
assert(session.sparkContext.appName === "newAppName")
}
+
+ test("SPARK-55016: isSessionStateInitialized flag should track sessionState initialization") {
+ val session = SparkSession.builder()
+ .master("local")
+ .appName("test-session-state-init")
+ .getOrCreate()
+ .asInstanceOf[classic.SparkSession]
+
+ try {
+ // Before accessing sessionState, the flag should be false
+ assert(!session.isSessionStateInitialized,
+ "sessionState should not be initialized before first access")
+
+ // Access sessionState to trigger initialization
+ val _ = session.sessionState
+
+ // After accessing sessionState, the flag should be true
+ assert(session.isSessionStateInitialized,
+ "sessionState should be marked as initialized after access")
+ } finally {
+ session.stop()
+ }
+ }
+
+ test("SPARK-55016: SQLConf.get should return fallback conf " +
+ "when sessionState is not initialized") {
+ val session = SparkSession.builder()
+ .master("local")
+ .appName("test-sqlconf-fallback")
+ .getOrCreate()
+ .asInstanceOf[classic.SparkSession]
+
+ try {
+ // Before accessing sessionState, SQLConf.get should return fallback conf
+ assert(!session.isSessionStateInitialized,
+ "sessionState should not be initialized before first access")
+
+ val conf = SQLConf.get
+ val fallbackConf = SQLConf.getFallbackConf
+
+ // When sessionState is not initialized, SQLConf.get should equal fallback conf
+ assert(conf == fallbackConf,
Review Comment:
Okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55016][SQL] Prevent stack overflow when SQLConf.get is called during sessionState initialization [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #53777:
URL: https://github.com/apache/spark/pull/53777#discussion_r2689449879
##########
sql/core/src/main/scala/org/apache/spark/sql/classic/SparkSession.scala:
##########
@@ -169,6 +175,13 @@ class SparkSession private(
| Session-related state |
* ----------------------- */
+ /**
+ * Track whether sessionState is currently being initialized. Used to prevent recursive calls
+ * to sessionState.conf during initialization (e.g., from SQLConf.get).
+ */
+ @transient
+ private var sessionStateInitializing: Boolean = false
Review Comment:
why the default value is false? What happens if the session state has not started to initialize but `SQLConf.get` is called somwhere?
##########
sql/core/src/main/scala/org/apache/spark/sql/classic/SparkSession.scala:
##########
@@ -169,6 +175,13 @@ class SparkSession private(
| Session-related state |
* ----------------------- */
+ /**
+ * Track whether sessionState is currently being initialized. Used to prevent recursive calls
+ * to sessionState.conf during initialization (e.g., from SQLConf.get).
+ */
+ @transient
+ private var sessionStateInitializing: Boolean = false
Review Comment:
why the default value is false? What happens if the session state has not started to initialize but `SQLConf.get` is called somewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55016][SQL] Prevent stack overflow when SQLConf.get is called during sessionState initialization [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #53777:
URL: https://github.com/apache/spark/pull/53777#discussion_r2689573753
##########
sql/core/src/main/scala/org/apache/spark/sql/classic/SparkSession.scala:
##########
@@ -169,6 +175,13 @@ class SparkSession private(
| Session-related state |
* ----------------------- */
+ /**
+ * Track whether sessionState is currently being initialized. Used to prevent recursive calls
+ * to sessionState.conf during initialization (e.g., from SQLConf.get).
+ */
+ @transient
+ private var sessionStateInitializing: Boolean = false
Review Comment:
If the active session's session state is not initialized, it will hit `session.sessionState.conf` to initiate the session state to get its configs.
If the session state accesses SQLConf.get during initialization (previously the stack overflow case), as this flag is true now, it won't re-hit `session.sessionState.conf` again to trigger stack overflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55016][SQL] Prevent stack overflow when SQLConf.get is called during sessionState initialization [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya closed pull request #53777: [SPARK-55016][SQL] Prevent stack overflow when SQLConf.get is called during sessionState initialization
URL: https://github.com/apache/spark/pull/53777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55016][SQL] Prevent stack overflow when SQLConf.get is called during sessionState initialization [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #53777:
URL: https://github.com/apache/spark/pull/53777#discussion_r2689573753
##########
sql/core/src/main/scala/org/apache/spark/sql/classic/SparkSession.scala:
##########
@@ -169,6 +175,13 @@ class SparkSession private(
| Session-related state |
* ----------------------- */
+ /**
+ * Track whether sessionState is currently being initialized. Used to prevent recursive calls
+ * to sessionState.conf during initialization (e.g., from SQLConf.get).
+ */
+ @transient
+ private var sessionStateInitializing: Boolean = false
Review Comment:
If the active session's session state is not initialized, it will hit `session.sessionState.conf` to initiate the session state to get its configs.
If the session state accesses SQLConf.get during initialization (previously the stack overflow case), as this flag is true now, it won't re-hit `session.sessionState.conf` again to trigger stack overflow.
If the session state doesn't access SQLConf.get during initialization, it simply gets the configs of the session state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55016][SQL] Prevent stack overflow when SQLConf.get is called during sessionState initialization [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #53777:
URL: https://github.com/apache/spark/pull/53777#issuecomment-3765594903
Any more comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55016][SQL] Prevent stack overflow when SQLConf.get is called during sessionState initialization [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #53777:
URL: https://github.com/apache/spark/pull/53777#issuecomment-3768105349
I find it hacky to work around the circle dependency, I have a new idea to completely remove the circle dependency: https://github.com/apache/spark/pull/53854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-XXXXX][SQL] Prevent stack overflow when SQLConf.get is called during sessionState initialization [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #53777:
URL: https://github.com/apache/spark/pull/53777#issuecomment-3740981790
## ⚠️ Pull Request Title Validation
This pull request title does not contain a JIRA issue ID.
Please update the title to either:
- Include a JIRA ID: `[SPARK-12345] Your description`
- Mark as minor change: `[MINOR] Your description`
For minor changes that don't require a JIRA ticket (e.g., typo fixes), please prefix the title with `[MINOR]`.
---
*This comment was automatically generated by GitHub Actions*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55016][SQL] Prevent stack overflow when SQLConf.get is called during sessionState initialization [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #53777:
URL: https://github.com/apache/spark/pull/53777#discussion_r2685067033
##########
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionBuilderSuite.scala:
##########
@@ -598,4 +598,65 @@ class SparkSessionBuilderSuite extends SparkFunSuite with Eventually {
.getOrCreate()
assert(session.sparkContext.appName === "newAppName")
}
+
+ test("SPARK-55016: isSessionStateInitialized flag should track sessionState initialization") {
+ val session = SparkSession.builder()
+ .master("local")
+ .appName("test-session-state-init")
+ .getOrCreate()
+ .asInstanceOf[classic.SparkSession]
+
+ try {
+ // Before accessing sessionState, the flag should be false
+ assert(!session.isSessionStateInitialized,
+ "sessionState should not be initialized before first access")
+
+ // Access sessionState to trigger initialization
+ val _ = session.sessionState
+
+ // After accessing sessionState, the flag should be true
+ assert(session.isSessionStateInitialized,
+ "sessionState should be marked as initialized after access")
+ } finally {
+ session.stop()
+ }
+ }
+
+ test("SPARK-55016: SQLConf.get should return fallback conf " +
+ "when sessionState is not initialized") {
+ val session = SparkSession.builder()
+ .master("local")
+ .appName("test-sqlconf-fallback")
+ .getOrCreate()
+ .asInstanceOf[classic.SparkSession]
+
+ try {
+ // Before accessing sessionState, SQLConf.get should return fallback conf
+ assert(!session.isSessionStateInitialized,
+ "sessionState should not be initialized before first access")
+
+ val conf = SQLConf.get
+ val fallbackConf = SQLConf.getFallbackConf
+
+ // When sessionState is not initialized, SQLConf.get should equal fallback conf
+ assert(conf == fallbackConf,
Review Comment:
shall we check the reference? `conf.eq(fallbackConf)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55016][SQL] Prevent stack overflow when SQLConf.get is called during sessionState initialization [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #53777:
URL: https://github.com/apache/spark/pull/53777#issuecomment-3742748557
Interesting. This change causes some test failures. Seems we use SQLConf before SessionState initialization in many places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org